From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Munegowda, Keshava" Subject: Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation Date: Mon, 23 Jul 2012 20:04:52 +0530 Message-ID: References: <1342445471-18704-1-git-send-email-keshava_mgowda@ti.com> <20120723140830.GA8155@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aog112.obsmtp.com ([74.125.149.207]:36646 "EHLO na3sys009aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079Ab2GWOey (ORCPT ); Mon, 23 Jul 2012 10:34:54 -0400 Received: by vbbff1 with SMTP id ff1so5773065vbb.33 for ; Mon, 23 Jul 2012 07:34:53 -0700 (PDT) In-Reply-To: <20120723140830.GA8155@arwen.pp.htv.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: balbi@ti.com Cc: linux-omap@vger.kernel.org, Samuel Ortiz , Paul Walmsley , parthab@india.ti.com On Mon, Jul 23, 2012 at 7:38 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 23, 2012 at 07:31:10PM +0530, Munegowda, Keshava wrote: >> On Thu, Jul 19, 2012 at 3:48 PM, Munegowda, Keshava >> wrote: >> > On Mon, Jul 16, 2012 at 7:01 PM, Keshava Munegowda >> > wrote: >> >> The TLL (Transceiver Less Link) is an separate IP block, independent of >> >> the host controller. Basically this TLL operates like USB PHY which allows >> >> the user to connect two USB transceiver interfaces together directly >> >> without the use of differential transceivers in omap3 and later chips. >> >> The TLL configuration is removed from the UHH driver and implemented as >> >> a seperate platform driver. Now, the UHH driver configures the TLL >> >> through API's exported by the TLL platform driver. >> >> >> >> Signed-off-by: Keshava Munegowda >> >> >> >> In v4: >> >> - rebased on top of linux kernel version 3.5.rc7 >> >> - reworked as per the comments given by Paul Walmsley >> >> >> >> In v3: >> >> - rebased on top V3 of Russ dill's patch >> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >> fixes an issue where the ULPI PHYs were not held in reset >> >> while initializing the EHCI controller >> >> http://permalink.gmane.org/gmane.linux.usb.general/65988 >> >> >> >> - rebased on top of patch >> >> OMAP: USB : Fix the EHCI enumeration and core retention issue >> >> http://permalink.gmane.org/gmane.linux.usb.general/66239 >> >> >> >> In V2: >> >> - covered review comments from linux omap and usb community >> >> - rebased on top Russ dill's patch >> >> 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' >> >> fixes an issue where the ULPI PHYs were not held in reset >> >> while initializing the EHCI controller >> >> >> >> Keshava Munegowda (5): >> >> ARM: OMAP: Add the USB TLL clocks device name >> >> ARM: OMAP: USB: HOST TLL platform driver >> >> ARM: OMAP: USB: Invoke the TLL driver from USB HS core driver >> >> ARM: OMAP: USB: Remove TLL specific code from USB HS core driver >> >> ARM: OMAP: Remove older device name of the USB TLL clocks >> >> >> >> arch/arm/mach-omap2/clock3xxx_data.c | 8 +- >> >> arch/arm/mach-omap2/clock44xx_data.c | 4 +- >> >> arch/arm/mach-omap2/usb-host.c | 31 ++- >> >> arch/arm/plat-omap/include/plat/usb.h | 7 + >> >> drivers/mfd/Kconfig | 2 +- >> >> drivers/mfd/Makefile | 2 +- >> >> drivers/mfd/omap-usb-host.c | 238 ++--------------- >> >> drivers/mfd/omap-usb-tll.c | 471 +++++++++++++++++++++++++++++++++ >> >> 8 files changed, 523 insertions(+), 240 deletions(-) >> >> create mode 100644 drivers/mfd/omap-usb-tll.c >> >> >> >> -- >> >> 1.7.9.5 >> > >> > >> > Felipe/ Paul >> > please let me know if you have any review comments on this v4 series. >> > >> > regards >> > keshava >> >> Hi Felipe >> please let me know if you have any review comments on this series now. > > looks ok... pretty much just moving code around. > > -- > balbi Thanks Felipe then I request please give your Ack by for this series. regards keshava