From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AE05C433F5 for ; Thu, 11 Nov 2021 17:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0135761284 for ; Thu, 11 Nov 2021 17:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234357AbhKKRfb (ORCPT ); Thu, 11 Nov 2021 12:35:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234338AbhKKRf3 (ORCPT ); Thu, 11 Nov 2021 12:35:29 -0500 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C25C061766 for ; Thu, 11 Nov 2021 09:32:39 -0800 (PST) Received: by mail-oi1-x229.google.com with SMTP id o83so12842167oif.4 for ; Thu, 11 Nov 2021 09:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swiecki.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gvvpWtzRmL17H6APsk6foj0/Vw/9Xnyncdy1bzuH63E=; b=ArHl0YD2sgGiqJA1jV5y67ZYH9Uy0uYV8uVc+pPadvjgkveVO/zIXqjmpqtXWcbQpC H+scsvp9xhog2WQdWi/JwDT6cD1oAkcN1/RhtSg4heLhtbohjs+QCyKbeD68JBctX8at Xi/Txfoh5rRwuVNEfj+lZzks7mUMDg7fV5+zI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gvvpWtzRmL17H6APsk6foj0/Vw/9Xnyncdy1bzuH63E=; b=52xtKEJqYP950aODm18EqMqBQih+ZIfc1WHKrGBvRnZ/UI8h+QHMKgdp+4rAB2Aqaz WSnNpATcYCbittWzVLjo8z+Ge90rvOMW7aHIF30lOOtNp17m1ScNJRfrHwb9bllQ6PFi VN+TDVWe36KWK3S/ceJpgkd+ks+ZSyV7v5+WCZ3cO5v09ObT3X5zDDxOiyQaoxxFyphD VoY3bLhs2u/y31Lu2OEWUPPUhx+kiyE1V+4B7G+DoJ4xDtACmVrZUSKQofEm3JafLLUJ YbA+U0PfHT6uHcVyMa+lJZGZvix7luMYW0Rqquhzyn1ahbbNh7dd56J7Q5NjX4hhfIXJ mMbQ== X-Gm-Message-State: AOAM532NLRWpKenl5BJcolAI8pWGaoN3yQbZ4kh4hg/WEAvzZiGBAT2l Y4QttmYDswWNWF3WtjD3vGKT13lEYQT39Z2i/+t1Zg== X-Google-Smtp-Source: ABdhPJwbwnS0fHxon9yEvzcN7GX7OpMG1W6/SL6pJLUI39uxNyfgiOX+nJQSNOeHQfM/3hzqnezJ43G7n8q8i1NJ7nY= X-Received: by 2002:aca:d989:: with SMTP id q131mr7308053oig.167.1636651959329; Thu, 11 Nov 2021 09:32:39 -0800 (PST) MIME-Version: 1.0 References: <20211110211905.GA1261732@bhelgaas> <20211111170127.GA1336355@bhelgaas> In-Reply-To: <20211111170127.GA1336355@bhelgaas> From: =?UTF-8?B?Um9iZXJ0IMWad2nEmWNraQ==?= Date: Thu, 11 Nov 2021 18:32:28 +0100 Message-ID: Subject: Re: [PATCH] pci: Don't call resume callback for nearly bound devices To: Bjorn Helgaas Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-i2c , Bjorn Helgaas , Linux PCI , Linux PM , Linux Kernel Mailing List , Greg Kroah-Hartman , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Thank you very much for testing this. The patch changed the way we > > use runtime PM, and the dmesg snippets below look like they could be > > related to runtime PM issues. > > > > I think the conclusion is that we need to revert these commits: > > > > b5f9c644eb1b ("PCI: Remove struct pci_dev->driver") > > 2a4d9408c9e8 ("PCI: Use to_pci_driver() instead of pci_dev->driver") > > > > from Linus' tree. I queued up those reverts on > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h= =3Dfor-linus > > These reverts appeared in the Nov 11 linux-next tree. Any chance you > could verify that they solve the i2c_dw_pci_resume() issue? If it's > easier, you can apply them from: > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=3D= for-linus > instead. Looks good with the most recent 3 commits from for-linus applied on the top of the current linus' tree. No problematic dmesg entries, my Win11/vfio/kvm/qemu boots fine. --=20 Robert =C5=9Awi=C4=99cki