From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jianbo Liu <jianbo.liu@linaro.org>
Subject: Re: [PATCH v3 2/8] lib: add cryptodev type for the
 upcoming ARMv8 PMD
Date: Mon, 16 Jan 2017 13:57:38 +0800
Message-ID: <CAP4Qi388_wDn+2rK+NLobzCD=41Ej4LHULRicYVMcGjacuDLdQ@mail.gmail.com>
References: <1481077985-4224-2-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <1483551207-18236-1-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <1483551207-18236-3-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <9c3e96af-7cac-10a4-736a-f6690e9caaff@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>, dev@dpdk.org,
 pablo.de.lara.guarch@intel.com, Declan Doherty <declan.doherty@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yb0-f175.google.com (mail-yb0-f175.google.com
 [209.85.213.175]) by dpdk.org (Postfix) with ESMTP id 744E5FADF
 for <dev@dpdk.org>; Mon, 16 Jan 2017 06:57:39 +0100 (CET)
Received: by mail-yb0-f175.google.com with SMTP id 123so31285548ybe.3
 for <dev@dpdk.org>; Sun, 15 Jan 2017 21:57:39 -0800 (PST)
In-Reply-To: <9c3e96af-7cac-10a4-736a-f6690e9caaff@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 13 January 2017 at 16:16, Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> On 1/4/2017 11:03 PM, zbigniew.bodek@caviumnetworks.com wrote:
>>
>> From: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>
>>
>> Add type and name for ARMv8 crypto PMD
>>
>> Signed-off-by: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>
>> ---
>>  lib/librte_cryptodev/rte_cryptodev.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
>> b/lib/librte_cryptodev/rte_cryptodev.h
>> index 8f63e8f..6f34f22 100644
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -66,6 +66,8 @@
>>  /**< KASUMI PMD device name */
>>  #define CRYPTODEV_NAME_ZUC_PMD         crypto_zuc
>>  /**< KASUMI PMD device name */
>> +#define CRYPTODEV_NAME_ARMV8_PMD       crypto_armv8
>> +/**< ARMv8 Crypto PMD device name */
>>
> I will suggest the name as armv8ce or armv8_ce for this driver.
> Do you agree?
>

I don't because it's a lib only optimized for chained crypto and hash.

>
>>  /** Crypto device type */
>>  enum rte_cryptodev_type {
>> @@ -77,6 +79,7 @@ enum rte_cryptodev_type {
>>         RTE_CRYPTODEV_KASUMI_PMD,       /**< KASUMI PMD */
>>         RTE_CRYPTODEV_ZUC_PMD,          /**< ZUC PMD */
>>         RTE_CRYPTODEV_OPENSSL_PMD,    /**<  OpenSSL PMD */
>> +       RTE_CRYPTODEV_ARMV8_PMD,        /**< ARMv8 crypto PMD */
>>  };
>>
>>  extern const char **rte_cyptodev_names;
>>
>
>