From mboxrd@z Thu Jan 1 00:00:00 1970 From: "K, Mythri P" Subject: Re: [PATCH v2 02/10] OMAP4: DSS: HDMI: Move pll and video configuration Date: Fri, 2 Sep 2011 10:52:26 +0530 Message-ID: References: <1314598500-24005-1-git-send-email-mythripk@ti.com> <1314598500-24005-2-git-send-email-mythripk@ti.com> <1314598500-24005-3-git-send-email-mythripk@ti.com> <1314865665.2169.7.camel@lappyti> <1314940432.1907.1.camel@deskari> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:43167 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904Ab1IBFWr convert rfc822-to-8bit (ORCPT ); Fri, 2 Sep 2011 01:22:47 -0400 Received: by iafi7 with SMTP id i7so3981307iaf.21 for ; Thu, 01 Sep 2011 22:22:46 -0700 (PDT) In-Reply-To: <1314940432.1907.1.camel@deskari> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tomi Valkeinen Cc: linux-omap@vger.kernel.org Hi, On Fri, Sep 2, 2011 at 10:43 AM, Tomi Valkeinen = wrote: > On Fri, 2011-09-02 at 10:41 +0530, K, Mythri P wrote: >> Hi, >> >> On Thu, Sep 1, 2011 at 1:57 PM, Tomi Valkeinen wrote: >> > On Mon, 2011-08-29 at 11:44 +0530, mythripk@ti.com wrote: >> >> From: Mythri P K >> >> >> >> As the pll and the video configuration info are part of the ip_da= ta those >> >> structures are moved to the ip_data strtucure.Also the functions = are modified >> >> accordingly to take care of this movement. >> > >> > structure typoed, and use a space after period. >> > >> >> Signed-off-by: Mythri P K >> >> --- >> >> =A0drivers/video/omap2/dss/hdmi.c | =A0 34 +++++++++++++++-------= ------------ >> >> =A0drivers/video/omap2/dss/hdmi.h | =A0 18 ++++++++++-------- >> >> =A02 files changed, 25 insertions(+), 27 deletions(-) > >> >> -static int hdmi_pll_program(struct hdmi_ip_data *ip_data, >> >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct = hdmi_pll_info *fmt) >> >> +static int hdmi_pll_program(struct hdmi_ip_data *ip_data) >> >> =A0{ >> >> =A0 =A0 =A0 u16 r =3D 0; >> >> =A0 =A0 =A0 enum hdmi_clk_refsel refsel; >> >> @@ -399,7 +397,7 @@ static int hdmi_pll_program(struct hdmi_ip_da= ta *ip_data, >> >> >> >> =A0 =A0 =A0 refsel =3D HDMI_REFSEL_SYSCLK; >> >> >> >> - =A0 =A0 r =3D hdmi_pll_init(ip_data, refsel, fmt->dcofreq, fmt,= fmt->regsd); >> >> + =A0 =A0 r =3D hdmi_pll_init(ip_data, refsel); >> > >> > I don't think I quite understood why refsel is not part of the pll= info. >> > And if it has to be hardcoded, you could as well do that in >> > hdmi_pll_init(). >> > >> Ok , yes that is better. > > So, why refsel is not part of the pll info? The HW doesn't support > changing it? If so, is it only for OMAPs or for all SoCs? It is a variable parameter ,H/w supports changing it but it is never tr= ied, I was considering hard-coding it in the hdmi.c and passing it, so that there would be no hard-coding in IP functions. Thanks and regards, Mythri. > > =A0Tomi > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html