All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anuj Phogat <anuj.phogat@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Oscar Mateo <oscar.mateo@intel.com>,
	Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Revert "drm/i915/icl: WaEnableFloatBlendOptimization"
Date: Tue, 7 Aug 2018 14:36:25 -0700	[thread overview]
Message-ID: <CAP5d04H96pTbcj7F=-v3QAjWH5s7jo7V9rvFwW433yDprsLW3Q@mail.gmail.com> (raw)
In-Reply-To: <153357208192.30187.13129561222126122934@skylake-alporthouse-com>


[-- Attachment #1.1: Type: text/plain, Size: 1051 bytes --]

On Mon, Aug 6, 2018 at 9:14 AM Chris Wilson <chris@chris-wilson.co.uk>
wrote:

> Quoting Anuj Phogat (2018-08-03 20:24:09)
> >
> >
> > On Mon, Jul 30, 2018 at 5:07 AM Mika Kuoppala <
> mika.kuoppala@linux.intel.com>
> > wrote:
> >
> >     The register for 0xe420 is unable to hold any value, including
> >     this bit. The documentation is also mixed between having a
> >     register bit for toggle and having a state command setup
> >     for it. Apparently the register toggle is deprecated.
> >
> >
> >   CACHE_MODE_SS is not listed in
> > a
> > gfxspecs table
> > which lists all
> > user mode
> >   non-privileged registers. So,
> > do you think
> > making any changes
> > to the register
> >   from mesa will hold?
>
> No, a privileged write to the register from inside the ring didn't
> stick, so something is amiss.
>
ok. Mika's commit message confused me where he mentioned
about adding back the state
setup for this bit in mesa.
But, as
I understand now the changes won't stick in the register. So,
no changes required  in mesa.

-Chris
>

[-- Attachment #1.2: Type: text/html, Size: 2633 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2018-08-07 21:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 12:06 [PATCH] Revert "drm/i915/icl: WaEnableFloatBlendOptimization" Mika Kuoppala
2018-07-30 12:16 ` Chris Wilson
2018-08-01 14:43   ` Mika Kuoppala
2018-07-30 13:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-07-30 13:37   ` Chris Wilson
2018-07-30 13:59     ` Mika Kuoppala
2018-07-30 14:15       ` Chris Wilson
2018-07-30 14:59 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-03 19:24 ` [PATCH] " Anuj Phogat
2018-08-06 16:14   ` Chris Wilson
2018-08-07 21:36     ` Anuj Phogat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP5d04H96pTbcj7F=-v3QAjWH5s7jo7V9rvFwW433yDprsLW3Q@mail.gmail.com' \
    --to=anuj.phogat@gmail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=oscar.mateo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.