From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1BF7C433EF for ; Mon, 23 May 2022 13:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 7CCFFC385AA; Mon, 23 May 2022 13:44:32 +0000 (UTC) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id A0F23C385A9; Mon, 23 May 2022 13:44:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org A0F23C385A9 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-2f83983782fso148405027b3.6; Mon, 23 May 2022 06:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XPNftA/DKTK/dvQpog9avnEaQ3TQlTIxCXNc19+PcAc=; b=F7XY+xDJabBSZnWT7Co8MIS5MGWFxVdrs4yGK5blSOSq+CPW7kOaKdy4FmowiCQGeH kveDf2wY2jWk76yyfJLjFbC1BPpcG+arrA3p/8ISTPvvd0T7nAt427km96pp85sr6jjJ Oy1gCUxYtAmEdXYZeUxGuycedY9bqdtF+YBlIa7aEPJM5w6qAbNVaCkpl/Bs4YkgRB3P PjgQFOlaLkmG9puFomHUVRN/nzWLiH0dcA1sUcT8hzSyGjDYMgYSO9UOOYO2kya8uwWq G2PTuSKX05AxD7uJyT5W9QdBhpuf7wxcAsCEuGFg+wporn3AIJax0K9uzoefvKAr+vK3 2Gew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XPNftA/DKTK/dvQpog9avnEaQ3TQlTIxCXNc19+PcAc=; b=mXLHdMm2xQbk+dhwfkNvAOJIz5kFT6I1j+IKRgt3JQok7LDguAEVJ5H2ypcAtfZTgw 7/WkF66dLD8K/0714ob5qCojtMQWPcL0k7VZGO3QwRjrRlJJ1SoNoMouiYvxbwUojD3b Z5Y4BpMr9DTi/bRJbkNEhUO/x4/V9qzKAS+fL5GpFnt1FpYlKWwMDlfa9pR8M34M3t07 yPE3uRKQVNDgL74x9zr18pa0dkmEJm0EYIXbM7vY2QRedfzPXkyBl3tz1lBCpHEk+30W h6NenujK/OapY6ygDNC83vmO/hkzj//Z0vXRNdts9tx1hQrhfiAkmOqfnhPclntg2cRZ MzbA== X-Gm-Message-State: AOAM5316E1yTwXHp46wrOKtlus5NTIumcEjugDC0cGdSZLj2bgjKs2G1 +eFXBS4d7BqJjEP7DVir5yQF+6Phe2RuoQJ06/Q= X-Google-Smtp-Source: ABdhPJx1jMRAQ2KIm4uKfs2tJQNylZK638Pzy9lDKb1nuBj6ZwM0ls6edh/ZFq4kv1fTuSimYpbFFnimzVN0mL+tRFw= X-Received: by 2002:a0d:e585:0:b0:300:14ed:f2a with SMTP id o127-20020a0de585000000b0030014ed0f2amr1075302ywe.342.1653313470719; Mon, 23 May 2022 06:44:30 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-10-tmaimon77@gmail.com> In-Reply-To: From: Tomer Maimon Date: Mon, 23 May 2022 16:44:19 +0300 Message-ID: Subject: Re: [PATCH v1 09/19] dt-bindings: reset: add syscon property To: Krzysztof Kozlowski List-Id: Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , catalin.marinas@arm.com, will@kernel.org, Arnd Bergmann , Olof Johansson , jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, Vinod Koul , biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , lkundrak@v3.sk, soc@kernel.org, devicetree , Linux Kernel Mailing List , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, Linux ARM Content-Type: multipart/alternative; boundary="0000000000001feb4805dfae0a68" --0000000000001feb4805dfae0a68 Content-Type: text/plain; charset="UTF-8" Hi Krzysztof, Thanks for your comments. On Mon, 23 May 2022 at 10:39, Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > On 22/05/2022 17:50, Tomer Maimon wrote: > > Describe syscon property that handles GCR registers > > in Nuvoton BMC NPCM reset driver. > > Please wrap according to Linux standards: > > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Which problem do you see with the commit explanation body? > > > > > > Signed-off-by: Tomer Maimon > > --- > > Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > index 17b7a6a43a29..cb1613092ee7 100644 > > --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > > @@ -4,6 +4,7 @@ Required properties: > > - compatible : "nuvoton,npcm750-reset" for NPCM7XX BMC > > - reg : specifies physical base address and size of the register. > > - #reset-cells: must be set to 2 > > +- syscon: a phandle to access GCR registers. > > syscon is not a generic property, so vendor prefix and some descriptive > name of property. > > Will do. > > > > Optional property: > > - nuvoton,sw-reset-number - Contains the software reset number to > restart the SoC. > > @@ -16,6 +17,7 @@ Example: > > compatible = "nuvoton,npcm750-reset"; > > reg = <0xf0801000 0x70>; > > #reset-cells = <2>; > > + syscon = <&gcr>; > > nuvoton,sw-reset-number = <2>; > > }; > > > > > Best regards, > Krzysztof > Best Regards, Tomer --0000000000001feb4805dfae0a68 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Krzysztof,
=

Thanks for your comments.
=

On Mon, 23 May 2022 at 10:39, Krzysztof Kozlowski &l= t;krzysztof.kozlowski@lin= aro.org> wrote:
On 22/05/2022 17:50, Tomer Maimon wrote:
> Describe syscon property that handles GCR registers
> in Nuvoton BMC NPCM reset driver.

Please wrap according to Linux standards:
h= ttps://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/subm= itting-patches.rst#L586
Which problem do you see with = the commit explanation body?


>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>=C2=A0 Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt |= 2 ++
>=C2=A0 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm-rese= t.txt b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt
> index 17b7a6a43a29..cb1613092ee7 100644
> --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm-reset.txt > @@ -4,6 +4,7 @@ Required properties:
>=C2=A0 - compatible : "nuvoton,npcm750-reset" for NPCM7XX BMC=
>=C2=A0 - reg : specifies physical base address and size of the register= .
>=C2=A0 - #reset-cells: must be set to 2
> +- syscon: a phandle to access GCR registers.

syscon is not a generic property, so vendor prefix and some descriptive
name of property.

Will do.=C2=A0
>=C2=A0
>=C2=A0 Optional property:
>=C2=A0 - nuvoton,sw-reset-number - Contains the software reset number t= o restart the SoC.
> @@ -16,6 +17,7 @@ Example:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &= quot;nuvoton,npcm750-reset";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0xf0= 801000 0x70>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#reset-cells =3D= <2>;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0syscon =3D <&g= cr>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0nuvoton,sw-reset= -number =3D <2>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0};
>=C2=A0


Best regards,
Krzysztof

Best Regards,

<= /div>
Tomer=C2=A0
--0000000000001feb4805dfae0a68--