All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomer Maimon <tmaimon77@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Avi Fishman" <avifishman70@gmail.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Patrick Venture" <venture@google.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
	sboyd@kernel.org, "Philipp Zabel" <p.zabel@pengutronix.de>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	catalin.marinas@arm.com, will@kernel.org,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Olof Johansson" <olof@lixom.net>,
	jirislaby@kernel.org, shawnguo@kernel.org,
	bjorn.andersson@linaro.org, geert+renesas@glider.be,
	marcel.ziswiler@toradex.com, "Vinod Koul" <vkoul@kernel.org>,
	biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp,
	robert.hancock@calian.com,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	lkundrak@v3.sk, soc@kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-watchdog@vger.kernel.org,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock
Date: Mon, 23 May 2022 16:35:05 +0300	[thread overview]
Message-ID: <CAP6Zq1gXEqqquKzxTHoxYnvh2LCGt-ES+k=aX61FKyHW5WB62w@mail.gmail.com> (raw)
In-Reply-To: <edf1faf3-178c-bc89-148d-892f41492d26@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 5465 bytes --]

Hi Krzysztof,

Thanks for your comments.

the patch will modify according to your comments and will be sent in the
next kernel revision 5.19.rc1

On Mon, 23 May 2022 at 10:36, Krzysztof Kozlowski <
krzysztof.kozlowski@linaro.org> wrote:

> On 22/05/2022 17:50, Tomer Maimon wrote:
> > Nuvoton Arbel BMC NPCM7XX contains an integrated clock controller, which
> > generates and supplies clocks to all modules within the BMC.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> >  .../bindings/clock/nuvoton,npcm845-clk.yaml   | 68 +++++++++++++++++++
> >  .../dt-bindings/clock/nuvoton,npcm8xx-clock.h | 50 ++++++++++++++
> >  2 files changed, 118 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> >  create mode 100644 include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
> >
> > diff --git
> a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> > new file mode 100644
> > index 000000000000..f305c7c7eaf0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton NPCM8XX Clock Controller Binding
> > +
> > +maintainers:
> > +  - Tomer Maimon <tmaimon77@gmail.com>
> > +
> > +description: |
> > +  Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller,
> which
> > +  generates and supplies clocks to all modules within the BMC.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nuvoton,npcm845-clk
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description:
> > +      specify the external clocks used by the NPCM8XX clock module.
>
> Skip description, it's obvious.
>
> > +    items:
> > +      - description: 25M reference clock
> > +      - description: CPU reference clock
> > +      - description: MC reference clock
> > +
> > +  clock-names:
> > +    description:
> > +      specify the external clocks names used by the NPCM8XX clock
> module.
>
> Skip description, it's obvious.
>
> > +    items:
> > +      - const: refclk
>
> Just "ref"
>
> > +      - const: sysbypck
> > +      - const: mcbypck
>
> Is "ck" short for "clk"? If yes, then just skip the suffix.
>
ck

>
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +    description:
> > +      See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full
> > +      list of NPCM8XX clock IDs.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#clock-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  # Clock Control Module node:
> > +  - |
> > +
>
> No need for blank line.
>
> > +    ahb {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        clk: clock-controller@f0801000 {
> > +            compatible = "nuvoton,npcm845-clk";
> > +            reg = <0x0 0xf0801000 0x0 0x1000>;
> > +            #clock-cells = <1>;
> > +        };
> > +    };
> > +
> > +...
> > diff --git a/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
> b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
> > new file mode 100644
> > index 000000000000..d76f606bf88b
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
>
> Filename - same as bindings, so nuvoton,npcm845-clk.h
>
> > @@ -0,0 +1,50 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> Dual license, same as bindings.
>
> > +/*
> > + * Nuvoton NPCM8xx Clock Generator binding
> > + * clock binding number for all clocks supportted by nuvoton,npcm8xx-clk
> > + *
> > + * Copyright (C) 2021 Nuvoton Technologies tomer.maimon@nuvoton.com
> > + *
> > + */
> > +
> > +#ifndef __DT_BINDINGS_CLOCK_NPCM8XX_H
> > +#define __DT_BINDINGS_CLOCK_NPCM8XX_H
> > +
> > +#define NPCM8XX_CLK_CPU              0
> > +#define NPCM8XX_CLK_GFX_PIXEL        1
> > +#define NPCM8XX_CLK_MC               2
> > +#define NPCM8XX_CLK_ADC              3
> > +#define NPCM8XX_CLK_AHB              4
> > +#define NPCM8XX_CLK_TIMER    5
> > +#define NPCM8XX_CLK_UART     6
> > +#define NPCM8XX_CLK_UART2    7
> > +#define NPCM8XX_CLK_MMC              8
> > +#define NPCM8XX_CLK_SPI3     9
> > +#define NPCM8XX_CLK_PCI              10
> > +#define NPCM8XX_CLK_AXI              11
> > +#define NPCM8XX_CLK_APB4     12
> > +#define NPCM8XX_CLK_APB3     13
> > +#define NPCM8XX_CLK_APB2     14
> > +#define NPCM8XX_CLK_APB1     15
> > +#define NPCM8XX_CLK_APB5     16
> > +#define NPCM8XX_CLK_CLKOUT   17
> > +#define NPCM8XX_CLK_GFX              18
> > +#define NPCM8XX_CLK_SU               19
> > +#define NPCM8XX_CLK_SU48     20
> > +#define NPCM8XX_CLK_SDHC     21
> > +#define NPCM8XX_CLK_SPI0     22
> > +#define NPCM8XX_CLK_SPI1     23
> > +#define NPCM8XX_CLK_SPIX     24
> > +#define NPCM8XX_CLK_RG               25
> > +#define NPCM8XX_CLK_RCP              26
> > +#define NPCM8XX_CLK_PRE_ADC  27
> > +#define NPCM8XX_CLK_ATB              28
> > +#define NPCM8XX_CLK_PRE_CLK  29
> > +#define NPCM8XX_CLK_TH               30
> > +#define NPCM8XX_CLK_REFCLK   31
> > +#define NPCM8XX_CLK_SYSBYPCK 32
> > +#define NPCM8XX_CLK_MCBYPCK  33
> > +
> > +#define NPCM8XX_NUM_CLOCKS   (NPCM8XX_CLK_MCBYPCK + 1)
> > +
> > +#endif
>
>
> Best regards,
> Krzysztof
>

Best regards,

Tomer

[-- Attachment #2: Type: text/html, Size: 7740 bytes --]

  reply	other threads:[~2022-05-23 13:35 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-22 15:50 [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 01/19] dt-bindings: timer: npcm: Add npcm845 compatible string Tomer Maimon
2022-05-23  7:31   ` Krzysztof Kozlowski
2022-05-23  7:31     ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 02/19] clocksource: timer-npcm7xx: Add NPCM845 timer support Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 03/19] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon
2022-05-23  7:32   ` Krzysztof Kozlowski
2022-05-23  7:32     ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Tomer Maimon
2022-05-23  9:56   ` Arnd Bergmann
2022-05-23  9:56     ` Arnd Bergmann
2022-05-23 12:58     ` Tomer Maimon
2022-05-23 13:06       ` Krzysztof Kozlowski
2022-05-23 13:06         ` Krzysztof Kozlowski
2022-05-23 13:14         ` Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 05/19] dt-bindings: watchdog: npcm: Add npcm845 compatible string Tomer Maimon
2022-05-23  7:32   ` Krzysztof Kozlowski
2022-05-23  7:32     ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 06/19] watchdog: npcm_wdt: Add NPCM845 watchdog support Tomer Maimon
2022-05-22 16:45   ` Guenter Roeck
2022-05-22 16:45     ` Guenter Roeck
2022-05-22 15:50 ` [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon
2022-05-23  7:35   ` Krzysztof Kozlowski
2022-05-23  7:35     ` Krzysztof Kozlowski
2022-05-23 13:35     ` Tomer Maimon [this message]
2022-05-26 19:24   ` Stephen Boyd
2022-05-26 19:24     ` Stephen Boyd
2022-05-30 14:39     ` Tomer Maimon
2022-05-30 14:39       ` Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 08/19] clk: npcm8xx: add clock controller Tomer Maimon
2022-05-23  7:07   ` Ilpo Järvinen
2022-05-23  7:07     ` Ilpo Järvinen
2022-05-23 12:48     ` Tomer Maimon
2022-05-26 19:36   ` Stephen Boyd
2022-05-26 19:36     ` Stephen Boyd
2022-05-30 14:36     ` Tomer Maimon
2022-05-30 14:36       ` Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 09/19] dt-bindings: reset: add syscon property Tomer Maimon
2022-05-23  7:39   ` Krzysztof Kozlowski
2022-05-23  7:39     ` Krzysztof Kozlowski
2022-05-23 13:44     ` Tomer Maimon
2022-05-23 13:45       ` Krzysztof Kozlowski
2022-05-23 13:45         ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 10/19] reset: npcm: using syscon instead of device data Tomer Maimon
2022-05-23  8:54   ` Krzysztof Kozlowski
2022-05-23  8:54     ` Krzysztof Kozlowski
2022-05-23 13:53     ` Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon
2022-05-23  9:01   ` Krzysztof Kozlowski
2022-05-23  9:01     ` Krzysztof Kozlowski
2022-05-23 14:03     ` Tomer Maimon
2022-05-23 14:22       ` Geert Uytterhoeven
2022-05-23 14:22         ` Geert Uytterhoeven
2022-05-23 14:26         ` Krzysztof Kozlowski
2022-05-23 14:26           ` Krzysztof Kozlowski
2022-05-23 15:11           ` Geert Uytterhoeven
2022-05-23 15:11             ` Geert Uytterhoeven
2022-05-23 15:22             ` Krzysztof Kozlowski
2022-05-23 15:22               ` Krzysztof Kozlowski
2022-05-23 15:24               ` Krzysztof Kozlowski
2022-05-23 15:24                 ` Krzysztof Kozlowski
2022-05-24  7:26               ` Tomer Maimon
2022-05-24  7:26                 ` Tomer Maimon
2022-05-23 14:23       ` Krzysztof Kozlowski
2022-05-23 14:23         ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 12/19] reset: npcm: Add NPCM8XX support Tomer Maimon
2022-05-23 10:44   ` Arnd Bergmann
2022-05-23 10:44     ` Arnd Bergmann
2022-05-22 15:50 ` [PATCH v1 13/19] dt-bindings: arm: npcm: Add maintainer Tomer Maimon
2022-06-02 12:58   ` Rob Herring
2022-06-02 12:58     ` Rob Herring
2022-05-22 15:50 ` [PATCH v1 14/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon
2022-05-23  9:02   ` Krzysztof Kozlowski
2022-05-23  9:02     ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon
2022-05-23  9:02   ` Krzysztof Kozlowski
2022-05-23  9:02     ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski
2022-05-23  9:02   ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 " Krzysztof Kozlowski
2022-05-23  9:02     ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 16/19] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon
2022-05-22 15:50 ` [PATCH v1 17/19] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon
2022-05-23  9:08   ` Krzysztof Kozlowski
2022-05-23  9:08     ` Krzysztof Kozlowski
2022-05-23 13:58     ` Geert Uytterhoeven
2022-05-23 13:58       ` Geert Uytterhoeven
2022-05-23 14:16       ` Krzysztof Kozlowski
2022-05-23 14:16         ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 18/19] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon
2022-05-23  9:26   ` Krzysztof Kozlowski
2022-05-23  9:26     ` Krzysztof Kozlowski
2022-05-23  9:39   ` Arnd Bergmann
2022-05-23  9:39     ` Arnd Bergmann
2022-05-23 14:17     ` Tomer Maimon
2022-05-23 15:37       ` Krzysztof Kozlowski
2022-05-23 15:37         ` Krzysztof Kozlowski
2022-05-22 15:50 ` [PATCH v1 19/19] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon
2022-05-23  9:52 ` [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Arnd Bergmann
2022-05-23  9:52   ` Arnd Bergmann
2022-05-23 12:20   ` Tomer Maimon
2022-05-30 12:24   ` Andy Shevchenko
2022-05-30 12:24     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP6Zq1gXEqqquKzxTHoxYnvh2LCGt-ES+k=aX61FKyHW5WB62w@mail.gmail.com' \
    --to=tmaimon77@gmail.com \
    --cc=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=jirislaby@kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkundrak@v3.sk \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mturquette@baylibre.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=olof@lixom.net \
    --cc=p.zabel@pengutronix.de \
    --cc=robert.hancock@calian.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=venture@google.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=wim@linux-watchdog.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.