From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED24DC433F5 for ; Mon, 30 May 2022 15:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241840AbiE3PgJ (ORCPT ); Mon, 30 May 2022 11:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240809AbiE3Pey (ORCPT ); Mon, 30 May 2022 11:34:54 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA57D1F62D0; Mon, 30 May 2022 07:39:48 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id z186so15087336ybz.3; Mon, 30 May 2022 07:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PwYudAlsrV6L0E/1oct3kLnDMatMHOnVQrUxmfQHNp0=; b=nJb/D6o7T7a8Mb297LS5itZxyr9hhXOWE4cI1CS2gGTaAQcWmDs6sgxITAckTcsbqO aVjCnMiZTw+b4RHeeUOfs7ZZ8uhJu+9H3vrDwR8kDUeIJPmAAz+dNjR8nEL4TV+1QxDF u49vwV3izHOZZjnCA/h3xEh2LMtiihGNrkHxPVvfRH9pZsq1jJB+cD3l2YcOrZE/FHV3 oO0LniQOktfpUCJyeRfpEKg9DDa8WBNFOctawAeqAkazISl11g4V/X/KrhW3BSqcXDpM rHmuPxyGLKaHOFGx+URNH8GUTtkCZhF8UINV8Pv9mO9GCiQtRvv2jNcgvDl1QzaFiII6 59oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PwYudAlsrV6L0E/1oct3kLnDMatMHOnVQrUxmfQHNp0=; b=aoPXoIOYdhP8cLmwgoLQBRKqKz87uOKGoGp2WRT8WCelpPCiyjAqqm/N/1Fyaqqj7i 9EpRd4LnnfG24ufFc0WoLojpisWHGN5149fJqESDyTwNiG2uwu0eQ55j3mn+s0vacKHh eigz2zr5Yh8gEd1LwGqWYjOvMYznSQaoEXObuJsvU3G33SBEuRsEDun2bJWXjZFjL131 hIJRv0sz+Yij7YJggW9sTQp/ilq/QkJjE6BMnnmeDHUBVV74KO6hwbnRUMs+N4HpgDoG 98KW9XWstKZleeBhmwQz/E87cIcBmRfevhNteJjJZ+lPpJnys9C2zD5ls7ugGZlOY8hb 5rSw== X-Gm-Message-State: AOAM533KDGkmo1GnxSNfa5ZeMNdzyV3mJ/ced2T/4aotX++ACxFArTVa d/zufvtSTrCnNvvCZYWlZwAvgApjqI6jyDTYe7o= X-Google-Smtp-Source: ABdhPJwrsgLQtAtWqwcrdq2e1TjIgoIDbrErxGbmJH2wa0Fkm6oxdLbvdkS+K4BYIuwE3er69f8iVYy5UEogxMtnFeI= X-Received: by 2002:a25:21c3:0:b0:64a:b29a:9b0d with SMTP id h186-20020a2521c3000000b0064ab29a9b0dmr54184246ybh.59.1653921585005; Mon, 30 May 2022 07:39:45 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-8-tmaimon77@gmail.com> <20220526192412.8ECAAC385A9@smtp.kernel.org> In-Reply-To: <20220526192412.8ECAAC385A9@smtp.kernel.org> From: Tomer Maimon Date: Mon, 30 May 2022 17:39:34 +0300 Message-ID: Subject: Re: [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock To: Stephen Boyd Cc: Arnd Bergmann , Avi Fishman , Benjamin Fair , Biju Das , Bjorn Andersson , Catalin Marinas , Daniel Lezcano , Geert Uytterhoeven , Greg KH , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Jiri Slaby , Joel Stanley , Krzysztof Kozlowski , Guenter Roeck , Lubomir Rintel , Marcel Ziswiler , Michael Turquette , Nobuhiro Iwamatsu , Olof Johansson , Philipp Zabel , Robert Hancock , Rob Herring , Shawn Guo , Tali Perry , Thomas Gleixner , Patrick Venture , Vinod Koul , Will Deacon , Wim Van Sebroeck , Nancy Yuen , SoC Team , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, Thanks for your comments. The patch will modify according to your comments and will be sent in the next kernel revision 5.19.rc1 On Thu, 26 May 2022 at 22:24, Stephen Boyd wrote: > > Quoting Tomer Maimon (2022-05-22 08:50:34) > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..f305c7c7eaf0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,68 @@ > [...] > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > Are clocks not required because sometimes the reference clk isn't > connected? require, will be fixed > > > + > > +additionalProperties: false > > + > > +examples: > > + # Clock Control Module node: > > + - | > > + > > + ahb { > > drop ahb node please. > > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + clk: clock-controller@f0801000 { > > Drop label 'clk' as well please. > > > + compatible = "nuvoton,npcm845-clk"; > > + reg = <0x0 0xf0801000 0x0 0x1000>; > > + #clock-cells = <1>; > > + }; > > + }; > > + > > +... Best regards, Tomer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62363C433F5 for ; Mon, 30 May 2022 14:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LJrPSmLVpfivKPPtRCKHEoJlj1p4oTRkKaE0QnM/P98=; b=2pqlVPaNaQUDNL ChQ0oQqABKSLoIO/km4D0uALEaOYW3hP5EPP+8VrottlMgN+dcv2APc6Yr6gLhuQZp2b5NMre/679 p82LL2blaxrCZwbvZWqN9ctBL1DMiK8Bj6rbWsUaP4+Cv+io6PVP6GGsPkkmDzdQgbb0VqmayIzSf c28g4RragxCEs6FYI0xK9l3YTV5/CSa+KaQDRx4Id9uOURYzcMiZdLyXfH3HG10sQ3UGV8AcDpx34 VTNW+cWpEq1s3mw687wCFE/Km0XfuVYxvlGgChPDpudGTUABs8RH34LObb22S9wKihUqCVY7uH6ar VjA33X5uUocnc9E0WBkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvggL-007MPz-2C; Mon, 30 May 2022 14:47:45 +0000 Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvgYf-007Ijb-07 for linux-arm-kernel@lists.infradead.org; Mon, 30 May 2022 14:39:50 +0000 Received: by mail-yb1-xb35.google.com with SMTP id v22so785891ybd.5 for ; Mon, 30 May 2022 07:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PwYudAlsrV6L0E/1oct3kLnDMatMHOnVQrUxmfQHNp0=; b=nJb/D6o7T7a8Mb297LS5itZxyr9hhXOWE4cI1CS2gGTaAQcWmDs6sgxITAckTcsbqO aVjCnMiZTw+b4RHeeUOfs7ZZ8uhJu+9H3vrDwR8kDUeIJPmAAz+dNjR8nEL4TV+1QxDF u49vwV3izHOZZjnCA/h3xEh2LMtiihGNrkHxPVvfRH9pZsq1jJB+cD3l2YcOrZE/FHV3 oO0LniQOktfpUCJyeRfpEKg9DDa8WBNFOctawAeqAkazISl11g4V/X/KrhW3BSqcXDpM rHmuPxyGLKaHOFGx+URNH8GUTtkCZhF8UINV8Pv9mO9GCiQtRvv2jNcgvDl1QzaFiII6 59oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PwYudAlsrV6L0E/1oct3kLnDMatMHOnVQrUxmfQHNp0=; b=WhMUJOxR+waLo4R0TDt42o5TL3m1QMR2Br+YBTU6n35qWFkx0v2Bq9goPdsI50kVbe 2/QB9UAjYvPGelqaA5F9WTfzx61fr4de09sq5L0xZgycByZLVztz0dyoRq2AkcXBCc/9 AJh8R+qfh3vDeFSajOBq+ZrTtl0Fx9FTW0Zy1j23mhVI5GyU47jXBH1iki5kELdTVcLY WDf2u5WYgaHeZwxlmLWiHy/KV/gFICazyWqIkZ8elNTAdhs11X1l9SFHN/PFopXMy/0I BvEUzt0jSRRxBn1HEs58joZ+EVhQAR8JIeb2l7Z9bakI4wVKxsGwdPhuLIPSoSuPXWXr VhaQ== X-Gm-Message-State: AOAM531zivRd3G0p64TseCGr8NvdRSlOlFJumpEgX+VQcOacLluU+4x0 m9AkHa6tuQlv6WVcY6E9Bfqagwj+nOn72pJFNzM= X-Google-Smtp-Source: ABdhPJwrsgLQtAtWqwcrdq2e1TjIgoIDbrErxGbmJH2wa0Fkm6oxdLbvdkS+K4BYIuwE3er69f8iVYy5UEogxMtnFeI= X-Received: by 2002:a25:21c3:0:b0:64a:b29a:9b0d with SMTP id h186-20020a2521c3000000b0064ab29a9b0dmr54184246ybh.59.1653921585005; Mon, 30 May 2022 07:39:45 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-8-tmaimon77@gmail.com> <20220526192412.8ECAAC385A9@smtp.kernel.org> In-Reply-To: <20220526192412.8ECAAC385A9@smtp.kernel.org> From: Tomer Maimon Date: Mon, 30 May 2022 17:39:34 +0300 Message-ID: Subject: Re: [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock To: Stephen Boyd Cc: Arnd Bergmann , Avi Fishman , Benjamin Fair , Biju Das , Bjorn Andersson , Catalin Marinas , Daniel Lezcano , Geert Uytterhoeven , Greg KH , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Jiri Slaby , Joel Stanley , Krzysztof Kozlowski , Guenter Roeck , Lubomir Rintel , Marcel Ziswiler , Michael Turquette , Nobuhiro Iwamatsu , Olof Johansson , Philipp Zabel , Robert Hancock , Rob Herring , Shawn Guo , Tali Perry , Thomas Gleixner , Patrick Venture , Vinod Koul , Will Deacon , Wim Van Sebroeck , Nancy Yuen , SoC Team , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220530_073949_123669_DA3B860A X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, Thanks for your comments. The patch will modify according to your comments and will be sent in the next kernel revision 5.19.rc1 On Thu, 26 May 2022 at 22:24, Stephen Boyd wrote: > > Quoting Tomer Maimon (2022-05-22 08:50:34) > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..f305c7c7eaf0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,68 @@ > [...] > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > Are clocks not required because sometimes the reference clk isn't > connected? require, will be fixed > > > + > > +additionalProperties: false > > + > > +examples: > > + # Clock Control Module node: > > + - | > > + > > + ahb { > > drop ahb node please. > > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + clk: clock-controller@f0801000 { > > Drop label 'clk' as well please. > > > + compatible = "nuvoton,npcm845-clk"; > > + reg = <0x0 0xf0801000 0x0 0x1000>; > > + #clock-cells = <1>; > > + }; > > + }; > > + > > +... Best regards, Tomer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel