From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E47C00140 for ; Tue, 26 Jul 2022 19:33:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239630AbiGZTdS (ORCPT ); Tue, 26 Jul 2022 15:33:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239423AbiGZTdL (ORCPT ); Tue, 26 Jul 2022 15:33:11 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB9012778; Tue, 26 Jul 2022 12:33:10 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id p10so16587911lfd.9; Tue, 26 Jul 2022 12:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fR1dczgLxpZ02G+EclfekDkoYiKhvbST8mgypurlcnY=; b=m3lc4+qIWX3T6M2+KKp6mZF2S4BCl6PzktWcterEKkqck7dVWQjN49xWIcn8DPTaPM GdbaC1JjvyEiZre6lcBKIOl7BpqUJnYAkluWn/m8I9y6i6+G6pro26Oy5KlLIeUPFcth e5Jth3X/Cpk5T3XXCjeDcMnN88PxQAHDW4UUhjB+E/J3R/kIHFjEc9/1Iy47/rM5NzLT l9Efe5mvMPXfL0cQ9x1ZhWzUqUh1s04FT5iAYcNXxLBemPMamjx2nJ6zKR1flgmdG0FT huG71wIpondJOGxz3jq7PdGAVn0dr1EwxoYx8oCq9d1jRC+8LQzCXeFcZJM9zRUMBTmU LScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fR1dczgLxpZ02G+EclfekDkoYiKhvbST8mgypurlcnY=; b=uFxUB7CfhWUWdASCIzPKYzgOCKiKuta9FaEK3xDZKNbpLRW8L1BQ/vyBcATKfqSpSC abR0GLtWKJ5p9WwE0fbsDCzC7Mo03TqogPRWLopG6/p0Q19WFZwy6U3jfh9H7u0I+AB6 7uITVPc0r0AOjYTkRbAqY05K+ni7dSW19Nc2FvTmAW/QDemzsiy2u2lrDUnjTm9yYQRs vf4MIRNxAXPMzT8CcnCADB3pM0iFehPdBaPkL2jJDvacDmZspkZWY3HLjf6qLkdEMBR5 qLuZQV2uXrQ0ax6AuYktZtVUmkvBlwNHkdMbKNtQew2hhAk471DfQtuSiWrJZsawd9E+ /VSw== X-Gm-Message-State: AJIora/CVmukk+9LAjJkwImpnPY+L4nQRzSOHoqLzB6PurfJr5ly2ZEA 4SN1MZ98NajC4m7WNWIYRnOHLA/ZTr1PWHuvtkY= X-Google-Smtp-Source: AGRyM1sO/5Vm+fBeb2gt2lsBqm4kaXr1AAok8SnmnIdPf3F0WsG3UoMQ+b6lvQ1SzSmAUALwPzOPXIAh4swyRdGzqy4= X-Received: by 2002:a05:6512:693:b0:48a:7c23:1896 with SMTP id t19-20020a056512069300b0048a7c231896mr7355400lfe.111.1658863988371; Tue, 26 Jul 2022 12:33:08 -0700 (PDT) MIME-Version: 1.0 References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> <20869b88-41f3-9e9c-347e-17c3d01baa5d@linaro.org> In-Reply-To: <20869b88-41f3-9e9c-347e-17c3d01baa5d@linaro.org> From: Tomer Maimon Date: Tue, 26 Jul 2022 22:32:56 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support To: Krzysztof Kozlowski Cc: Mark Brown , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , OpenBMC Maillist , linux-spi@vger.kernel.org, Linux Kernel Mailing List , devicetree Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Thanks for your explanation. On Tue, 26 Jul 2022 at 12:47, Krzysztof Kozlowski wrote: > > On 24/07/2022 10:44, Tomer Maimon wrote: > > Hi Mark and Krzysztof, > > > > Thanks for your reply, > > > > On Fri, 22 Jul 2022 at 21:57, Mark Brown wrote: > >> > >> On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote: > >>> On 22/07/2022 20:43, Mark Brown wrote: > >> > >>>> ...with a fallback list required by the bindings so the driver actually > >>>> binds. Note that bindings are currently not in YAML format so there'd > >>>> be even less enforcement of that than normal, and as they're currently > >>>> written the bindings don't require fallback. > >> > >>> Yes, the bindings document should be rephrased but we were living like > >>> that for few years. :) > >> > >> The binding document as it stands only has one compatible, there's no > >> existing problem with it other than the YAML conversion. If we're > >> adding something new that requires a fallback we should be explicit > >> about that rather than have something that's actively misleading where > >> previously things were clear. I don't mind if we add the compatible to > >> the driver or document the requirement for the fallback but we should do > >> one of the two. > > > > is V2 good enough? adding the compatible to the driver and the document? > > Or should we use fallback? > > If fallback is choosen, can you explain how I should do it? > > I propose to use fallback. The preferred way is to convert it to DT > schema and then add new device support (so two commits). Other > acceptable way is to rephrase the TXT so it clearly states desired > compatibles - one for old device, two for new devices. There are plenty > of examples in current sources. Appreciate if you could clarify. in case we use DT-schema, we dont describe the fallback like we doing in txt document? I mean that in the yaml file we should describe the NPCM PSPI compatible property as follow: compatible: enum: - nuvoton,npcm750-pspi - nuvoton,npcm845-pspi If yes, how should the user know that he needs to use fallback incase is using nuvoton,npcm845-pspi? only from the device tree? > > > Best regards, > Krzysztof Best regards, Tomer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED3DCC00140 for ; Tue, 26 Jul 2022 19:34:00 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LsnCW1Rdyz3c5v for ; Wed, 27 Jul 2022 05:33:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=m3lc4+qI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::12a; helo=mail-lf1-x12a.google.com; envelope-from=tmaimon77@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=m3lc4+qI; dkim-atps=neutral Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LsnBk59b3z3bgR for ; Wed, 27 Jul 2022 05:33:16 +1000 (AEST) Received: by mail-lf1-x12a.google.com with SMTP id w15so16061793lft.11 for ; Tue, 26 Jul 2022 12:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fR1dczgLxpZ02G+EclfekDkoYiKhvbST8mgypurlcnY=; b=m3lc4+qIWX3T6M2+KKp6mZF2S4BCl6PzktWcterEKkqck7dVWQjN49xWIcn8DPTaPM GdbaC1JjvyEiZre6lcBKIOl7BpqUJnYAkluWn/m8I9y6i6+G6pro26Oy5KlLIeUPFcth e5Jth3X/Cpk5T3XXCjeDcMnN88PxQAHDW4UUhjB+E/J3R/kIHFjEc9/1Iy47/rM5NzLT l9Efe5mvMPXfL0cQ9x1ZhWzUqUh1s04FT5iAYcNXxLBemPMamjx2nJ6zKR1flgmdG0FT huG71wIpondJOGxz3jq7PdGAVn0dr1EwxoYx8oCq9d1jRC+8LQzCXeFcZJM9zRUMBTmU LScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fR1dczgLxpZ02G+EclfekDkoYiKhvbST8mgypurlcnY=; b=YrUlOncblNpYA5i0mGb72zl6vUK7m8DturmYEoq3PqNKCB3qL4kZazvterPhvjcxRe uA4pZle9jv/1jScNKR9wjLZ9KTwqXj0R5Vm0nDXDIGKcqs0p7pH3EjDInKLFI9L03hhK 7ooxz0agFeGL9zquws1L1lIyAjS9aU5pvgyVw8bhD8cgDLLnvo/QIQBvUswAuolF3M80 dX6UFATRZR+3YgFt2Iwevij8aj3xibJJ706Pd1SMTE5U+igr4XZBC4Yd51Hfo1/bPhlC A9BnnGqP+LBMutT+7PqNNZhmH4sK3LCHOOp3rdCRzuE7KKSpUITfaMmu26zg5SS280/E wgXg== X-Gm-Message-State: AJIora/hKUzBPhdT6VihWpL4nAgsaqftlJN+AlX57Mmu10YP78IFcfoh 9xtGEmvS6R8hcng/yI+Zgu2c5l4tLyDcBvCsVHs= X-Google-Smtp-Source: AGRyM1sO/5Vm+fBeb2gt2lsBqm4kaXr1AAok8SnmnIdPf3F0WsG3UoMQ+b6lvQ1SzSmAUALwPzOPXIAh4swyRdGzqy4= X-Received: by 2002:a05:6512:693:b0:48a:7c23:1896 with SMTP id t19-20020a056512069300b0048a7c231896mr7355400lfe.111.1658863988371; Tue, 26 Jul 2022 12:33:08 -0700 (PDT) MIME-Version: 1.0 References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> <20869b88-41f3-9e9c-347e-17c3d01baa5d@linaro.org> In-Reply-To: <20869b88-41f3-9e9c-347e-17c3d01baa5d@linaro.org> From: Tomer Maimon Date: Tue, 26 Jul 2022 22:32:56 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Benjamin Fair , Avi Fishman , Patrick Venture , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Tali Perry , Mark Brown , Joel Stanley , Krzysztof Kozlowski , linux-spi@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Krzysztof, Thanks for your explanation. On Tue, 26 Jul 2022 at 12:47, Krzysztof Kozlowski wrote: > > On 24/07/2022 10:44, Tomer Maimon wrote: > > Hi Mark and Krzysztof, > > > > Thanks for your reply, > > > > On Fri, 22 Jul 2022 at 21:57, Mark Brown wrote: > >> > >> On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote: > >>> On 22/07/2022 20:43, Mark Brown wrote: > >> > >>>> ...with a fallback list required by the bindings so the driver actually > >>>> binds. Note that bindings are currently not in YAML format so there'd > >>>> be even less enforcement of that than normal, and as they're currently > >>>> written the bindings don't require fallback. > >> > >>> Yes, the bindings document should be rephrased but we were living like > >>> that for few years. :) > >> > >> The binding document as it stands only has one compatible, there's no > >> existing problem with it other than the YAML conversion. If we're > >> adding something new that requires a fallback we should be explicit > >> about that rather than have something that's actively misleading where > >> previously things were clear. I don't mind if we add the compatible to > >> the driver or document the requirement for the fallback but we should do > >> one of the two. > > > > is V2 good enough? adding the compatible to the driver and the document? > > Or should we use fallback? > > If fallback is choosen, can you explain how I should do it? > > I propose to use fallback. The preferred way is to convert it to DT > schema and then add new device support (so two commits). Other > acceptable way is to rephrase the TXT so it clearly states desired > compatibles - one for old device, two for new devices. There are plenty > of examples in current sources. Appreciate if you could clarify. in case we use DT-schema, we dont describe the fallback like we doing in txt document? I mean that in the yaml file we should describe the NPCM PSPI compatible property as follow: compatible: enum: - nuvoton,npcm750-pspi - nuvoton,npcm845-pspi If yes, how should the user know that he needs to use fallback incase is using nuvoton,npcm845-pspi? only from the device tree? > > > Best regards, > Krzysztof Best regards, Tomer