From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7016CCA48A for ; Sun, 24 Jul 2022 08:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231381AbiGXIop (ORCPT ); Sun, 24 Jul 2022 04:44:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiGXIon (ORCPT ); Sun, 24 Jul 2022 04:44:43 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8086E140D5; Sun, 24 Jul 2022 01:44:42 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id p10so6302220lfd.9; Sun, 24 Jul 2022 01:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lv3zYQALgYY1iSSRJ6c3vQT0Or5W0piyPXsF6s1qXTo=; b=XMKD8Nu+jwF+epSxh759innZceuNK2Bbw9dU7ztnxIx45oOakZqPaox2OvzAs013QZ Nh6gNZg7PGK3ONX/9CrIxeNtTjC66xDS6dT7ETZjZzOaowbI+d/6Y8+44v937IVGkSd+ KMPZybjD5f7ACQR7H+9/BPfgLeKXBvOGUrjrfhPB5NxftKUyig+bivm0nk3z8IUqQKu4 QFELteaFI5z8iPfUqizJi8x/E+Er7goe3ih38q7ECzw/OXJ0DzW3bv5xNsHdlQZ7o+1H ckgRUpJAWzOWvFfHjm0IwTVnJHW51Y4aQKrZdAKWK30cLmo+zgKoKtSlnnXqKZ8WeOZh Uxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lv3zYQALgYY1iSSRJ6c3vQT0Or5W0piyPXsF6s1qXTo=; b=7RstymHkf2GtnfbP1UcHUYZYDAZu7LXUwv4sKOqhanXu6+stqm9i77yYrVWYUbdXIa +XpsNWt2ZB9QELPuVw6EMDEyGs4/6+00llFiqdbJaDdMUj74/pJsIoiHBL3VuE5eTGAc Rk6paBryRA+HhWmwvUSyCOcnJYW9+3N8QDE7UgOgpUMAKkDiIrdzaxn/qPflK4HEcVIg b99N0BQiY/FaLEC93BZQpTD40jZDffv2qk4ZECBLkNLTwhtoWLugEtVLRkBaCPg9fNhT grz0Y4CjrN1B2RFZcTePhsTJpw1vmmlQvdYFNsTUYmWMp1/M3lj50S9i0NWMNfQjfAum UZ2Q== X-Gm-Message-State: AJIora/pq9br31bOOndnqVzNEPwnjhlxu0bOEPDFEkGFBifxOtDb4/LH s2mz2vwsHXdakRRduwn93jmFeL2H4A7LzDZau3EGlrPgzsA= X-Google-Smtp-Source: AGRyM1sMjnyjs4vQ7R5Dp7jQ1b/Q/TvIyjqqZKfRGL4+99ObRiyjPqebsPomLEK3FjhrAd+IKrP3ZH2PFUr+abpBM40= X-Received: by 2002:a19:6d0d:0:b0:48a:8b3c:e28 with SMTP id i13-20020a196d0d000000b0048a8b3c0e28mr304341lfc.265.1658652280751; Sun, 24 Jul 2022 01:44:40 -0700 (PDT) MIME-Version: 1.0 References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> In-Reply-To: From: Tomer Maimon Date: Sun, 24 Jul 2022 11:44:29 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support To: Mark Brown Cc: Krzysztof Kozlowski , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , OpenBMC Maillist , linux-spi@vger.kernel.org, Linux Kernel Mailing List , devicetree Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark and Krzysztof, Thanks for your reply, On Fri, 22 Jul 2022 at 21:57, Mark Brown wrote: > > On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote: > > On 22/07/2022 20:43, Mark Brown wrote: > > > > ...with a fallback list required by the bindings so the driver actually > > > binds. Note that bindings are currently not in YAML format so there'd > > > be even less enforcement of that than normal, and as they're currently > > > written the bindings don't require fallback. > > > Yes, the bindings document should be rephrased but we were living like > > that for few years. :) > > The binding document as it stands only has one compatible, there's no > existing problem with it other than the YAML conversion. If we're > adding something new that requires a fallback we should be explicit > about that rather than have something that's actively misleading where > previously things were clear. I don't mind if we add the compatible to > the driver or document the requirement for the fallback but we should do > one of the two. is V2 good enough? adding the compatible to the driver and the document? Or should we use fallback? If fallback is choosen, can you explain how I should do it? Best regards, Tomer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D4EDC43334 for ; Sun, 24 Jul 2022 08:45:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LrGw54MzKz3c2j for ; Sun, 24 Jul 2022 18:45:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=XMKD8Nu+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::129; helo=mail-lf1-x129.google.com; envelope-from=tmaimon77@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=XMKD8Nu+; dkim-atps=neutral Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LrGvM6qtLz305M for ; Sun, 24 Jul 2022 18:44:47 +1000 (AEST) Received: by mail-lf1-x129.google.com with SMTP id t22so7440972lfg.1 for ; Sun, 24 Jul 2022 01:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lv3zYQALgYY1iSSRJ6c3vQT0Or5W0piyPXsF6s1qXTo=; b=XMKD8Nu+jwF+epSxh759innZceuNK2Bbw9dU7ztnxIx45oOakZqPaox2OvzAs013QZ Nh6gNZg7PGK3ONX/9CrIxeNtTjC66xDS6dT7ETZjZzOaowbI+d/6Y8+44v937IVGkSd+ KMPZybjD5f7ACQR7H+9/BPfgLeKXBvOGUrjrfhPB5NxftKUyig+bivm0nk3z8IUqQKu4 QFELteaFI5z8iPfUqizJi8x/E+Er7goe3ih38q7ECzw/OXJ0DzW3bv5xNsHdlQZ7o+1H ckgRUpJAWzOWvFfHjm0IwTVnJHW51Y4aQKrZdAKWK30cLmo+zgKoKtSlnnXqKZ8WeOZh Uxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lv3zYQALgYY1iSSRJ6c3vQT0Or5W0piyPXsF6s1qXTo=; b=NrkAcAPI/EbPBLKPcnikSo0QyXdWVRZLUFYYdPr6/JZzJt5zRH/gziOgvQ3s13jouT gGISuRa2Hq+VPJ3ESjEP5JhZbkJvFHkOFBxz25KmTQ8fL8fieEnGv1ariAzWgt6OLZz5 GgiPICMGPvSBHn/xqgUFuRWW+Vp47HVf8Apr06bbdVyZFDGUqPj3gEo4xqd1Fl3SLK/Y CobScaj7MO5dkRl0c6tkwiLlLB91HCA0H9KkiNtDGr3u/avE+/qebvHsuOfPMpcI9/KU YlnwfSCMm5AaKthz31lEKjH0a7KSskUULcmJkOPz7aOBrTkz3EzDwZHTMbfuiJZLYr6X GnBA== X-Gm-Message-State: AJIora/sTLN54Q41PEjFuWmFZkTHwx9JXYM4Hlga1MfCkl+4Osxktt1K d+sqlq8wm2w56Oxe+xuQU+MHgWD3WPq/9qjqkbc= X-Google-Smtp-Source: AGRyM1sMjnyjs4vQ7R5Dp7jQ1b/Q/TvIyjqqZKfRGL4+99ObRiyjPqebsPomLEK3FjhrAd+IKrP3ZH2PFUr+abpBM40= X-Received: by 2002:a19:6d0d:0:b0:48a:8b3c:e28 with SMTP id i13-20020a196d0d000000b0048a8b3c0e28mr304341lfc.265.1658652280751; Sun, 24 Jul 2022 01:44:40 -0700 (PDT) MIME-Version: 1.0 References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> In-Reply-To: From: Tomer Maimon Date: Sun, 24 Jul 2022 11:44:29 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support To: Mark Brown Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Benjamin Fair , Avi Fishman , Patrick Venture , OpenBMC Maillist , Linux Kernel Mailing List , Tali Perry , Krzysztof Kozlowski , Rob Herring , Joel Stanley , Krzysztof Kozlowski , linux-spi@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Mark and Krzysztof, Thanks for your reply, On Fri, 22 Jul 2022 at 21:57, Mark Brown wrote: > > On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote: > > On 22/07/2022 20:43, Mark Brown wrote: > > > > ...with a fallback list required by the bindings so the driver actually > > > binds. Note that bindings are currently not in YAML format so there'd > > > be even less enforcement of that than normal, and as they're currently > > > written the bindings don't require fallback. > > > Yes, the bindings document should be rephrased but we were living like > > that for few years. :) > > The binding document as it stands only has one compatible, there's no > existing problem with it other than the YAML conversion. If we're > adding something new that requires a fallback we should be explicit > about that rather than have something that's actively misleading where > previously things were clear. I don't mind if we add the compatible to > the driver or document the requirement for the fallback but we should do > one of the two. is V2 good enough? adding the compatible to the driver and the document? Or should we use fallback? If fallback is choosen, can you explain how I should do it? Best regards, Tomer