On 5 April 2018 at 15:54, Arnd Bergmann <arnd@arndb.de> wrote:

> On Fri, Mar 16, 2018 at 10:51 PM, Tomer Maimon <tmaimon77@gmail.com>
> wrote:
> >
> >
> > On 16 March 2018 at 07:52, Brendan Higgins <brendanhiggins@google.com>
> > wrote:
> >>
> >> On Thu, Mar 15, 2018 at 4:16 PM Tomer Maimon <tmaimon77@gmail.com>
> wrote:
> >>
> >> > Enable L2 Cache in Nuvoton NPCM7xx BMC.
> >>
> >> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> >> > ---
> >> >   arch/arm/mach-npcm/npcm7xx.c | 2 ++
> >> >   1 file changed, 2 insertions(+)
> >>
> >> > diff --git a/arch/arm/mach-npcm/npcm7xx.c
> b/arch/arm/mach-npcm/npcm7xx.c
> >> > index 5f7cd88103ef..c5f77d854c4f 100644
> >> > --- a/arch/arm/mach-npcm/npcm7xx.c
> >> > +++ b/arch/arm/mach-npcm/npcm7xx.c
> >> > @@ -17,4 +17,6 @@ static const char *const npcm7xx_dt_match[] = {
> >> >   DT_MACHINE_START(NPCM7XX_DT, "NPCM7XX Chip family")
> >> >          .atag_offset    = 0x100,
> >> >          .dt_compat      = npcm7xx_dt_match,
> >> > +       .l2c_aux_val    = 0x0,
> >> > +       .l2c_aux_mask   = ~0x0,
> >>
> >> You need to limit this to the specific bit(s) you want to set and verify
> >> that
> >> the l2c driver does not already manage that bit appropriately and that
> it
> >> can
> >> not be specified via the dtsi.
> >
> >
> > Do you mean that I need to specify it the same as been done in V7?
> > because when I run with the above l2c_aux_val and  l2c_aux_mask
> parameters I
> > get the same result.
> >
> > Also if I am not adding the l2c_aux_val and  l2c_aux_mask parameters to
> the
> > DT_MACHINE_START
> > the L2C cache does not initialize.
> >>
> >>
> >> We discussed this a little while ago with Rob here:
> >> https://www.spinics.net/lists/arm-kernel/msg613372.html
> >
> >
> > Sorry in this link I see only Russel king comment regarding the L2C
>
> I'm not sure what the outcome is, and the patch changelog doesn't
> explain what the patch is for, so I've not applied it. If you need the
> patch for correct operation, please resend it with a proper changelog
> comment explaining why it's needed and why you ended up not setting
> any of the bits.
>

Sorry for not explain it better,

It seems that I have to add l2c_aux_val, l2c_aux_mask parameters to the
DT_MACHINE_START
to enable the L2 Cache.

>
> The last email in that thread mentions
> L310_AUX_CTRL_CACHE_REPLACE_RR, is that required after all?
>

No it is not require this is why I added:
.l2c_aux_val    = 0x0,
.l2c_aux_mask   = ~0x0,



>
>      Arnd
>

Can I resend it on Sunday?

Thanks,

Tomer