From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E661C433EF for ; Mon, 23 May 2022 13:14:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 62C7FC34100; Mon, 23 May 2022 13:14:20 +0000 (UTC) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 9B3F8C385A9; Mon, 23 May 2022 13:14:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 9B3F8C385A9 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-f179.google.com with SMTP id o80so25351886ybg.1; Mon, 23 May 2022 06:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uUVMlKQQVBc3oXmHNxKheYpGjkj0/ox35SW9I+79yvQ=; b=Ub5LXaiJszGWuePzI+cnR3TvLWQM246Ri79qUf5wtrkkJ9WycOx+ZKWGGLNKehVRSY 0fDK7RqauANNvfzso7dOOVj59PLBXJbMOXDBYzDtPvRHVfbGwj3CG6YhoxAVHCMerO2u i1QsF338tb9cZztWWXsX3Zab/EoL8IwdjOdvmtg008aR9IwT/vuPF6rUUvVGIIuANrKD K8gluS9yyE6YGBQo7H9Qc5axLgcEwvD3FHJrgX7ISfF8fH+Bw2tZi+29O3kJTNb7bTAC 6mxH2zGdH/fDxL0WXMV20GFdkwZbDuo9md2SJswrsqRYD8ArfQk51N/y5P0NAuIQx7Sl 9Bkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uUVMlKQQVBc3oXmHNxKheYpGjkj0/ox35SW9I+79yvQ=; b=ZvTlK/tZ2bKUN7vsqSZrPk0M2sKTZaOwt12oT+DtLzRj1bKudtOLTfxKlMJPEBmQmr EOQv2PMCJqzhK7qka92SmEnISpoWJ5MPTPpoDVcY8pOyaOfua+VZA0v8Kqxap0tPr+zJ 3fGKrTN3XEjNbEQhVp3F8Lnzych83cCSguCJk+qxDNhdCwIuMUZ5i3HawMqoXCMqau2v VB7iqHBw3bBFQdRzS/euRw8DqXBDUCTrin0QHWtWYKve1HlWJxPCAVPEUqF9Lei6qTen V9+K9tTszgwcoG2Q04rZyu0+WSBhPRaS+uBJFOseXaL5XJo8w81goj/zVegOYEplgoh6 THWQ== X-Gm-Message-State: AOAM533x/surC3g+pXms9t/1bmYkPnjQ67+rpqHGQWqtkRBmvgrOjZoV nC6N3KWLMPAb1sOEAYFYbxo9yZjUUyVr2TvuR7A= X-Google-Smtp-Source: ABdhPJyKyv2YnvW2QOEcod5rPSyzIApwfpZOMURRAXsZHGBTEjXFFK74Y7lU8aWbyrH3yWxQuAoDEyzVNCbZDmK9s6o= X-Received: by 2002:a05:6902:70c:b0:64f:4e29:a858 with SMTP id k12-20020a056902070c00b0064f4e29a858mr18592314ybt.462.1653311658716; Mon, 23 May 2022 06:14:18 -0700 (PDT) MIME-Version: 1.0 References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> <2ccfbfa8-be11-50ed-66ca-3476cbddb320@linaro.org> In-Reply-To: <2ccfbfa8-be11-50ed-66ca-3476cbddb320@linaro.org> From: Tomer Maimon Date: Mon, 23 May 2022 16:14:07 +0300 Message-ID: Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support To: Krzysztof Kozlowski List-Id: Cc: Arnd Bergmann , Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, "nathan=20Neusch=C3=A4fer?=" , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM Content-Type: multipart/alternative; boundary="0000000000001ef18c05dfad9e8f" --0000000000001ef18c05dfad9e8f Content-Type: text/plain; charset="UTF-8" Yes, that's what I mean forgot the 750... Thanks Krzysztof On Mon, 23 May 2022 at 16:06, Krzysztof Kozlowski < krzysztof.kozlowski@linaro.org> wrote: > On 23/05/2022 14:58, Tomer Maimon wrote: > > Hi Arnd, > > > > Thanks for your comment. > > > > On Mon, 23 May 2022 at 14:48, Arnd Bergmann > > wrote: > > > > On Sun, May 22, 2022 at 5:50 PM Tomer Maimon > > wrote: > > > +++ b/drivers/tty/serial/8250/8250_of.c > > > @@ -333,6 +333,7 @@ static const struct of_device_id > > of_platform_serial_table[] = { > > > { .compatible = "ti,da830-uart", .data = (void > > *)PORT_DA830, }, > > > { .compatible = "nuvoton,wpcm450-uart", .data = (void > > *)PORT_NPCM, }, > > > { .compatible = "nuvoton,npcm750-uart", .data = (void > > *)PORT_NPCM, }, > > > + { .compatible = "nuvoton,npcm845-uart", .data = (void > > *)PORT_NPCM, }, > > > { /* end of list */ }, > > > > If these are compatible devices, it's usually easier to claim > > compatibility with both the specific chip and the older model > > as a fallback, to avoid driver changes. This seems to apply to > > the timer and watchdog devices as well. > > > > Just to make sure, Do you mean claim in the device tree? > > like > > > > compatible = "nuvoton,npcm845-timer", "nuvoton,npcm-timer"; > > compatible = "nuvoton,npcm845-timer", "nuvoton,npcm750-timer""; > > > Best regards, > Krzysztof > --0000000000001ef18c05dfad9e8f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes,=C2=A0that's what I mean forgot the 750...
Thanks=C2=A0Krzysztof

On Mon, 23 May 2022 at 16:06, Krzysz= tof Kozlowski <krzyszt= of.kozlowski@linaro.org> wrote:
On 23/05/2022 14:58, Tomer Maimon wrote:
> Hi Arnd,
>
> Thanks for your comment.
>
> On Mon, 23 May 2022 at 14:48, Arnd Bergmann <arnd@arndb.de
> <mailto:arnd@arn= db.de>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@gmail.com<= /a>
>=C2=A0 =C2=A0 =C2=A0<mailto:tmaimon77@gmail.com>> wrote:
>=C2=A0 =C2=A0 =C2=A0> +++ b/drivers/tty/serial/8250/8250_of.c
>=C2=A0 =C2=A0 =C2=A0> @@ -333,6 +333,7 @@ static const struct of_dev= ice_id
>=C2=A0 =C2=A0 =C2=A0of_platform_serial_table[] =3D {
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ .compatible= =3D "ti,da830-uart", .data =3D (void
>=C2=A0 =C2=A0 =C2=A0*)PORT_DA830, },
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ .compatible= =3D "nuvoton,wpcm450-uart", .data =3D (void
>=C2=A0 =C2=A0 =C2=A0*)PORT_NPCM, },
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ .compatible= =3D "nuvoton,npcm750-uart", .data =3D (void
>=C2=A0 =C2=A0 =C2=A0*)PORT_NPCM, },
>=C2=A0 =C2=A0 =C2=A0> +=C2=A0 =C2=A0 =C2=A0 =C2=A0{ .compatible =3D = "nuvoton,npcm845-uart", .data =3D (void
>=C2=A0 =C2=A0 =C2=A0*)PORT_NPCM, },
>=C2=A0 =C2=A0 =C2=A0>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{ /* end of l= ist */ },
>
>=C2=A0 =C2=A0 =C2=A0If these are compatible devices, it's usually e= asier to claim
>=C2=A0 =C2=A0 =C2=A0compatibility with both the specific chip and the o= lder model
>=C2=A0 =C2=A0 =C2=A0as a fallback, to avoid driver changes. This seems = to apply to
>=C2=A0 =C2=A0 =C2=A0the timer and watchdog devices as well.
>
> Just to make sure, Do you mean claim in the device tree?
> like
>
> compatible =3D "nuvoton,npcm845-timer", "nuvoton,npcm-t= imer";

compatible =3D "nuvoton,npcm845-timer", "nuvoton,npcm750-tim= er"";


Best regards,
Krzysztof
--0000000000001ef18c05dfad9e8f--