All of lore.kernel.org
 help / color / mirror / Atom feed
* random buffer_compress_percentage instead of static
@ 2021-06-24 18:38 Sunil Vettukalppurathu
  2021-06-25  0:55 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Sunil Vettukalppurathu @ 2021-06-24 18:38 UTC (permalink / raw)
  To: fio

Hi,

Currently we can’t vary % of compressible data from block to block (as
far as I know). The value provided  for buffer_compress_percentage is
used for all blocks.

"""
buffer_compress_percentage=int
If this is set, then fio will attempt to provide I/O buffer content
(on WRITEs) that compresses to the specified
level. Fio does this by providing a mix of random data followed by
fixed pattern data. """

As we have a requirement to test with random compression %, we
modified the code to accept a range of values for
buffer_compress_percentage instead of one number so that the
percentage changes from block to block – random value between min and
max.

Not sure if  it’s useful for others; if so, will send the patch for review.

Thanks,
--Sunil


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: random buffer_compress_percentage instead of static
  2021-06-24 18:38 random buffer_compress_percentage instead of static Sunil Vettukalppurathu
@ 2021-06-25  0:55 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-06-25  0:55 UTC (permalink / raw)
  To: Sunil Vettukalppurathu, fio

On 6/24/21 12:38 PM, Sunil Vettukalppurathu wrote:
> Hi,
> 
> Currently we can’t vary % of compressible data from block to block (as
> far as I know). The value provided  for buffer_compress_percentage is
> used for all blocks.
> 
> """
> buffer_compress_percentage=int
> If this is set, then fio will attempt to provide I/O buffer content
> (on WRITEs) that compresses to the specified
> level. Fio does this by providing a mix of random data followed by
> fixed pattern data. """
> 
> As we have a requirement to test with random compression %, we
> modified the code to accept a range of values for
> buffer_compress_percentage instead of one number so that the
> percentage changes from block to block – random value between min and
> max.
> 
> Not sure if  it’s useful for others; if so, will send the patch for review.

Please do, sounds like a useful feature. How is it managed in terms of
options?

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-25  0:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 18:38 random buffer_compress_percentage instead of static Sunil Vettukalppurathu
2021-06-25  0:55 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.