On Thu, Jan 7, 2021 at 5:59 PM Quentin Schulz < quentin.schulz@streamunlimited.com> wrote: > Hi Nicolas, > > On Thu, Jan 07, 2021 at 05:52:49PM +0100, Nicolas Dechesne wrote: > > hey! > > > > Robert opened a bug for a broken link in the doc, see > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14168 > > > > This is a valid bug, a regression in > > e1bcfe4d8 dev-manual: remove unused labels > > > > Unfortunately, it opens a can of worms... since it looks like the built > in > > linkcheck did not detect the broken links, and this is not the only > broken > > link. > > > > I ran an online link checker on > > https://docs.yoctoproject.org/dev-manual/common-tasks.html, and it > reported > > the following errors with anchors.. they look like they are regression > with > > the commit above.. > > > > [...] > > It'd be nice to fix the linkcheck indeed. > hmm. could it be that linkcheck only checks for 'external' links? > > I have on my todolist to remove all anchor links to use refs instead but > it's > not fun work to do and it's time consuming. I can now probably "automate" > all of this with some python regexp and manually fix the ones returned > by your online link checker :) (and use the online link checker to > validate the changes). > > I'd then add in the README/CONTRIBUTING that we do not allow such links > and we have to be careful to enforce this when receiving patches. > > All this in the event that we can't find what's wrong with our > linkcheck. > > Cheers, > Quentin >