Re: [PATCH v1] Travis: also test on 32-bit Linux

From: Christian Couder <christian.couder@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Lars Schneider <larsxschneider@gmail.com>,
	git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v1] Travis: also test on 32-bit Linux
Date: Thu, 2 Mar 2017 16:53:28 +0100	[thread overview]
Message-ID: <CAP8UFD0MDVMVOG=bbcEeRbKX+aTNKfLd9yZn5zW7T9KxeRsebQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1703021519330.3767@virtualbox>

On Thu, Mar 2, 2017 at 3:22 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
>> >> +set -e
>> >
>> > Is this really necessary? I really like to avoid `set -e`, in
>> > particular when we do pretty much everything in && chains anyway.
>>
>> Agreed, not really necessary here as we just invoke one command.  Out of
>> curiosity: Why do you try to avoid it? I set it by default in all my
>> scripts.
>
> I try to avoid it because it encourages a style that omits helpful error
> messages.

Yeah, we prefer to define and use a die() function like this:

die () {
    printf >&2 '%s\n' "$*"
    exit 1
}

do_something || die "meaningful error message"