From: Christian Couder <christian.couder@gmail.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Denton Liu <liu.denton@gmail.com>,
Hariom verma <hariom18599@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Jiang Xin <worldhello.net@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [GSoC] Hello Git
Date: Thu, 20 May 2021 10:00:15 +0200 [thread overview]
Message-ID: <CAP8UFD2_PWKzwuYACH2MkjzCqO4VWm1EwReOZjgnsXAgpFcZtA@mail.gmail.com> (raw)
In-Reply-To: <CAOLTT8TRqn5=SqEEnHdFaYi1U5XJXM_MrULfPVzAGPH9AjXk-w@mail.gmail.com>
On Thu, May 20, 2021 at 9:14 AM ZheNing Hu <adlternative@gmail.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> 于2021年5月18日周二 下午10:32写道:
> > > 2. "50cfe1f([GSOC] ref-filter: introduce enum atom_type)" has
> > > been merged into the `next` branch, should we focus on the
> > > performance optimization of `ref-filter.c`? Finally, we can build a
> > > `format_cat_file_item()` similar to `format_ref_array_item()`,
> > > which should not be difficult. And we have to make sure that the
> > > performance of `cat-file --batch` is not lower than before.
> >
> > I wonder if format_ref_array_item() could not just be used by
> > batch_object_write() like Olga did it in:
> >
> > https://github.com/git/git/pull/568/commits/f911b342ae6503dc9f6f8e3c7df316aa45d97bdf
>
> Thanks for the tip! Olga uses `format_cat_file_item()` in
You mean `format_ref_array_item()` not `format_cat_file_item()`, right?
> batch_object_write() , which may be the correct approach.
> Before that, we have to make ref-filter support "%(contents:raw)"
> (similar to Olga's "%(raw)") and "%(rest)".
Yeah, please take a look, if you haven't already, at
https://github.com/git/git/pull/568 where Olga already worked on that.
It would likely help if you can reuse her work.
next prev parent reply other threads:[~2021-05-20 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:40 [GSoC] Hello Git ZheNing Hu
2021-05-18 14:32 ` Christian Couder
2021-05-20 7:14 ` ZheNing Hu
2021-05-20 8:00 ` Christian Couder [this message]
2021-05-20 8:09 ` ZheNing Hu
2021-05-20 14:59 ` Christian Couder
2021-05-19 7:19 ` Jiang Xin
2021-05-20 7:21 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD2_PWKzwuYACH2MkjzCqO4VWm1EwReOZjgnsXAgpFcZtA@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.