Re: [RFC Patch v3 16/22] blktap2: move ramdisk related codes to block-replication.c

From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	xen devel <xen-devel@lists.xen.org>,
	Yang Hongyang <yanghy@cn.fujitsu.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC Patch v3 16/22] blktap2: move ramdisk related codes to block-replication.c
Date: Wed, 24 Sep 2014 11:44:33 -0700	[thread overview]
Message-ID: <CAP8mzPOSkkzpYNWUJPb=0ATbC6BBgDb2s_8E24bg4O9GiuGopA@mail.gmail.com> (raw)
In-Reply-To: <1409909158-19243-17-git-send-email-wency@cn.fujitsu.com>

[-- Attachment #1.1: Type: text/plain, Size: 1454 bytes --]

On Sep 5, 2014 5:32 AM, "Wen Congyang" <wency@cn.fujitsu.com> wrote:
>
>  COLO will reuse them
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>
> ---
>  tools/blktap2/drivers/block-remus.c       | 485
++----------------------------
>  tools/blktap2/drivers/block-replication.c | 452
++++++++++++++++++++++++++++
>  tools/blktap2/drivers/block-replication.h |  48 +++
>  3 files changed, 523 insertions(+), 462 deletions(-)
>
> diff --git a/tools/blktap2/drivers/block-remus.c
b/tools/blktap2/drivers/block-remus.c
> index 8b6f157..2713af1 100644
> --- a/tools/blktap2/drivers/block-remus.c
> +++ b/tools/blktap2/drivers/block-remus.c
...snip..
>
>  static int backup_start(td_driver_t *driver)
> @@ -1120,7 +686,9 @@ static void server_do_wreq(td_driver_t *driver)
>         if (mread(s->stream_fd.fd, buf, len) < 0)
>                 goto err;
>
> -       if (ramdisk_write(&s->ramdisk, *sector, *sectors, buf) < 0) {
> +       if (ramdisk_write_to_hashtable(s->h, *sector, *sectors,

Please rename to something else.
Eg, ramdisk flush to disk?

I am fine with the rest of the patch. Have you tested this setup with Remus
(not Colo) and ensured that you haven't reintroduced the write after write
issue, that was fixed a couple of years ago? Although I don't know how you
would test with 4.5 code base.

Acked-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
(subject to addressing the renaming comment)

[-- Attachment #1.2: Type: text/html, Size: 1979 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel