From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3466C433F5 for ; Wed, 3 Nov 2021 11:47:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E802960462 for ; Wed, 3 Nov 2021 11:47:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E802960462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D03E835A8; Wed, 3 Nov 2021 12:47:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IrQjavKp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5E63E83538; Wed, 3 Nov 2021 12:47:23 +0100 (CET) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 63DA6835A8 for ; Wed, 3 Nov 2021 12:47:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=padmarao.b@gmail.com Received: by mail-ua1-x929.google.com with SMTP id az37so3691137uab.13 for ; Wed, 03 Nov 2021 04:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kI1CHjAx8pmeYmCrs50sbOcPccqTnK/X1Gj3ANU0ZtI=; b=IrQjavKpJDaUs/CufO6tZrYjA45WNhiHJt2IOuyWZGjo4GxICiNXPOa6x/CREhdZv1 IyokOSeww9HHG5PRqGysoDiMGWIzSy7+DdU1QQ7dr790gGTBEzwX+jMPNpcntChmjE5n Vw4CWNqpI8Gvrbo36bb8yK7y86c4J7hNV9XUysdF+Zoo2au0c7LfGkQx05t+berwtu1T xKudLRA9WHaACpf0Z0MsAcsByYjQuqI9H0Wg094ZwMakRWzXxh2IXg+XIC0E1kkXIqQV Wnkyq7VCXIWxqEDxWPKVHIZJoFluVGKxpIrspDg3MFq9bWrlywbVvKoNpXSkk4yyg22e hh7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kI1CHjAx8pmeYmCrs50sbOcPccqTnK/X1Gj3ANU0ZtI=; b=3JxvSB9KwiStxVp+lev/6RlKM+qMalVJ3acFdlqK/YQfZcuwvhMJCIcN/Jlc00rFMA MC9coJXoJm9ycWPxWvchu6xR3GM8FX/Li9wnZIoktc13+GPKBIkyVY7ujeKLiR5grBQc NSi78t8LXl5gYJrG88ujT0+U/uVweCJPx7GDRVzByP7iWPLX/WCXRE6WI+AO8BBU7kVV OoJrhxtyNxsgLSdaAVW1EuakTx8/2QiDawwVlRKGQr6V8Yck1vUywhN97u9quZYBBFTJ CO1rsC2Xr1DiYuTAyuk6sVaSK1SMpOAfmlJFy74V/4j0hdI327W8p9P2bsWJONWNRuKf bklg== X-Gm-Message-State: AOAM532vSMvhB4JJUdMsKycwZN+s2yHJigSyAkMOdUprGgSWO28CVTIx fEZAKLs/imUwSLZddHmsORUXTp9o7RVo+G28HhU= X-Google-Smtp-Source: ABdhPJztrqA+MKnK07XD587d+n8PLFnldNai6tAlajmFRNnm+qlimRcYdpUFdW+0/VtwayOZkezy/tp3Myg7zuNks3c= X-Received: by 2002:a05:6102:e07:: with SMTP id o7mr17456887vst.46.1635940038217; Wed, 03 Nov 2021 04:47:18 -0700 (PDT) MIME-Version: 1.0 References: <20211022085648.134655-1-padmarao.begari@microchip.com> <20211022085648.134655-5-padmarao.begari@microchip.com> In-Reply-To: From: Padmarao Begari Date: Wed, 3 Nov 2021 17:17:06 +0530 Message-ID: Subject: Re: [PATCH v1 4/5] net: macb: Compatible as per device tree To: Bin Meng Cc: Padmarao Begari , U-Boot Mailing List , Rick Chen , Anup Patel , Atish Patra , Heiko Schocher , cyril.jean@microchip.com, Lewis Hanly , Conor Dooley , Daire McNamara , ivan.griffin@microchip.com, valentina.fernandezalanis@microchip.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Bin, On Tue, Nov 2, 2021 at 6:16 PM Bin Meng wrote: > Hi Padmarao, > > On Tue, Nov 2, 2021 at 7:03 PM Padmarao Begari > wrote: > > > > Hi Bin, > > > > On Mon, Nov 1, 2021 at 2:15 PM Bin Meng wrote: > >> > >> On Fri, Oct 22, 2021 at 4:58 PM Padmarao Begari > >> wrote: > >> > > >> > Update compatible as per Microchip PolarFire SoC ethernet > >> > device node. > >> > > >> > Signed-off-by: Padmarao Begari > >> > --- > >> > drivers/net/macb.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > >> > index 8c6461e717..1b867bd5c2 100644 > >> > --- a/drivers/net/macb.c > >> > +++ b/drivers/net/macb.c > >> > @@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] = > { > >> > { .compatible = "cdns,zynq-gem" }, > >> > { .compatible = "sifive,fu540-c000-gem", > >> > .data = (ulong)&sifive_config }, > >> > - { .compatible = "microchip,mpfs-mss-gem", > >> > + { .compatible = "microchip,mpfs-gem", > >> > >> Could you please provide the upstream Linux kernel binding reference? > >> I can't find such string in the Linux kernel. > >> > > > > We are not upstreamed Linux bindings yet, soon we will do. > > > > The compatible "cdns,macb" is used in Linux for 32-bit and 64-bit DMA > transfer and U-Boot for 32-bit DMA transfer. > > We added this string to support 64-bit DMA transfer of the GEM. > > > > I suggest we upstream the new compatible string binding first, then > update U-Boot. Otherwise U-Boot might be updated again if the > compatible string is changed during the upstream review process. > > We are going to use the same compatible strings in the U-Boot and Linux for PolarFire SoC peripherals like "microchip,mpfs-xxx" (xxx means peripheral name, ex. "microchip,mpfs-i2c", "microchip,mpfs-rtc"....etc). Here, we are updating compatible(existing) "microchip,mpfs-mss-gem" with "microchip,mpfs-gem". Regards, > Bin >