From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51966C433EF for ; Fri, 12 Nov 2021 09:36:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD5DA60EE5 for ; Fri, 12 Nov 2021 09:36:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BD5DA60EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F374F82F6C; Fri, 12 Nov 2021 10:36:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CO3NSWDl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE7F582F75; Fri, 12 Nov 2021 10:36:38 +0100 (CET) Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 876AA82F79 for ; Fri, 12 Nov 2021 10:36:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=padmarao.b@gmail.com Received: by mail-ua1-x92c.google.com with SMTP id p37so15888139uae.8 for ; Fri, 12 Nov 2021 01:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ax8+0wuCxRsldm6AXAu5eA+xr+cjXubJQg24nDb0JLc=; b=CO3NSWDlmN5qBdIL7wqy9wEWl7lkf7cAn5o2akTari2fRuNAnO4WJdUDE2rDpofuwC RdZItjKyL8VUJa58kzZciqkYXqc4gTCyxnlw+/VskKDeiPbIewzqGXzNWz+440H1tpf3 1PRXMa5scpegzR0OPC3f6e3heC/efYUwNTpOnU5ZMF4sBQJ1lWAYAYbBDFBagYnB7peJ IHuW2VUB/EWo16pKSvWTsc5BMxUjgh9GDWhTb06X6JtB2FDwgjEAtpC/1W8gBk/cQxuH AYuLcMahJ2XwHKIqmDXTwZ0LsuP048aYSR/u4U7YOb5wj+0cejjRjVGSbwNbpu87atD4 KAFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ax8+0wuCxRsldm6AXAu5eA+xr+cjXubJQg24nDb0JLc=; b=xaN51ljggEpWJceQMAV/rQiu4jWFiLFOXzNNlHoE7xr30PWGxu+xnbloVftymWyWep Z1Nrs1oqjhRC62DtChMT2a7PQwaipJMGm9NmaRQjRRhTh8XlZ+KqkO2eKlZYFPX0UOEw 85ACvGJQDaJRHun28SLvy7WzELSfDEKIyVe1yvWjxKq23iiiIsRs7REyYGSXsJWnuil4 /9xGIF0nmihTtzH2IvJeY/m9d63xCiGbTis9mj0V5TncvS/6ffAD45kxHFWg3wfShAxP 9eVsq974OMIMybyxtbBlBjMRijy9mSOMJowkayxb6pUzsaaOtF0vSaXFjLI0FdOT74Ct hjrQ== X-Gm-Message-State: AOAM532LoHQk80Xq4qRcdgkaqOdJ0D94hh1m7e0wxY/9Q3mbMrJtMeTi x84UqCOic2b/w08wtB+Hx45Dwac/xJwX5B316Zo= X-Google-Smtp-Source: ABdhPJy7Lne3icNKgZobKrwobIr9KrZQgFM+ZkMKpumt4Ac8eJDukGMyoo+B6zdet7ze8Y1+kBv+l3PMTLdRUlIKXYQ= X-Received: by 2002:a67:ec8f:: with SMTP id h15mr8131071vsp.53.1636709793109; Fri, 12 Nov 2021 01:36:33 -0800 (PST) MIME-Version: 1.0 References: <20211111125441.3344243-1-michael@walle.cc> In-Reply-To: From: Padmarao Begari Date: Fri, 12 Nov 2021 15:06:22 +0530 Message-ID: Subject: Re: [PATCH v1 4/5] net: macb: Compatible as per device tree To: Bin Meng Cc: Ivan.Griffin@microchip.com, Michael Walle , Anup Patel , Atish Patra , Conor Dooley , Cyril.Jean@microchip.com, Daire McNamara , Heiko Schocher , Lewis Hanly , Padmarao Begari , Rick Chen , U-Boot Mailing List , Valentina.FernandezAlanis@microchip.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.35 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Bin, On Fri, Nov 12, 2021 at 6:58 AM Bin Meng wrote: > On Thu, Nov 11, 2021 at 9:17 PM wrote: > > > > > I agree with Bin here. You shouldn't introduce a new compatible just > for > > > u-boot. If you need one, please to it first in linux and get an ACK > there. > > > Or at least there should be patches for it pending in linux and it > should > > > be likely, that they will be accepted. > > > > > > Please work towards having one binding for u-boot and linux. > > > > > > -michael > > > > I think both Michael and Bin are right, but that maybe this has gone > circular. > > > > IIRC, Linux *doesn't need* any extra bindings because its driver already > > supports 64-bit DMA. > > > > Padmarao's original patch added equivalent 64-bit functionality to the > > driver in U-Boot, but this was rejected. > > > > I am not sure why it was rejected. Is that because it breaks some > other platforms? > > No > > Instead I think the suggestion was to add a device-tree binding to > choose 32 or > > 64-bit DMA... however, there is no reasonably way of upstreaming this > into > > the Linux device-tree, as Linux doesn't need it... so he is left in a > Catch-22. > > > > A way forward may be to go back to his original approach and get the > U-Boot > > driver functionality updated so that it works similarly to the Linux > driver > > (and thus can use the same device-tree stanza)? > > Let's go back to the original approach and see what happens. > > Ok, I will do that and submit it in Patch v2. Regards Padmarao > Regards, > Bin >