Re: [PATCH v2 0/8] go1.10 update and misc improvements

From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 0/8] go1.10 update and misc improvements
Date: Wed, 28 Feb 2018 08:42:48 -0300	[thread overview]
Message-ID: <CAP9ODKox=QJKUuuvSGb7dRebKG17oFCUVOdQVNQ1vOfm5KxiZQ@mail.gmail.com> (raw)
In-Reply-To: <1519817857.3436.4.camel@linuxfoundation.org>

On Wed, Feb 28, 2018 at 8:37 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2018-02-28 at 10:47 +0000, Richard Purdie wrote:
>> On Tue, 2018-02-27 at 14:16 -0300, Otavio Salvador wrote:
>> >
>> > On Tue, Feb 27, 2018 at 9:36 AM, Matt Madison <matt@madison.systems
>> > >
>> > wrote:
>> > >
>> > >
>> > > New in v2:
>> > >     * Fixed Upstream-Status line in go patches
>> > >     * Added GOTMPDIR to do_configure[dirs]
>> > >
>> > > Updates to the go recipes and bbclasses for go1.10, which
>> > > moves the bulk of the toolchain bootstrap and build out
>> > > of the 'make.bash' script and to the 'dist' tool.  This
>> > > required a rework of the patches.
>> > >
>> > > go1.10 introduces significant changes to the go build
>> > > tool as well, requiring some further patches to make
>> > > it work for OE builds.
>> > >
>> > > See https://golang.org/doc/go1.10 for a complete list
>> > > of new features and changes.
>> > >
>> > > Following the update are some cleanup/improvement
>> > > patches.
>> > I tested those patches and they are working fine. I pinged Matt
>> > specifically about one patch that seems that could be simplified.
>> > So
>> > please wait until we get back on this before merging it.
>> >
>> > If possible to put this on MUT so we see if any issue is raised up,
>> > it'd be good as well :-)
>> I tested it in -next, one issue:
>>
>> FAIL: test_go_dep_build (gotoolchain.oeGoToolchainSelfTest)
>>
>> from https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds
>> /8
>> 57/steps/Running%20oe-selftest/logs/stdio
>>
>> (can reproduce with oe-selftest -r
>> gotoolchain.oeGoToolchainSelfTest.test_go_dep_build)
>
> Also: https://autobuilder.yocto.io/builders/nightly-world-lsb/builds/791/steps/BuildImages/logs/stdio
>
>
> Summary: 6 tasks failed:
>   virtual:multilib:lib32:/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-extended/go-examples/go-helloworld_0.1.bb:do_compile
>   virtual:multilib:lib32:/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-devtools/glide/glide_0.13.1.bb:do_compile
>   virtual:multilib:lib32:/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-devtools/go/go-dep_0.4.1.bb:do_compile
>   /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-extended/go-examples/go-helloworld_0.1.bb:do_compile
>   /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-devtools/glide/glide_0.13.1.bb:do_compile
>   /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-world-lsb/build/meta/recipes-devtools/go/go-dep_0.4.1.bb:do_compile

Just to confirm, was it using v2? I had problems with v1.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750