From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: "Maxime Roussin-Bélanger" <maxime.roussinbelanger@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cmake: Use find_program if find_host_program is not available
Date: Mon, 26 Jun 2017 16:41:34 -0300 [thread overview]
Message-ID: <CAP9ODKp+-fKQSM97AcqDe5Tm9r256LFg_fgDdiuzCFnk5TB_Xw@mail.gmail.com> (raw)
In-Reply-To: <1498502034-13181-1-git-send-email-maxime.roussinbelanger@gmail.com>
On Mon, Jun 26, 2017 at 3:33 PM, Maxime Roussin-Bélanger
<maxime.roussinbelanger@gmail.com> wrote:
> CMake does not define the `find_host_program` command we've
> been using in the cross-compiling code path. It was
> provided by a widely used Android toolchain file. For
> compatibility, continue to use `find_host_program` if
> available, but otherwise use just `find_program`.
>
> Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger@gmail.com>
It sounds fine to me; the backward compatibility is maintained and it
fixes a real use-case so I see no reason to not apply EXCEPT:
- lack of Upstream-Status field
- lack of upstream bug about the issue, ideally the proposed patch
should be send to upstream so we can drop it in next releases
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2017-06-26 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 18:33 [PATCH] cmake: Use find_program if find_host_program is not available Maxime Roussin-Bélanger
2017-06-26 19:01 ` ✗ patchtest: failure for " Patchwork
2017-06-26 19:41 ` Otavio Salvador [this message]
2017-06-26 21:51 ` [PATCH] " Maxime Roussin-Belanger
2017-06-27 7:57 ` Jussi Kukkonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9ODKp+-fKQSM97AcqDe5Tm9r256LFg_fgDdiuzCFnk5TB_Xw@mail.gmail.com \
--to=otavio.salvador@ossystems.com.br \
--cc=maxime.roussinbelanger@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.