From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 0CA58E00954; Wed, 22 Apr 2015 05:37:58 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.170 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 96A2BE00932 for ; Wed, 22 Apr 2015 05:37:55 -0700 (PDT) Received: by igbpi8 with SMTP id pi8so103464124igb.0 for ; Wed, 22 Apr 2015 05:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=rxqYS3GaxO4rsD+MNa91cJGVWb7E3LBa89Bic+4eF9Y=; b=tyfNq0B0+eHfCYnXcvY7IPZCT3OtS50ygHSfJ9qC2FMdmv5yatokMFZwH5PF7hpax0 oQnFhO/NmUizxV5imPxYegTmhc8y3azjs8b30eMbSaXKh86hHAhiuCkmAeZFb+YY5Wnx raa3DdAPaaAfY3JAfiWdZATwtqVbciDfGUgqkehrUBwhTr8uw7spy4roM6VXKJbvyfeB U/OcMn5PuzLG7WiloZEq0voR62ybKUUfuDbzuyYckOJ8yUFR8goclhSwM46QRhQxKz9a PA5K1opfvyIzageWR2RM05hNZhjfCqCambS8zXfHKCLCsKiE0VRVttwQnbrHn+ijoIJy QGxg== MIME-Version: 1.0 X-Received: by 10.50.66.37 with SMTP id c5mr4133057igt.26.1429706274627; Wed, 22 Apr 2015 05:37:54 -0700 (PDT) Sender: otavio.salvador@gmail.com Received: by 10.107.23.197 with HTTP; Wed, 22 Apr 2015 05:37:54 -0700 (PDT) In-Reply-To: <1429574624-29176-1-git-send-email-psidhu@gateworks.com> References: <1429574624-29176-1-git-send-email-psidhu@gateworks.com> Date: Wed, 22 Apr 2015 09:37:54 -0300 X-Google-Sender-Auth: h-nkPQURfbIEqWKBEsqy8ALvVw4 Message-ID: From: Otavio Salvador To: Pushpal Sidhu Cc: "meta-freescale@yoctoproject.org" Subject: Re: [PATCH v2 0/3] Patch series to add Gateworks Ventana SBCs X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2015 12:37:58 -0000 Content-Type: text/plain; charset=UTF-8 Hello Pushpal, On Mon, Apr 20, 2015 at 9:03 PM, Pushpal Sidhu wrote: > The following is my v2 patch series for adding support for Gateworks Ventana SBCs. The main changes are as follows: > * Drop PR in all files > * Slightly alter wording of commit messages > * Add kernel defconfig > * Move machine conf to patch 3/3 > * Remove do_install in machine conf - keep u-boot-script-gateworks installable via adding it through IMAGE_INSTALL Thanks for reworking the patchset. I think we are very close to be able to merge it. I saw two things: You named some recipes *-gwventana. I would expect them to be -gateworks as if other boards are later added they can share same recipe and avoid future renames. The second thing is the defconfig, of kernel. You need to use 'savedefconfig' to generate the trimmed version. This is way nicer for updates as it shows the differences clearly (and also aligns with Kernel upstream style). -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750