All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: Marek Vasut <marex@denx.de>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] u-boot: Factor out common bits
Date: Mon, 5 Sep 2016 10:51:05 -0300	[thread overview]
Message-ID: <CAP9ODKqO1ffXbra1QU0F6CwyXWW2sU5A9UoSuXeNtyMu=DbHAg@mail.gmail.com> (raw)
In-Reply-To: <1fbc36ad-f031-9f85-7861-1ba302273ace@denx.de>

On Mon, Sep 5, 2016 at 8:04 AM, Marek Vasut <marex@denx.de> wrote:
> On 09/05/2016 01:02 PM, Richard Purdie wrote:
>> On Mon, 2016-09-05 at 00:33 +0200, Marek Vasut wrote:
>>> On 09/05/2016 12:23 AM, Marek Vasut wrote:
>>>> On 09/05/2016 12:11 AM, Richard Purdie wrote:
>>>>> On Sun, 2016-09-04 at 23:49 +0200, Marek Vasut wrote:
>>>>>> On 09/04/2016 11:28 PM, Richard Purdie wrote:
>>>>>>> On Sun, 2016-09-04 at 18:21 +0200, Marek Vasut wrote:
>>>>>> Yes, except when new version of U-Boot comes out and we want to
>>>>>> perform
>>>>>> update of the u-boot{,mkimage,fw-utils} recipes, with this
>>>>>> current
>>>>>> patch
>>>>>> as is, we'd only have to rename these recipes and change the
>>>>>> version
>>>>>> in
>>>>>> u-boot-common.inc . With your proposal, we'd have to not only
>>>>>> rename
>>>>>> the
>>>>>> recipes and tweak u-boot-common.inc, but also edit their
>>>>>> content and
>>>>>> change the "require u-boot-common_20yy.mm.inc" bit, which adds
>>>>>> some
>>>>>> toil.
>>>>> Unless its:
>>>>>
>>>>> require u-boot-common_${PV}.inc
>>>>>
>>>>> since it should be able to extract PV from the filename...
>>>> Ah right, thanks :)
>>>>
>>>> I'll rebuild/retest and send a V2 .
>>>>
>>> I was a bit hasty, the u-boot.inc includes u-boot-common.inc without
>>> having PV set. Any idea how to deal with that ?
>>
>> Just put includes in the versioned files rather than from u-boot.inc?
>
> Wouldn't that break some BSPs ? I factored out code from the u-boot.inc
> afterall.

It will but I consider this fine for master as this clean up the
recipes and ensures people goes on the review process while upgrading
it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


  reply	other threads:[~2016-09-05 13:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04 16:21 [PATCH 1/2] u-boot: Factor out common bits Marek Vasut
2016-09-04 16:21 ` [PATCH 2/2] u-boot: Update to 2016.07 release Marek Vasut
2016-09-14  8:48   ` Alexander Kanavin
2016-09-04 21:28 ` [PATCH 1/2] u-boot: Factor out common bits Richard Purdie
2016-09-04 21:49   ` Marek Vasut
2016-09-04 22:11     ` Richard Purdie
2016-09-04 22:23       ` Marek Vasut
2016-09-04 22:33         ` Marek Vasut
2016-09-05 11:02           ` Richard Purdie
2016-09-05 11:04             ` Marek Vasut
2016-09-05 13:51               ` Otavio Salvador [this message]
2016-09-05 16:16                 ` Marek Vasut
2016-09-05 16:22                   ` Otavio Salvador
2016-09-05 16:24                     ` Marek Vasut
2016-09-05 16:26                       ` Otavio Salvador
2016-09-05 19:33                         ` Richard Purdie
2016-09-05 19:47                           ` Marek Vasut
2016-09-05 19:52                             ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP9ODKqO1ffXbra1QU0F6CwyXWW2sU5A9UoSuXeNtyMu=DbHAg@mail.gmail.com' \
    --to=otavio.salvador@ossystems.com.br \
    --cc=marex@denx.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.