Re: [meta-fsl-arm PATCH 15/16] mfgtool-initramfs-image.bbclass: Abstracts the MfgTool's initramfs needs

[Otavio Salvador <otavio@ossystems.com.br>]

Hello,

Pressed sent too soon hehe

On Wed, Feb 26, 2014 at 9:58 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello Daiane,
>
> On Tue, Feb 25, 2014 at 3:13 PM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> On Mon, Feb 24, 2014 at 3:52 PM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> Manage the initramfs requirements for Manufacturing Tool use and allow
>>> future addition of new filesystem support if needed.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>>
>>>  classes/mfgtool-initramfs-image.bbclass | 26 ++++++++++++++++++++++++++
>>>  1 file changed, 26 insertions(+)
>>>  create mode 100644 classes/mfgtool-initramfs-image.bbclass
>>>
>>> diff --git a/classes/mfgtool-initramfs-image.bbclass b/classes/mfgtool-initramfs-image.bbclass
>>> new file mode 100644
>>> index 0000000..3c2e445
>>> --- /dev/null
>>> +++ b/classes/mfgtool-initramfs-image.bbclass
>>> @@ -0,0 +1,26 @@
>>
>> Would be possible to add a DESCRIPTION in a class? In case it´s not
>> possible, would be nice to add a comment only to inform the goal of
>> this class?
>
> I added a comment block in the class.
>
>>> +DEPENDS += "u-boot-mfgtool linux-mfgtool"
>>> +
>>> +PACKAGE_GROUP_mtd = "packagegroup-fsl-mfgtool-mtd"
>>> +PACKAGE_GROUP_extfs = "packagegroup-fsl-mfgtool-extfs"
>>> +
>>> +IMAGE_FSTYPES = "cpio.gz.u-boot"
>>
>> Do you intent to not allow IMAGE_FSTYPES to be overridden?
>
> Yes; it is possible to override it in the image file, if nee

Yes; it is possible to override it in the image file, if need. For the
goal of the class, the cpio.gz is enough and being a specific propose
image I think it is fine.

>>> +IMAGE_ROOTFS_SIZE ?= "8192"
>>> +IMAGE_CLASSES = "image_types_uboot"
>>> +
>>> +IMAGE_FEATURES = " \
>>
>> When you say future addition of new file system support you mean a
>> patch to add it on recipe or you mean it being overridden by
>> local.conf?

We may add fsfs, btrfs or other; the idea is we may not enable it by
default in the image features but allow it to be upstreamed ;-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750