All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio@ossystems.com.br>
To: Chunrong Guo <B40290@freescale.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3] u-boot.inc: fix rename image error
Date: Mon, 9 Mar 2015 13:29:30 -0300	[thread overview]
Message-ID: <CAP9ODKqS5rABZZsAue19k3pO-SfHXWRSEwcPt6s+zWDMWF_v6w@mail.gmail.com> (raw)
In-Reply-To: <1425885894-9030-1-git-send-email-B40290@freescale.com>

On Mon, Mar 9, 2015 at 4:24 AM, Chunrong Guo <B40290@freescale.com> wrote:
>   Resolve mismatch between U-Boot configs and uboot image name.
>   The ${S}/${config}/u-boot-${type}.${UBOOT_SUFFIX} may alway be false
>   and repeat compile or install so we need to check if ${type} match ${config} .
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>

I think we have a serious issue here:

+ echo mx6qsabresd_config
+ cut -d_ -f2
+ [ config = sd ]
+ echo mx6qsabresd_sata_config
+ cut -d_ -f2
+ [ sata = sd ]
+ echo mx6qsabresd_config
+ cut -d_ -f2
+ [ config = sata ]
+ echo mx6qsabresd_sata_config
+ cut -d_ -f2
+ [ sata = sata ]
+ oe_runmake O=mx6qsabresd_sata_config mx6qsabresd_sata_config
+ oe_runmake_call O=mx6qsabresd_sata_config mx6qsabresd_sata_config

This is wrong. It shouldn't expect a pattern in the UBOOT_MACHINE
value. Instead it should match the UBOOT_CONFIG for it and done.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


      reply	other threads:[~2015-03-09 16:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  7:24 [PATCH v3] u-boot.inc: fix rename image error Chunrong Guo
2015-03-09 16:29 ` Otavio Salvador [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP9ODKqS5rABZZsAue19k3pO-SfHXWRSEwcPt6s+zWDMWF_v6w@mail.gmail.com \
    --to=otavio@ossystems.com.br \
    --cc=B40290@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.