From: Otavio Salvador <otavio.salvador@ossystems.com.br>
To: Tom Hochstein <tom.hochstein@nxp.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Prabhu Sundararaj <prabhu.sundararaj@nxp.com>,
meta-freescale Mailing List <meta-freescale@yoctoproject.org>,
White Weng <white.weng@nxp.com>
Subject: Re: [meta-fsl-arm PATCH v2 00/16] Machine overrides extender - reduce code duplication
Date: Tue, 6 Sep 2016 09:39:38 -0300 [thread overview]
Message-ID: <CAP9ODKquJJ30ABqWXn4OQ3p5z7rNaOYvsE1g-vkQ2DhFyvUStA@mail.gmail.com> (raw)
In-Reply-To: <AMSPR04MB309457E4C3EF13B24AC2B45E2F90@AMSPR04MB309.eurprd04.prod.outlook.com>
On Mon, Sep 5, 2016 at 10:13 PM, Tom Hochstein <tom.hochstein@nxp.com> wrote:
>> From: Otavio Salvador [mailto:otavio.salvador@ossystems.com.br]
>> Sent: Monday, September 05, 2016 12:18 PM
>
>> I know how this works BUT people assumes machine features are to be
>> enabled/disabled on machine basis, that is the main reason I did not
>> use it.
>
> Okay, so assume we chose to implement using machine features, and a user has disabled a machine feature using MACHINE_FEATURES_remove. I guess he will have no problem (other than his faulty understanding) since the feature will be disabled as he wants. Is there some other problem?
>
>> The way I designed it, the extender is applied on the BSP level so it
>> provides the lift of features the SoC supports. If you want to change
>> something in a recipe or so, it will be applied globally and then
>> making it harder for people to make a frankenstein.
>
> Okay, but an implementation using MACHINE_FEATURES would not be any different. Each machine configuration file would include a new SOC configuration file, like this one for 6 Quad:
>
> GPU_FEATURES = "imxipu imxvpu imxgpu2d imxgpu3d"
> MACHINE_FEATURES += "${GPU_FEATURES}"
> DISTRO_FEATURES_DEFAULT += "${GPU_FEATURES}"
Adding DISTRO things in a machine file is a clear indication something
is wrong. Anything related to distro features cannot be change in
machine level or it makes it incompatible across different machines.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2016-09-06 12:39 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 22:20 [meta-fsl-arm PATCH v2 00/16] Machine overrides extender - reduce code duplication Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 01/16] Convert SOC_FAMILY to MACHINEOVERRIDES Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 02/16] imx-lib: Stop using generic SoC overrides Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 03/16] imx-test: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 04/16] machine-overrides-extender.bbclass: Automatically set extend the MACHINEOVERRIDES Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 05/16] imx-base.inc: Enable machine overrides extender for i.MX6 Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 06/16] chromium: Refactor code to use the the new overrides Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 07/16] glmark2: Refactor code to use " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 08/16] qtbase: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 09/16] cairo: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 10/16] eglinfo: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 11/16] imx-gpu-viv: " Otavio Salvador
2016-09-06 14:23 ` Tom Hochstein
2016-09-06 14:54 ` Otavio Salvador
2016-09-06 15:04 ` Tom Hochstein
2016-09-06 16:14 ` Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 12/16] mesa-gl: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 13/16] weston: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 14/16] gstreamer1.0-plugins-imx: " Otavio Salvador
2016-09-06 14:25 ` Tom Hochstein
2016-09-06 14:42 ` Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 15/16] imx-codec: " Otavio Salvador
2016-09-01 22:20 ` [meta-fsl-arm PATCH v2 16/16] gstreamer1.0-plugins-imx: Change EGL platform preference order Otavio Salvador
2016-09-02 3:42 ` [meta-fsl-arm PATCH v2 00/16] Machine overrides extender - reduce code duplication Tom Hochstein
2016-09-02 10:13 ` Otavio Salvador
2016-09-02 14:46 ` Tom Hochstein
2016-09-02 18:55 ` Otavio Salvador
2016-09-02 19:56 ` Tom Hochstein
2016-09-02 20:11 ` Otavio Salvador
2016-09-02 22:29 ` Tom Hochstein
2016-09-03 20:23 ` Otavio Salvador
2016-09-04 17:15 ` Tom Hochstein
2016-09-05 12:55 ` Otavio Salvador
2016-09-05 16:37 ` Tom Hochstein
2016-09-05 17:18 ` Otavio Salvador
2016-09-06 1:13 ` Tom Hochstein
2016-09-06 12:39 ` Otavio Salvador [this message]
2016-09-06 13:25 ` Tom Hochstein
2016-09-06 13:45 ` Otavio Salvador
2016-09-06 14:54 ` Tom Hochstein
2016-09-06 16:11 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9ODKquJJ30ABqWXn4OQ3p5z7rNaOYvsE1g-vkQ2DhFyvUStA@mail.gmail.com \
--to=otavio.salvador@ossystems.com.br \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio@ossystems.com.br \
--cc=prabhu.sundararaj@nxp.com \
--cc=tom.hochstein@nxp.com \
--cc=white.weng@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.