From: Otavio Salvador <otavio@ossystems.com.br>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] initrdscripts: fix init-live.sh for hddimg and livecd
Date: Wed, 24 Aug 2011 12:43:41 -0300 [thread overview]
Message-ID: <CAP9ODKqzVp3RqbU6_8L5qE3nCK+VcqRaQYp=vJazfL4qT-My=A@mail.gmail.com> (raw)
In-Reply-To: <9761e1c9c114d22ab7a06ff55bf10b6ccf27a54a.1314172740.git.jingdong.lu@windriver.com>
On Wed, Aug 24, 2011 at 05:25, <Jingdong.Lu@windriver.com> wrote:
> Both hddimg and livecd use init-live.sh script to boot the rootfs.img.
> But the paths of rootfs.img in hddimg and livecd are different. So we add
> a variable "ISOLINUX" to provide a correct path.
I do like the patch and I think the way it fixes it is the right one
except by the variable name that has been choose; I'd use 'BASEDIR'
since this reflects more the reasoning of it to exist.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
next prev parent reply other threads:[~2011-08-24 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 8:25 [PATCH 0/1]initrdscripts: fix init-live.sh for hddimg and livecd Jingdong.Lu
2011-08-24 8:25 ` [PATCH 1/1] initrdscripts: " Jingdong.Lu
2011-08-24 15:43 ` Otavio Salvador [this message]
2011-08-24 23:10 ` [PATCH 0/1]initrdscripts: " Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP9ODKqzVp3RqbU6_8L5qE3nCK+VcqRaQYp=vJazfL4qT-My=A@mail.gmail.com' \
--to=otavio@ossystems.com.br \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.