All of lore.kernel.org
 help / color / mirror / Atom feed
From: Otavio Salvador <otavio@ossystems.com.br>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH 2/2] machines: Add IMAGE_BOOT_FILES
Date: Mon, 2 Mar 2015 11:54:22 -0300	[thread overview]
Message-ID: <CAP9ODKrRkGtG8xAsc387Q2TB4tAa1217z0BCgtE-oUcNmmzzGw@mail.gmail.com> (raw)
In-Reply-To: <20150302130426.GN4094@piout.net>

On Mon, Mar 2, 2015 at 10:04 AM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 02/03/2015 at 09:35:36 -0300, Otavio Salvador wrote :
>> On Mon, Mar 2, 2015 at 8:45 AM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>> > Define IMAGE_BOOT_FILES in the machine configuration to be able to
>> > create sdcard images using wic.
>> >
>> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> Thanks for looking at this; wic is indeed a very handy addition :-)
>>
>> > diff --git a/conf/machine/imx51evk.conf b/conf/machine/imx51evk.conf
>> > index 9d7d06ca41fc..89bcacb932fb 100644
>> > --- a/conf/machine/imx51evk.conf
>> > +++ b/conf/machine/imx51evk.conf
>> > @@ -13,5 +13,6 @@ SOC_FAMILY = "mx5:mx51"
>> >  PERF_FEATURES_ENABLE = ""
>> >
>> >  KERNEL_DEVICETREE = "imx51-babbage.dtb"
>> > +IMAGE_BOOT_FILES = "zImage zImage-imx51-babbage.dtb;imx51-babbage.dtb"
>> >
>> >  UBOOT_MACHINE = "mx51evk_config"
>>
>> To be honest, I don't like the idea of maintaining the list of
>> duplicated device tree files.
>>
>> I am wondering if we can cook a generic solution whick uses
>> KERNEL_DEVICETREE as input and generates the list of artifacts it
>> needs to install. Leaving them disconnected is very error prone.
>>
>
> I agree but that is the current mechanism. Actually, I think we should
> even have a better mechanism were it would be possible to select which
> files are going to which partition. I didn't implement it yet.
>
> There is one issue with generating the IMAGE_BOOT_FILES from
> KERNEL_DEVICETREE. You can put non existing dtb filenames in
> KERNEL_DEVICETREE and they will be ignored but not in IMAGE_BOOT_FILES.
> That is the case for imx6qsabresd.conf.

No; they will fail to build in the kernel as this is passed on kernel
make command.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


  reply	other threads:[~2015-03-02 14:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 11:45 [meta-fsl-arm][PATCH 1/2] wic: add kickstart files for i.mx Alexandre Belloni
2015-03-02 11:45 ` [meta-fsl-arm][PATCH 2/2] machines: Add IMAGE_BOOT_FILES Alexandre Belloni
2015-03-02 12:35   ` Otavio Salvador
2015-03-02 13:04     ` Alexandre Belloni
2015-03-02 14:54       ` Otavio Salvador [this message]
2015-03-02 15:05         ` Alexandre Belloni
2015-03-02 15:06           ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP9ODKrRkGtG8xAsc387Q2TB4tAa1217z0BCgtE-oUcNmmzzGw@mail.gmail.com \
    --to=otavio@ossystems.com.br \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=meta-freescale@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.