From: "Otavio Salvador" <otavio.salvador@ossystems.com.br>
To: Anuj Mittal <anuj.mittal@intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] Revert "Revert "libubootenv: inherit uboot-config""
Date: Fri, 23 Jul 2021 17:52:13 -0300 [thread overview]
Message-ID: <CAP9ODKrhqfHAQHgJz-CvJWoObGmgB-Yp-7kOv3Bz3ZWwfEz74g@mail.gmail.com> (raw)
In-Reply-To: <20210723001927.42892-1-anuj.mittal@intel.com>
I am against reverting it again. We discussed alternatives, which
could solve the problem.
Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
<anuj.mittal@intel.com> escreveu:
>
> This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.
>
> The original change was added to resolve build errors [1] for MACHINE
> values that don't have u-boot support. This recipe was, after that
> change, skipped in world builds for those MACHINEs.
>
> But we should be able to build libubootenv with or without u-boot
> support [2] so the original solution to inherit uboot-config was not
> perfect. But until we have a better solution, revert this so
> builds don't fail for others.
>
> [1] https://lists.openembedded.org/g/openembedded-core/message/153508
> [2] https://lists.openembedded.org/g/openembedded-core/message/153614
>
> Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
> ---
> meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> index 6774290ea5..cb59dd3f1d 100644
> --- a/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> +++ b/meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb
> @@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
>
> S = "${WORKDIR}/git"
>
> -inherit cmake lib_package
> +inherit uboot-config cmake lib_package
>
> EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
>
> --
> 2.31.1
>
>
>
>
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
next prev parent reply other threads:[~2021-07-23 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 0:19 [PATCH] Revert "Revert "libubootenv: inherit uboot-config"" Anuj Mittal
2021-07-23 20:52 ` Otavio Salvador [this message]
2021-07-23 21:10 ` [OE-core] " Richard Purdie
2021-07-25 2:15 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9ODKrhqfHAQHgJz-CvJWoObGmgB-Yp-7kOv3Bz3ZWwfEz74g@mail.gmail.com \
--to=otavio.salvador@ossystems.com.br \
--cc=anuj.mittal@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.