From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758351Ab1I3S4t (ORCPT ); Fri, 30 Sep 2011 14:56:49 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:45463 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758307Ab1I3S4r convert rfc822-to-8bit (ORCPT ); Fri, 30 Sep 2011 14:56:47 -0400 MIME-Version: 1.0 In-Reply-To: <20110930145042.4a7ee530848262294b297939@canb.auug.org.au> References: <20110930145042.4a7ee530848262294b297939@canb.auug.org.au> Date: Fri, 30 Sep 2011 14:56:46 -0400 X-Google-Sender-Auth: Jybht1BwaiQeXMOaY7dnHA8KMgY Message-ID: Subject: Re: linux-next: build failure after merge of the moduleh tree From: Paul Gortmaker To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 30, 2011 at 12:50 AM, Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/pinctrl/core.c:80:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/core.c:80:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/core.c:80:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/core.c:86:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/core.c:86:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/core.c:86:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/core.c:152:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/core.c:152:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/core.c:152:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/core.c:590:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/core.c:590:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/core.c:590:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/core.c:614:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/core.c:614:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/core.c:614:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c: In function 'pin_request': > drivers/pinctrl/pinmux.c:143:2: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] > drivers/pinctrl/pinmux.c: In function 'pin_free': > drivers/pinctrl/pinmux.c:206:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration] > drivers/pinctrl/pinmux.c: At top level: > drivers/pinctrl/pinmux.c:234:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:234:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:234:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c:257:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:257:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:257:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c:754:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:754:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:754:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c:779:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:779:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:779:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c:813:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:813:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:813:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/pinctrl/pinmux.c:837:1: warning: data definition has no type or storage class [enabled by default] > drivers/pinctrl/pinmux.c:837:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] > drivers/pinctrl/pinmux.c:837:1: warning: parameter names (without types) in function declaration [enabled by default] > > > Caused by commit 05f20c997d73 ("drivers: create a pin control subsystem > v8"), revelealed by the module.h split. > > I have applied the following patch for today (Linus, the > drivers/pinctrl/pinmux.c part of this can be applied to your tree). I've queued the remaining export.h part to core.c as a post-merge patch in the modsplit-post-merge queue. Paul. > > From: Stephen Rothwell > Date: Fri, 30 Sep 2011 14:39:04 +1000 > Subject: [PATCH] pinctrl: EXPORT_SYMBOL needs export.h > > Signed-off-by: Stephen Rothwell > --- >  drivers/pinctrl/core.c   |    1 + >  drivers/pinctrl/pinmux.c |    1 + >  2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c > index 4229628..f9263b2 100644 > --- a/drivers/pinctrl/core.c > +++ b/drivers/pinctrl/core.c > @@ -12,6 +12,7 @@ >  #define pr_fmt(fmt) "pinctrl core: " fmt > >  #include > +#include >  #include >  #include >  #include > diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c > index 37803f0..6b28f2b 100644 > --- a/drivers/pinctrl/pinmux.c > +++ b/drivers/pinctrl/pinmux.c > @@ -12,6 +12,7 @@ >  #define pr_fmt(fmt) "pinmux core: " fmt > >  #include > +#include >  #include >  #include >  #include > -- > 1.7.6.3 > > -- > Cheers, > Stephen Rothwell                    sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html >