All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hideaki Yoshifuji <hideaki.yoshifuji@miraclelinux.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "David Ahern" <dsahern@gmail.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	"Michal Kubecek" <mkubecek@suse.cz>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Xin Long" <lucien.xin@gmail.com>,
	"Vasiliy Kulikov" <segoon@openwall.com>,
	"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
	"Sami Kerola" <kerolasa@iki.fi>,
	"Hideaki Yoshifuji (yoshfuji)"
	<hideaki.yoshifuji@miraclelinux.com>
Subject: Re: ping (iputils) review (call for help)
Date: Thu, 10 Nov 2022 20:13:46 +0900	[thread overview]
Message-ID: <CAPA1RqATWqQsVjrXMOCFgbYHXvfWdbdgBhQ8Tfz4fqNs8rxVCA@mail.gmail.com> (raw)
In-Reply-To: <Y2wjS/xkCtRrKXhs@pevik>

Hi,

2022年11月10日(木) 7:01 Petr Vorel <pvorel@suse.cz>:
>
> Hi David,
>
> first, thanks a lot for having a look!

> > > BTW I wonder if it make sense to list Hideaki YOSHIFUJI as NETWORKING
> > > IPv4/IPv6 maintainer. If I'm not mistaken, it has been a decade since he was active.
>
> > > * ping: Call connect() before sending/receiving
> > > https://github.com/iputils/iputils/pull/391
> > > => I did not even knew it's possible to connect to ping socket, but looks like
> > > it works on both raw socket and on ICMP datagram socket.
>
> > no strong opinion on this one. A command line option to use connect
> > might be better than always doing the connect.
> I was thinking about it, as it'd be safer in case of some regression.
> If there is no other opinion I'll probably go this way, although I generally
> prefer not adding more command line options.

+1: Because ping utility is a basic (or fundamental) tool for
debugging networks,
I do prefer having an option like this to help low-level debugging.

--yoshfuji

      reply	other threads:[~2022-11-10 11:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 11:30 ping (iputils) review (call for help) Petr Vorel
2022-11-03 15:43 ` Xin Long
2022-11-03 17:24   ` Petr Vorel
2022-11-03 20:27     ` Xin Long
2022-11-09 16:25 ` David Ahern
2022-11-09 22:01   ` Petr Vorel
2022-11-10 11:13     ` Hideaki Yoshifuji [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPA1RqATWqQsVjrXMOCFgbYHXvfWdbdgBhQ8Tfz4fqNs8rxVCA@mail.gmail.com \
    --to=hideaki.yoshifuji@miraclelinux.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=kerolasa@iki.fi \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pvorel@suse.cz \
    --cc=segoon@openwall.com \
    --cc=toke@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.