From: Alexandre Courbot <acourbot@chromium.org>
To: mgottam@codeaurora.org
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org
Subject: Re: [PATCH] media: venus: amend buffer size for bitstream plane
Date: Mon, 22 Oct 2018 15:12:06 +0900 [thread overview]
Message-ID: <CAPBb6MWF2XWZyyKUXpe=JDmSfcyPcjgXWOd5VQDpmz9iA4C1PQ@mail.gmail.com> (raw)
In-Reply-To: <1539071530-1441-1-git-send-email-mgottam@codeaurora.org>
On Tue, Oct 9, 2018 at 4:52 PM Malathi Gottam <mgottam@codeaurora.org> wrote:
>
> For lower resolutions, incase of encoder, the compressed
> frame size is more than half of the corresponding input
> YUV. Keep the size as same as YUV considering worst case.
>
> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
This fixes some issues we had with low-resolution VP8 encoding. Maybe
this can be refined some more for higher resolutions, but the current
version at least works.
Tested-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> drivers/media/platform/qcom/venus/helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 2679adb..05c5423 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -649,7 +649,7 @@ u32 venus_helper_get_framesz(u32 v4l2_fmt, u32 width, u32 height)
> }
>
> if (compressed) {
> - sz = ALIGN(height, 32) * ALIGN(width, 32) * 3 / 2 / 2;
> + sz = ALIGN(height, 32) * ALIGN(width, 32) * 3 / 2;
> return ALIGN(sz, SZ_4K);
> }
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2018-10-22 6:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 7:52 [PATCH] media: venus: amend buffer size for bitstream plane Malathi Gottam
2018-10-22 6:12 ` Alexandre Courbot [this message]
2018-10-23 2:50 ` Tomasz Figa
2018-11-12 12:34 ` Stanimir Varbanov
2018-11-13 7:28 ` mgottam
2018-11-13 8:12 ` Stanimir Varbanov
2018-11-13 9:13 ` Tomasz Figa
2018-11-13 10:46 ` Stanimir Varbanov
2018-11-14 3:51 ` Tomasz Figa
2018-11-16 4:34 ` mgottam
2018-11-16 6:02 ` Tomasz Figa
2018-11-12 12:28 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPBb6MWF2XWZyyKUXpe=JDmSfcyPcjgXWOd5VQDpmz9iA4C1PQ@mail.gmail.com' \
--to=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mgottam@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.