From: Alexandre Courbot <acourbot@chromium.org> To: Tzung-Bi Shih <tzungbi@google.com> Cc: Tiffany Lin <tiffany.lin@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Yunfei Dong <yunfei.dong@mediatek.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org> Subject: Re: [PATCH v5 06/14] media: mtk-vcodec: vdec: move stateful ops into their own file Date: Thu, 27 May 2021 19:10:28 +0900 [thread overview] Message-ID: <CAPBb6MXFrneXmhA=1FshkrGLZOder4_KeyzD7xGdw66o0hTBZw@mail.gmail.com> (raw) In-Reply-To: <CA+Px+wV2N9uRuMGBzZDibCYqPVigPb5K40Q1BuLa58K2RY_eaA@mail.gmail.com> On Fri, May 21, 2021 at 10:37 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > On Wed, May 19, 2021 at 10:31 PM Alexandre Courbot > <acourbot@chromium.org> wrote: > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c > > new file mode 100644 > > index 000000000000..ed4b1308a0e4 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c > > @@ -0,0 +1,667 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include <media/v4l2-event.h> > > +#include <media/v4l2-mem2mem.h> > > +#include <media/videobuf2-dma-contig.h> > > + > > +#include "mtk_vcodec_drv.h" > > +#include "mtk_vcodec_dec.h" > > +#include "mtk_vcodec_intr.h" > > +#include "mtk_vcodec_util.h" > > +#include "vdec_drv_if.h" > > +#include "mtk_vcodec_dec_pm.h" > > Would be good practice to sort them. Did what I could, but the order seems to somehow matter. :/ > > > +static struct vb2_buffer *get_display_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vdec_fb *disp_frame_buffer = NULL; > > + struct mtk_video_dec_buf *dstbuf; > > + struct vb2_v4l2_buffer *vb; > > + > > + mtk_v4l2_debug(3, "[%d]", ctx->id); > > + if (vdec_if_get_param(ctx, > > + GET_PARAM_DISP_FRAME_BUFFER, > > + &disp_frame_buffer)) { > > + mtk_v4l2_err("[%d]Cannot get param : GET_PARAM_DISP_FRAME_BUFFER", > > + ctx->id); > > + return NULL; > > + } > > + > > + if (disp_frame_buffer == NULL) { > > Although this is a move refactor, to be neat, !disp_frame_buffer. These were also raised by checkpatch.pl --strict, they are now all fixed. > > > +static struct vb2_buffer *get_free_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct mtk_video_dec_buf *dstbuf; > > + struct vdec_fb *free_frame_buffer = NULL; > > + struct vb2_v4l2_buffer *vb; > > + > > + if (vdec_if_get_param(ctx, > > + GET_PARAM_FREE_FRAME_BUFFER, > > + &free_frame_buffer)) { > > + mtk_v4l2_err("[%d] Error!! Cannot get param", ctx->id); > > + return NULL; > > + } > > + if (free_frame_buffer == NULL) { > > The same concern as above. > > > +static void clean_display_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vb2_buffer *framptr; > > + > > + do { > > + framptr = get_display_buffer(ctx); > > + } while (framptr); > > +} > > + > > +static void clean_free_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vb2_buffer *framptr; > > + > > + do { > > + framptr = get_free_buffer(ctx); > > + } while (framptr); > > +} > > while (get_display_buffer(ctx)) ; > and > while (get_free_buffer(ctx)) ; > looks better. Done. > > > +static int mtk_vdec_flush_decoder(struct mtk_vcodec_ctx *ctx) > > +{ > > + bool res_chg; > > + int ret = 0; > > No need to initialize. Done. > > > +static void mtk_vdec_worker(struct work_struct *work) > > +{ > > + struct mtk_vcodec_ctx *ctx = container_of(work, struct mtk_vcodec_ctx, > > + decode_work); > > + struct mtk_vcodec_dev *dev = ctx->dev; > > + struct vb2_v4l2_buffer *src_buf, *dst_buf; > > + struct mtk_vcodec_mem buf; > > + struct vdec_fb *pfb; > > + bool res_chg = false; > > + int ret; > > + struct mtk_video_dec_buf *dst_buf_info, *src_buf_info; > > + > > + src_buf = v4l2_m2m_next_src_buf(ctx->m2m_ctx); > > + if (src_buf == NULL) { > > To neat, !src_buf. > > > + dst_buf = v4l2_m2m_next_dst_buf(ctx->m2m_ctx); > > + if (dst_buf == NULL) { > > To neat, !dst_buf. > > > +static void vb2ops_vdec_stateful_buf_queue(struct vb2_buffer *vb) > > +{ > > + struct vb2_v4l2_buffer *src_buf; > > + struct mtk_vcodec_mem src_mem; > > + bool res_chg = false; > > + int ret = 0; > > + unsigned int dpbsize = 1, i = 0; > > + struct mtk_vcodec_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); > > + struct vb2_v4l2_buffer *vb2_v4l2 = NULL; > > ret, i, and vb2_v4l2 are obviously no need to initialize. Done, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@chromium.org> To: Tzung-Bi Shih <tzungbi@google.com> Cc: Tiffany Lin <tiffany.lin@mediatek.com>, Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Dafna Hirschfeld <dafna.hirschfeld@collabora.com>, Yunfei Dong <yunfei.dong@mediatek.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org> Subject: Re: [PATCH v5 06/14] media: mtk-vcodec: vdec: move stateful ops into their own file Date: Thu, 27 May 2021 19:10:28 +0900 [thread overview] Message-ID: <CAPBb6MXFrneXmhA=1FshkrGLZOder4_KeyzD7xGdw66o0hTBZw@mail.gmail.com> (raw) In-Reply-To: <CA+Px+wV2N9uRuMGBzZDibCYqPVigPb5K40Q1BuLa58K2RY_eaA@mail.gmail.com> On Fri, May 21, 2021 at 10:37 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > On Wed, May 19, 2021 at 10:31 PM Alexandre Courbot > <acourbot@chromium.org> wrote: > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c > > new file mode 100644 > > index 000000000000..ed4b1308a0e4 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_stateful.c > > @@ -0,0 +1,667 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +#include <media/v4l2-event.h> > > +#include <media/v4l2-mem2mem.h> > > +#include <media/videobuf2-dma-contig.h> > > + > > +#include "mtk_vcodec_drv.h" > > +#include "mtk_vcodec_dec.h" > > +#include "mtk_vcodec_intr.h" > > +#include "mtk_vcodec_util.h" > > +#include "vdec_drv_if.h" > > +#include "mtk_vcodec_dec_pm.h" > > Would be good practice to sort them. Did what I could, but the order seems to somehow matter. :/ > > > +static struct vb2_buffer *get_display_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vdec_fb *disp_frame_buffer = NULL; > > + struct mtk_video_dec_buf *dstbuf; > > + struct vb2_v4l2_buffer *vb; > > + > > + mtk_v4l2_debug(3, "[%d]", ctx->id); > > + if (vdec_if_get_param(ctx, > > + GET_PARAM_DISP_FRAME_BUFFER, > > + &disp_frame_buffer)) { > > + mtk_v4l2_err("[%d]Cannot get param : GET_PARAM_DISP_FRAME_BUFFER", > > + ctx->id); > > + return NULL; > > + } > > + > > + if (disp_frame_buffer == NULL) { > > Although this is a move refactor, to be neat, !disp_frame_buffer. These were also raised by checkpatch.pl --strict, they are now all fixed. > > > +static struct vb2_buffer *get_free_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct mtk_video_dec_buf *dstbuf; > > + struct vdec_fb *free_frame_buffer = NULL; > > + struct vb2_v4l2_buffer *vb; > > + > > + if (vdec_if_get_param(ctx, > > + GET_PARAM_FREE_FRAME_BUFFER, > > + &free_frame_buffer)) { > > + mtk_v4l2_err("[%d] Error!! Cannot get param", ctx->id); > > + return NULL; > > + } > > + if (free_frame_buffer == NULL) { > > The same concern as above. > > > +static void clean_display_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vb2_buffer *framptr; > > + > > + do { > > + framptr = get_display_buffer(ctx); > > + } while (framptr); > > +} > > + > > +static void clean_free_buffer(struct mtk_vcodec_ctx *ctx) > > +{ > > + struct vb2_buffer *framptr; > > + > > + do { > > + framptr = get_free_buffer(ctx); > > + } while (framptr); > > +} > > while (get_display_buffer(ctx)) ; > and > while (get_free_buffer(ctx)) ; > looks better. Done. > > > +static int mtk_vdec_flush_decoder(struct mtk_vcodec_ctx *ctx) > > +{ > > + bool res_chg; > > + int ret = 0; > > No need to initialize. Done. > > > +static void mtk_vdec_worker(struct work_struct *work) > > +{ > > + struct mtk_vcodec_ctx *ctx = container_of(work, struct mtk_vcodec_ctx, > > + decode_work); > > + struct mtk_vcodec_dev *dev = ctx->dev; > > + struct vb2_v4l2_buffer *src_buf, *dst_buf; > > + struct mtk_vcodec_mem buf; > > + struct vdec_fb *pfb; > > + bool res_chg = false; > > + int ret; > > + struct mtk_video_dec_buf *dst_buf_info, *src_buf_info; > > + > > + src_buf = v4l2_m2m_next_src_buf(ctx->m2m_ctx); > > + if (src_buf == NULL) { > > To neat, !src_buf. > > > + dst_buf = v4l2_m2m_next_dst_buf(ctx->m2m_ctx); > > + if (dst_buf == NULL) { > > To neat, !dst_buf. > > > +static void vb2ops_vdec_stateful_buf_queue(struct vb2_buffer *vb) > > +{ > > + struct vb2_v4l2_buffer *src_buf; > > + struct mtk_vcodec_mem src_mem; > > + bool res_chg = false; > > + int ret = 0; > > + unsigned int dpbsize = 1, i = 0; > > + struct mtk_vcodec_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); > > + struct vb2_v4l2_buffer *vb2_v4l2 = NULL; > > ret, i, and vb2_v4l2 are obviously no need to initialize. Done, thanks! _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-05-27 10:10 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 14:29 [PATCH v5 00/14] media: mtk-vcodec: support for MT8183 decoder Alexandre Courbot 2021-05-19 14:29 ` Alexandre Courbot 2021-05-19 14:29 ` [PATCH v5 01/14] media: mtk-vcodec: vdec: Support H264 profile control Alexandre Courbot 2021-05-19 14:29 ` Alexandre Courbot 2021-05-21 13:36 ` Tzung-Bi Shih 2021-05-21 13:36 ` Tzung-Bi Shih 2021-05-19 14:29 ` [PATCH v5 02/14] media: mtk-vcodec: vdec: use helpers in VIDIOC_(TRY_)DECODER_CMD Alexandre Courbot 2021-05-19 14:29 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 03/14] media: mtk-vcodec: vdec: clamp OUTPUT resolution to hardware limits Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 04/14] media: mtk-vcodec: make flush buffer reusable by encoder Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 05/14] media: mtk-vcodec: venc: support START and STOP commands Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-27 10:10 ` Alexandre Courbot 2021-05-27 10:10 ` Alexandre Courbot 2021-05-28 7:03 ` Dafna Hirschfeld 2021-05-28 7:03 ` Dafna Hirschfeld 2021-05-28 7:43 ` Dafna Hirschfeld 2021-05-28 7:43 ` Dafna Hirschfeld 2021-07-05 5:04 ` Alexandre Courbot 2021-07-05 5:04 ` Alexandre Courbot 2021-07-05 5:04 ` Alexandre Courbot 2021-07-05 5:04 ` Alexandre Courbot 2021-07-06 15:17 ` Enric Balletbo Serra 2021-07-06 15:17 ` Enric Balletbo Serra 2021-05-19 14:30 ` [PATCH v5 06/14] media: mtk-vcodec: vdec: move stateful ops into their own file Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-27 10:10 ` Alexandre Courbot [this message] 2021-05-27 10:10 ` Alexandre Courbot 2021-05-19 14:30 ` [PATCH v5 07/14] media: mtk-vcodec: vdec: handle firmware version field Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 08/14] media: mtk-vcodec: support version 2 of decoder firmware ABI Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 09/14] media: add Mediatek's MM21 format Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-21 13:37 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 10/14] media: mtk-vcodec: vdec: support stateless API Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 11/14] media: mtk-vcodec: vdec: support stateless H.264 decoding Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-27 10:10 ` Alexandre Courbot 2021-05-27 10:10 ` Alexandre Courbot 2021-05-19 14:30 ` [PATCH v5 12/14] media: mtk-vcodec: vdec: add media device if using stateless api Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-19 14:30 ` [PATCH v5 13/14] dt-bindings: media: document mediatek,mt8183-vcodec-dec Alexandre Courbot 2021-05-19 14:30 ` [PATCH v5 13/14] dt-bindings: media: document mediatek, mt8183-vcodec-dec Alexandre Courbot 2021-05-19 14:30 ` [PATCH v5 14/14] media: mtk-vcodec: enable MT8183 decoder Alexandre Courbot 2021-05-19 14:30 ` Alexandre Courbot 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-21 13:38 ` Tzung-Bi Shih 2021-05-27 8:08 ` [PATCH v5 00/14] media: mtk-vcodec: support for " Hans Verkuil 2021-05-27 8:08 ` Hans Verkuil 2021-05-27 10:10 ` Alexandre Courbot 2021-05-27 10:10 ` Alexandre Courbot 2021-05-27 10:18 ` Hans Verkuil 2021-05-27 10:18 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPBb6MXFrneXmhA=1FshkrGLZOder4_KeyzD7xGdw66o0hTBZw@mail.gmail.com' \ --to=acourbot@chromium.org \ --cc=andrew-ct.chen@mediatek.com \ --cc=dafna.hirschfeld@collabora.com \ --cc=hverkuil-cisco@xs4all.nl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=tiffany.lin@mediatek.com \ --cc=tzungbi@google.com \ --cc=yunfei.dong@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.