All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Lambley <dave@lambley.me.uk>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-acpi@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2] If _BIX fails, retry with _BIF.
Date: Thu, 3 Nov 2016 08:33:55 +0000	[thread overview]
Message-ID: <CAPCK=o8Ydkb530rnzUBUo1+tZxbiK+ocfPrHQmogS3PnUSbSdw@mail.gmail.com> (raw)
In-Reply-To: <20161102232623.GA15671@khazad-dum.debian.net>

On 2 November 2016 at 23:26, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote:
>
> On Wed, 02 Nov 2016, Dave Lambley wrote:
> > -static int acpi_battery_get_info(struct acpi_battery *battery)
> > +
> > +int extract_battery_info(const int use_bix,
> > +                      struct acpi_battery *battery,
> > +                      const struct acpi_buffer *buffer)
>
> Shouldn't extract_battery_info() be static as well?

I do not believe it needs to be exported. It is a new function only
used inside battery.c.

Best regards,
Dave

  reply	other threads:[~2016-11-03  8:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14  8:40 [PATCH] Avoid _BIX ACPI method on Lenovo Yoga 300 Dave Lambley
2016-09-14 10:34 ` Zheng, Lv
2016-09-17 22:56   ` [PATCH] If _BIX fails, retry with _BIF Dave Lambley
2016-11-02 18:37     ` [PATCH v2] Lenovo Yoga 300 battery support Dave Lambley
2016-11-02 18:37       ` [PATCH v2] If _BIX fails, retry with _BIF Dave Lambley
2016-11-02 23:26         ` Henrique de Moraes Holschuh
2016-11-03  8:33           ` Dave Lambley [this message]
2016-11-03 22:38             ` Henrique de Moraes Holschuh
2016-11-04  1:05               ` [PATCH v3 0/1] Lenovo Yoga 300 battery support Dave Lambley
2016-11-04  1:05                 ` [PATCH v3 1/1] If _BIX fails, retry with _BIF Dave Lambley
2016-11-24  1:25                   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPCK=o8Ydkb530rnzUBUo1+tZxbiK+ocfPrHQmogS3PnUSbSdw@mail.gmail.com' \
    --to=dave@lambley.me.uk \
    --cc=hmh@hmh.eng.br \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.