All of lore.kernel.org
 help / color / mirror / Atom feed
From: Urja Rannikko <urjaman@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] configs: Move CONFIG_CMD_USB_MASS_STORAGE properly into Kconfig
Date: Wed, 3 Apr 2019 18:44:39 +0000	[thread overview]
Message-ID: <CAPCnQJ=n3jp-vbDVpN_-MPqdZ_-iAUzatszNXL+nfGo=8WBbog@mail.gmail.com> (raw)
In-Reply-To: <13d7cf92-dae2-a11f-eb41-55dc88a1c2e7@embed.me.uk>

Hi,

On Wed, Apr 3, 2019 at 9:52 AM Jack Mitchell <ml@embed.me.uk> wrote:
>
> Hi,
> > --- a/include/configs/rk3036_common.h
> > +++ b/include/configs/rk3036_common.h
> > @@ -32,7 +32,6 @@
> >  /* usb otg */
> >
> >  /* usb mass storage */
> > -#define CONFIG_CMD_USB_MASS_STORAGE
>
> This is leaving empty comments which serve no purpose. Looks like the
> same has happened above for when the usb otg parts got moved. Ditto for
> the other files below.
Thanks for noticing, i'll send a revised patch in a few minutes.

-- 
Urja Rannikko

  reply	other threads:[~2019-04-03 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  9:34 [U-Boot] [PATCH 0/3] rk3288 (also rk3036, rk322x) defconfig fixes Urja Rannikko
2019-04-03  9:34 ` [U-Boot] [PATCH 1/3] configs: Move CONFIG_SPI_FLASH_GIGADEVICE properly into Kconfig Urja Rannikko
2019-04-24  3:54   ` Simon Glass
2019-04-03  9:34 ` [U-Boot] [PATCH 2/3] configs: Move CONFIG_CMD_USB_MASS_STORAGE " Urja Rannikko
2019-04-03  9:52   ` Jack Mitchell
2019-04-03 18:44     ` Urja Rannikko [this message]
2019-04-03  9:34 ` [U-Boot] [PATCH 3/3] configs: update rk3288 veyron defconfigs Urja Rannikko
2019-04-24  3:54   ` Simon Glass
2019-04-03 18:48 ` [U-Boot] [PATCH v2] configs: Move CONFIG_CMD_USB_MASS_STORAGE properly into Kconfig Urja Rannikko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPCnQJ=n3jp-vbDVpN_-MPqdZ_-iAUzatszNXL+nfGo=8WBbog@mail.gmail.com' \
    --to=urjaman@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.