From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Tyshchenko Subject: Re: [PATCH v2 12/13] [RFC] iommu: VT-d: Squash map_pages/unmap_pages with map_page/unmap_page Date: Mon, 21 Aug 2017 19:44:16 +0300 Message-ID: References: <1501003615-15274-1-git-send-email-olekstysh@gmail.com> <1501003615-15274-13-git-send-email-olekstysh@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djpoK-000448-N7 for xen-devel@lists.xenproject.org; Mon, 21 Aug 2017 16:44:20 +0000 Received: by mail-io0-f193.google.com with SMTP id m40so787883ioi.4 for ; Mon, 21 Aug 2017 09:44:18 -0700 (PDT) In-Reply-To: <1501003615-15274-13-git-send-email-olekstysh@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Kevin Tian , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGksIGFsbC4KCkFueSBjb21tZW50cz8KCk9uIFR1ZSwgSnVsIDI1LCAyMDE3IGF0IDg6MjYgUE0s IE9sZWtzYW5kciBUeXNoY2hlbmtvCjxvbGVrc3R5c2hAZ21haWwuY29tPiB3cm90ZToKPiBGcm9t OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+Cj4K PiBSZWR1Y2UgdGhlIHNjb3BlIG9mIHRoZSBUT0RPIGJ5IHNxdWFzaGluZyBzaW5nbGUtcGFnZSBz dHVmZiB3aXRoCj4gbXVsdGktcGFnZSBvbmUuIE5leHQgdGFyZ2V0IGlzIHRvIHVzZSBsYXJnZSBw YWdlcyB3aGVuZXZlciBwb3NzaWJsZQo+IGluIHRoZSBjYXNlIHRoYXQgaGFyZHdhcmUgc3VwcG9y dHMgdGhlbS4KPgo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2Fu ZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4KPiBDQzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2Uu Y29tPgo+IENDOiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KPgo+IC0tLQo+ICAg IENoYW5nZXMgaW4gdjE6Cj4gICAgICAgLQo+Cj4gICAgQ2hhbmdlcyBpbiB2MjoKPiAgICAgICAt Cj4gLS0tCj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jIHwgMTM4ICsrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNjcgaW5z ZXJ0aW9ucygrKSwgNzEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMv cGFzc3Rocm91Z2gvdnRkL2lvbW11LmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t bXUuYwo+IGluZGV4IDQ1ZDFmMzYuLmQyMGIyZjkgMTAwNjQ0Cj4gLS0tIGEveGVuL2RyaXZlcnMv cGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92 dGQvaW9tbXUuYwo+IEBAIC0xNzUwLDE1ICsxNzUwLDI0IEBAIHN0YXRpYyB2b2lkIGlvbW11X2Rv bWFpbl90ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKQo+ICAgICAgc3Bpbl91bmxvY2soJmhkLT5h cmNoLm1hcHBpbmdfbG9jayk7Cj4gIH0KPgo+IC1zdGF0aWMgaW50IF9fbXVzdF9jaGVjayBpbnRl bF9pb21tdV9tYXBfcGFnZShzdHJ1Y3QgZG9tYWluICpkLAo+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGdmbiwKPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4sCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBmbGFncykKPiArc3RhdGljIGludCBfX211c3RfY2hlY2sgaW50ZWxfaW9tbXVfdW5tYXBfcGFn ZXMoc3RydWN0IGRvbWFpbiAqZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBnZm4sCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBvcmRlcik7Cj4gKwo+ICsv Kgo+ICsgKiBUT0RPOiBPcHRpbWl6ZSBieSB1c2luZyBsYXJnZSBwYWdlcyB3aGVuZXZlciBwb3Nz aWJsZSBpbiB0aGUgY2FzZQo+ICsgKiB0aGF0IGhhcmR3YXJlIHN1cHBvcnRzIHRoZW0uCj4gKyAq Lwo+ICtzdGF0aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBfcGFnZXMoc3RydWN0 IGRvbWFpbiAqZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGxvbmcgZ2ZuLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4sCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXIsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZ3Mp Cj4gIHsKPiAgICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwo+IC0g ICAgc3RydWN0IGRtYV9wdGUgKnBhZ2UgPSBOVUxMLCAqcHRlID0gTlVMTCwgb2xkLCBuZXcgPSB7 IDAgfTsKPiAtICAgIHU2NCBwZ19tYWRkcjsKPiAgICAgIGludCByYyA9IDA7Cj4gKyAgICB1bnNp Z25lZCBsb25nIG9yaWdfZ2ZuID0gZ2ZuOwo+ICsgICAgdW5zaWduZWQgbG9uZyBpOwo+Cj4gICAg ICAvKiBEbyBub3RoaW5nIGlmIFZULWQgc2hhcmVzIEVQVCBwYWdlIHRhYmxlICovCj4gICAgICBp ZiAoIGlvbW11X3VzZV9oYXBfcHQoZCkgKQo+IEBAIC0xNzY4LDc4ICsxNzc3LDYwIEBAIHN0YXRp YyBpbnQgX19tdXN0X2NoZWNrIGludGVsX2lvbW11X21hcF9wYWdlKHN0cnVjdCBkb21haW4gKmQs Cj4gICAgICBpZiAoIGlvbW11X3Bhc3N0aHJvdWdoICYmIGlzX2hhcmR3YXJlX2RvbWFpbihkKSAp Cj4gICAgICAgICAgcmV0dXJuIDA7Cj4KPiAtICAgIHNwaW5fbG9jaygmaGQtPmFyY2gubWFwcGlu Z19sb2NrKTsKPiAtCj4gLSAgICBwZ19tYWRkciA9IGFkZHJfdG9fZG1hX3BhZ2VfbWFkZHIoZCwg KHBhZGRyX3QpZ2ZuIDw8IFBBR0VfU0hJRlRfNEssIDEpOwo+IC0gICAgaWYgKCBwZ19tYWRkciA9 PSAwICkKPiArICAgIGZvciAoIGkgPSAwOyBpIDwgKDFVTCA8PCBvcmRlcik7IGkrKywgZ2ZuKyss IG1mbisrICkKPiAgICAgIHsKPiAtICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGlu Z19sb2NrKTsKPiAtICAgICAgICByZXR1cm4gLUVOT01FTTsKPiAtICAgIH0KPiAtICAgIHBhZ2Ug PSAoc3RydWN0IGRtYV9wdGUgKiltYXBfdnRkX2RvbWFpbl9wYWdlKHBnX21hZGRyKTsKPiAtICAg IHB0ZSA9IHBhZ2UgKyAoZ2ZuICYgTEVWRUxfTUFTSyk7Cj4gLSAgICBvbGQgPSAqcHRlOwo+IC0g ICAgZG1hX3NldF9wdGVfYWRkcihuZXcsIChwYWRkcl90KW1mbiA8PCBQQUdFX1NISUZUXzRLKTsK PiAtICAgIGRtYV9zZXRfcHRlX3Byb3QobmV3LAo+IC0gICAgICAgICAgICAgICAgICAgICAoKGZs YWdzICYgSU9NTVVGX3JlYWRhYmxlKSA/IERNQV9QVEVfUkVBRCAgOiAwKSB8Cj4gLSAgICAgICAg ICAgICAgICAgICAgICgoZmxhZ3MgJiBJT01NVUZfd3JpdGFibGUpID8gRE1BX1BURV9XUklURSA6 IDApKTsKPiArICAgICAgICBzdHJ1Y3QgZG1hX3B0ZSAqcGFnZSA9IE5VTEwsICpwdGUgPSBOVUxM LCBvbGQsIG5ldyA9IHsgMCB9Owo+ICsgICAgICAgIHU2NCBwZ19tYWRkcjsKPgo+IC0gICAgLyog U2V0IHRoZSBTTlAgb24gbGVhZiBwYWdlIHRhYmxlIGlmIFNub29wIENvbnRyb2wgYXZhaWxhYmxl ICovCj4gLSAgICBpZiAoIGlvbW11X3Nub29wICkKPiAtICAgICAgICBkbWFfc2V0X3B0ZV9zbnAo bmV3KTsKPiArICAgICAgICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7Cj4KPiAt ICAgIGlmICggb2xkLnZhbCA9PSBuZXcudmFsICkKPiAtICAgIHsKPiArICAgICAgICBwZ19tYWRk ciA9IGFkZHJfdG9fZG1hX3BhZ2VfbWFkZHIoZCwgKHBhZGRyX3QpZ2ZuIDw8IFBBR0VfU0hJRlRf NEssIDEpOwo+ICsgICAgICAgIGlmICggcGdfbWFkZHIgPT0gMCApCj4gKyAgICAgICAgewo+ICsg ICAgICAgICAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFwcGluZ19sb2NrKTsKPiArICAgICAg ICAgICAgcmMgPSAtRU5PTUVNOwo+ICsgICAgICAgICAgICBnb3RvIGVycjsKPiArICAgICAgICB9 Cj4gKyAgICAgICAgcGFnZSA9IChzdHJ1Y3QgZG1hX3B0ZSAqKW1hcF92dGRfZG9tYWluX3BhZ2Uo cGdfbWFkZHIpOwo+ICsgICAgICAgIHB0ZSA9IHBhZ2UgKyAoZ2ZuICYgTEVWRUxfTUFTSyk7Cj4g KyAgICAgICAgb2xkID0gKnB0ZTsKPiArICAgICAgICBkbWFfc2V0X3B0ZV9hZGRyKG5ldywgKHBh ZGRyX3QpbWZuIDw8IFBBR0VfU0hJRlRfNEspOwo+ICsgICAgICAgIGRtYV9zZXRfcHRlX3Byb3Qo bmV3LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgKChmbGFncyAmIElPTU1VRl9yZWFkYWJs ZSkgPyBETUFfUFRFX1JFQUQgIDogMCkgfAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgKChm bGFncyAmIElPTU1VRl93cml0YWJsZSkgPyBETUFfUFRFX1dSSVRFIDogMCkpOwo+ICsKPiArICAg ICAgICAvKiBTZXQgdGhlIFNOUCBvbiBsZWFmIHBhZ2UgdGFibGUgaWYgU25vb3AgQ29udHJvbCBh dmFpbGFibGUgKi8KPiArICAgICAgICBpZiAoIGlvbW11X3Nub29wICkKPiArICAgICAgICAgICAg ZG1hX3NldF9wdGVfc25wKG5ldyk7Cj4gKwo+ICsgICAgICAgIGlmICggb2xkLnZhbCA9PSBuZXcu dmFsICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5t YXBwaW5nX2xvY2spOwo+ICsgICAgICAgICAgICB1bm1hcF92dGRfZG9tYWluX3BhZ2UocGFnZSk7 Cj4gKyAgICAgICAgICAgIGNvbnRpbnVlOwo+ICsgICAgICAgIH0KPiArICAgICAgICAqcHRlID0g bmV3Owo+ICsKPiArICAgICAgICBpb21tdV9mbHVzaF9jYWNoZV9lbnRyeShwdGUsIHNpemVvZihz dHJ1Y3QgZG1hX3B0ZSkpOwo+ICAgICAgICAgIHNwaW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5n X2xvY2spOwo+ICAgICAgICAgIHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYWdlKTsKPiAtICAgICAg ICByZXR1cm4gMDsKPiAtICAgIH0KPiAtICAgICpwdGUgPSBuZXc7Cj4gLQo+IC0gICAgaW9tbXVf Zmx1c2hfY2FjaGVfZW50cnkocHRlLCBzaXplb2Yoc3RydWN0IGRtYV9wdGUpKTsKPiAtICAgIHNw aW5fdW5sb2NrKCZoZC0+YXJjaC5tYXBwaW5nX2xvY2spOwo+IC0gICAgdW5tYXBfdnRkX2RvbWFp bl9wYWdlKHBhZ2UpOwo+Cj4gLSAgICBpZiAoICF0aGlzX2NwdShpb21tdV9kb250X2ZsdXNoX2lv dGxiKSApCj4gLSAgICAgICAgcmMgPSBpb21tdV9mbHVzaF9pb3RsYihkLCBnZm4sIGRtYV9wdGVf cHJlc2VudChvbGQpLCAxKTsKPiAtCj4gLSAgICByZXR1cm4gcmM7Cj4gLX0KPiAtCj4gLXN0YXRp YyBpbnQgX19tdXN0X2NoZWNrIGludGVsX2lvbW11X3VubWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAq ZCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBsb25nIGdmbikKPiAtewo+IC0gICAgLyogRG8gbm90aGluZyBpZiBoYXJkd2FyZSBkb21h aW4gYW5kIGlvbW11IHN1cHBvcnRzIHBhc3MgdGhydS4gKi8KPiAtICAgIGlmICggaW9tbXVfcGFz c3Rocm91Z2ggJiYgaXNfaGFyZHdhcmVfZG9tYWluKGQpICkKPiAtICAgICAgICByZXR1cm4gMDsK PiAtCj4gLSAgICByZXR1cm4gZG1hX3B0ZV9jbGVhcl9vbmUoZCwgKHBhZGRyX3QpZ2ZuIDw8IFBB R0VfU0hJRlRfNEspOwo+IC19Cj4gLQo+IC0vKiBUT0RPOiBPcHRpbWl6ZSBieSBzcXVhc2hpbmcg bWFwX3BhZ2VzL3VubWFwX3BhZ2VzIHdpdGggbWFwX3BhZ2UvdW5tYXBfcGFnZSAqLwo+IC1zdGF0 aWMgaW50IF9fbXVzdF9jaGVjayBpbnRlbF9pb21tdV9tYXBfcGFnZXMoc3RydWN0IGRvbWFpbiAq ZCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGxvbmcgZ2ZuLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgbG9uZyBtZm4sCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXIsCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MpCj4gLXsKPiAt ICAgIHVuc2lnbmVkIGxvbmcgaTsKPiAtICAgIGludCByYyA9IDA7Cj4gLQo+IC0gICAgZm9yICgg aSA9IDA7IGkgPCAoMVVMIDw8IG9yZGVyKTsgaSsrICkKPiAtICAgIHsKPiAtICAgICAgICByYyA9 IGludGVsX2lvbW11X21hcF9wYWdlKGQsIGdmbiArIGksIG1mbiArIGksIGZsYWdzKTsKPiAtICAg ICAgICBpZiAoIHVubGlrZWx5KHJjKSApCj4gKyAgICAgICAgaWYgKCAhdGhpc19jcHUoaW9tbXVf ZG9udF9mbHVzaF9pb3RsYikgKQo+ICAgICAgICAgIHsKPiAtICAgICAgICAgICAgd2hpbGUgKCBp LS0gKQo+IC0gICAgICAgICAgICAgICAgLyogSWYgc3RhdGVtZW50IHRvIHNhdGlzZnkgX19tdXN0 X2NoZWNrLiAqLwo+IC0gICAgICAgICAgICAgICAgaWYgKCBpbnRlbF9pb21tdV91bm1hcF9wYWdl KGQsIGdmbiArIGkpICkKPiAtICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAg ICAgICAgICAgIGJyZWFrOwo+ICsgICAgICAgICAgICByYyA9IGlvbW11X2ZsdXNoX2lvdGxiKGQs IGdmbiwgZG1hX3B0ZV9wcmVzZW50KG9sZCksIDEpOwo+ICsgICAgICAgICAgICBpZiAoIHJjICkK PiArICAgICAgICAgICAgICAgIGdvdG8gZXJyOwo+ICAgICAgICAgIH0KPiAgICAgIH0KPgo+ICsg ICAgcmV0dXJuIDA7Cj4gKwo+ICtlcnI6Cj4gKyAgICB3aGlsZSAoIGktLSApCj4gKyAgICAgICAg LyogSWYgc3RhdGVtZW50IHRvIHNhdGlzZnkgX19tdXN0X2NoZWNrLiAqLwo+ICsgICAgICAgIGlm ICggaW50ZWxfaW9tbXVfdW5tYXBfcGFnZXMoZCwgb3JpZ19nZm4gKyBpLCAwKSApCj4gKyAgICAg ICAgICAgIGNvbnRpbnVlOwo+ICsKPiAgICAgIHJldHVybiByYzsKPiAgfQo+Cj4gQEAgLTE4NDcs MTIgKzE4MzgsMTcgQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgaW50ZWxfaW9tbXVfdW5tYXBf cGFnZXMoc3RydWN0IGRvbWFpbiAqZCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBnZm4sCj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBvcmRlcikKPiAgewo+ IC0gICAgdW5zaWduZWQgbG9uZyBpOwo+ICAgICAgaW50IHJjID0gMDsKPiArICAgIHVuc2lnbmVk IGxvbmcgaTsKPiArCj4gKyAgICAvKiBEbyBub3RoaW5nIGlmIGhhcmR3YXJlIGRvbWFpbiBhbmQg aW9tbXUgc3VwcG9ydHMgcGFzcyB0aHJ1LiAqLwo+ICsgICAgaWYgKCBpb21tdV9wYXNzdGhyb3Vn aCAmJiBpc19oYXJkd2FyZV9kb21haW4oZCkgKQo+ICsgICAgICAgIHJldHVybiAwOwo+Cj4gLSAg ICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgb3JkZXIpOyBpKysgKQo+ICsgICAgZm9yICggaSA9 IDA7IGkgPCAoMVVMIDw8IG9yZGVyKTsgaSsrLCBnZm4rKyApCj4gICAgICB7Cj4gLSAgICAgICAg aW50IHJldCA9IGludGVsX2lvbW11X3VubWFwX3BhZ2UoZCwgZ2ZuICsgaSk7Cj4gKyAgICAgICAg aW50IHJldCA9IGRtYV9wdGVfY2xlYXJfb25lKGQsIChwYWRkcl90KWdmbiA8PCBQQUdFX1NISUZU XzRLKTsKPiArCj4gICAgICAgICAgaWYgKCAhcmMgKQo+ICAgICAgICAgICAgICByYyA9IHJldDsK PiAgICAgIH0KPiAtLQo+IDIuNy40Cj4KCgoKLS0gClJlZ2FyZHMsCgpPbGVrc2FuZHIgVHlzaGNo ZW5rbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3Rz Lnhlbi5vcmcveGVuLWRldmVsCg==