From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH v2 08/13] iommu/arm: Misc fixes for arch specific part
Date: Thu, 3 Aug 2017 15:34:48 +0300 [thread overview]
Message-ID: <CAPD2p-nbA7a525BLG-nAL9EDp1jvz58mYhQRSkfAmhCw3B4a1Q@mail.gmail.com> (raw)
In-Reply-To: <4233ceae-6f7f-d4d5-0159-95462b2eb9a6@arm.com>
Hi, Julien
On Thu, Aug 3, 2017 at 2:31 PM, Julien Grall <julien.grall@arm.com> wrote:
> Hi Oleksandr,
>
> On 25/07/17 18:26, Oleksandr Tyshchenko wrote:
>>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> 1. Add missing return in case if IOMMU ops have been already set.
>> 2. Add check for shared IOMMU before returning an error.
>
>
> Technically 1. is a fix, 2. is a new feature as sharing IOMMU is not
> supported today. I am ok for you to keep both in the same patch this time,
> but in the future please avoid mixing fixes and new feature.
ok
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
Thank you!
>
> Cheers,
>
> --
> Julien Grall
--
Regards,
Oleksandr Tyshchenko
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-03 12:34 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 17:26 [PATCH v2 00/13] "Non-shared" IOMMU support on ARM Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 01/13] xen/device-tree: Add dt_count_phandle_with_args helper Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 02/13] iommu: Add extra order argument to the IOMMU APIs and platform callbacks Oleksandr Tyshchenko
2017-08-03 11:21 ` Julien Grall
2017-08-03 12:32 ` Oleksandr Tyshchenko
2017-08-21 16:20 ` Oleksandr Tyshchenko
2017-08-22 7:21 ` Jan Beulich
2017-08-22 10:28 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 03/13] xen/arm: p2m: Add helper to convert p2m type to IOMMU flags Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 04/13] xen/arm: p2m: Update IOMMU mapping whenever possible if page table is not shared Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 05/13] iommu/arm: Re-define iommu_use_hap_pt(d) as iommu_hap_pt_share Oleksandr Tyshchenko
2017-08-03 11:23 ` Julien Grall
2017-08-03 12:33 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 06/13] iommu: Add extra use_iommu argument to iommu_domain_init() Oleksandr Tyshchenko
2017-08-21 16:29 ` Oleksandr Tyshchenko
2017-12-06 16:51 ` Jan Beulich
2017-12-06 19:53 ` Oleksandr Tyshchenko
2017-12-06 22:49 ` Julien Grall
2017-12-07 12:08 ` Oleksandr Tyshchenko
2017-12-07 12:51 ` Jan Beulich
2017-07-25 17:26 ` [PATCH v2 07/13] iommu: Make decision about needing IOMMU for hardware domains in advance Oleksandr Tyshchenko
2017-08-21 16:30 ` Oleksandr Tyshchenko
2017-12-06 17:01 ` Jan Beulich
2017-12-06 19:23 ` Oleksandr Tyshchenko
2017-12-07 8:57 ` Jan Beulich
2017-12-07 13:50 ` Oleksandr Tyshchenko
2017-12-07 13:57 ` Jan Beulich
2017-12-08 12:28 ` Oleksandr Tyshchenko
2018-01-18 12:09 ` Roger Pau Monné
2018-01-18 14:50 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 08/13] iommu/arm: Misc fixes for arch specific part Oleksandr Tyshchenko
2017-08-03 11:31 ` Julien Grall
2017-08-03 12:34 ` Oleksandr Tyshchenko [this message]
2017-07-25 17:26 ` [PATCH v2 09/13] xen/arm: Add use_iommu flag to xen_arch_domainconfig Oleksandr Tyshchenko
2017-07-28 16:16 ` Wei Liu
2017-07-28 16:30 ` Oleksandr Tyshchenko
2017-08-03 11:33 ` Julien Grall
2017-08-03 12:31 ` Oleksandr Tyshchenko
2017-08-03 12:35 ` Julien Grall
2017-07-25 17:26 ` [PATCH v2 10/13] xen/arm: domain_build: Don't expose IOMMU specific properties to the guest Oleksandr Tyshchenko
2017-08-03 11:37 ` Julien Grall
2017-08-03 13:24 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 11/13] iommu/arm: smmu: Squash map_pages/unmap_pages with map_page/unmap_page Oleksandr Tyshchenko
2017-08-03 12:36 ` Julien Grall
2017-08-03 13:26 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 12/13] [RFC] iommu: VT-d: " Oleksandr Tyshchenko
2017-08-21 16:44 ` Oleksandr Tyshchenko
2017-09-12 14:44 ` Oleksandr Tyshchenko
2017-09-20 8:54 ` Tian, Kevin
2017-09-20 18:23 ` Oleksandr Tyshchenko
2017-07-25 17:26 ` [PATCH v2 13/13] [RFC] iommu: AMD-Vi: " Oleksandr Tyshchenko
2017-08-21 16:44 ` Oleksandr Tyshchenko
2017-09-12 14:45 ` Oleksandr Tyshchenko
2017-07-31 5:57 ` [PATCH v2 00/13] "Non-shared" IOMMU support on ARM Tian, Kevin
2017-07-31 11:57 ` Oleksandr Tyshchenko
2017-08-01 3:06 ` Tian, Kevin
2017-08-01 11:08 ` Oleksandr Tyshchenko
2017-08-02 6:12 ` Tian, Kevin
2017-08-02 17:47 ` Oleksandr Tyshchenko
2017-08-01 18:09 ` Julien Grall
2017-08-01 18:20 ` Oleksandr Tyshchenko
2017-08-01 17:56 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPD2p-nbA7a525BLG-nAL9EDp1jvz58mYhQRSkfAmhCw3B4a1Q@mail.gmail.com \
--to=olekstysh@gmail.com \
--cc=julien.grall@arm.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.