From: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com> To: "Tobin C. Harding" <me@tobin.cc> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>, linux-kernel <linux-kernel@vger.kernel.org>, kernel-hardening@lists.openwall.com Subject: Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses Date: Mon, 4 Dec 2017 10:51:53 +0530 [thread overview] Message-ID: <CAPDLWs-BFQ+NF15ntxFNS4MT2kVs+k9BUYreDZeYEP1sFLQJ+w@mail.gmail.com> (raw) In-Reply-To: <CAPDLWs8biiKptmmYj45mrc+KWrV93JNQP5eLHcgTGznMj_yBow@mail.gmail.com> > On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding <me@tobin.cc> wrote: >> >> > With the 'eval', no warning, it's fine. >> >> Why not use hex()? > >> > >> > foreach my $config_file (@config_files) { >> > + $config_file =~ s/\R*//g; >> >> Is there some reason you don't use chomp()? > Wrt your suggestions: --- diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 9906dcf8b807..260b52e456f1 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -266,7 +266,7 @@ sub is_false_positive sub is_false_positive_ix86_32 { my ($match) = @_; - state $page_offset = eval get_page_offset(); # only gets called once + state $page_offset = hex get_page_offset(); # only gets called once if ($match =~ '\b(0x)?(f|F){8}\b') { return 1; @@ -313,7 +313,7 @@ sub get_page_offset } foreach my $config_file (@config_files) { - $config_file =~ s/\R*//g; + chomp $config_file; $page_offset = parse_kernel_config_file($config_file); if ($page_offset ne "") { return $page_offset; Thanks & Regards, Kaiwan.
WARNING: multiple messages have this Message-ID (diff)
From: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com> To: "Tobin C. Harding" <me@tobin.cc> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>, linux-kernel <linux-kernel@vger.kernel.org>, kernel-hardening@lists.openwall.com Subject: [kernel-hardening] Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses Date: Mon, 4 Dec 2017 10:51:53 +0530 [thread overview] Message-ID: <CAPDLWs-BFQ+NF15ntxFNS4MT2kVs+k9BUYreDZeYEP1sFLQJ+w@mail.gmail.com> (raw) In-Reply-To: <CAPDLWs8biiKptmmYj45mrc+KWrV93JNQP5eLHcgTGznMj_yBow@mail.gmail.com> > On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding <me@tobin.cc> wrote: >> >> > With the 'eval', no warning, it's fine. >> >> Why not use hex()? > >> > >> > foreach my $config_file (@config_files) { >> > + $config_file =~ s/\R*//g; >> >> Is there some reason you don't use chomp()? > Wrt your suggestions: --- diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index 9906dcf8b807..260b52e456f1 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -266,7 +266,7 @@ sub is_false_positive sub is_false_positive_ix86_32 { my ($match) = @_; - state $page_offset = eval get_page_offset(); # only gets called once + state $page_offset = hex get_page_offset(); # only gets called once if ($match =~ '\b(0x)?(f|F){8}\b') { return 1; @@ -313,7 +313,7 @@ sub get_page_offset } foreach my $config_file (@config_files) { - $config_file =~ s/\R*//g; + chomp $config_file; $page_offset = parse_kernel_config_file($config_file); if ($page_offset ne "") { return $page_offset; Thanks & Regards, Kaiwan.
next prev parent reply other threads:[~2017-12-04 5:22 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-28 6:32 [PATCH] leaking_addresses: add support for 32-bit kernel addresses Tobin C. Harding 2017-11-28 6:32 ` [kernel-hardening] " Tobin C. Harding 2017-11-28 13:16 ` Alexander Kapshuk 2017-11-28 13:16 ` [kernel-hardening] " Alexander Kapshuk 2017-11-28 21:10 ` Tobin C. Harding 2017-11-28 21:10 ` [kernel-hardening] " Tobin C. Harding 2017-11-29 7:59 ` Alexander Kapshuk 2017-11-29 7:59 ` [kernel-hardening] " Alexander Kapshuk 2017-11-29 10:16 ` Tobin C. Harding 2017-11-29 10:16 ` [kernel-hardening] " Tobin C. Harding 2017-11-29 11:02 ` Kaiwan N Billimoria 2017-11-29 11:02 ` [kernel-hardening] " Kaiwan N Billimoria 2017-11-29 20:48 ` Tobin C. Harding 2017-11-29 20:48 ` [kernel-hardening] " Tobin C. Harding 2017-12-01 13:03 ` Kaiwan N Billimoria 2017-12-01 13:03 ` [kernel-hardening] " Kaiwan N Billimoria 2017-12-01 13:09 ` kaiwan.billimoria 2017-12-01 13:09 ` [kernel-hardening] " kaiwan.billimoria 2017-12-04 0:11 ` Tobin C. Harding 2017-12-04 0:11 ` [kernel-hardening] " Tobin C. Harding 2017-12-04 4:41 ` kaiwan.billimoria 2017-12-04 4:41 ` [kernel-hardening] " kaiwan.billimoria 2017-12-04 4:55 ` Tobin C. Harding 2017-12-04 4:55 ` [kernel-hardening] " Tobin C. Harding 2017-12-04 5:09 ` Kaiwan N Billimoria 2017-12-04 5:09 ` [kernel-hardening] " Kaiwan N Billimoria 2017-12-04 5:21 ` Kaiwan N Billimoria [this message] 2017-12-04 5:21 ` Kaiwan N Billimoria 2017-12-04 8:21 ` Tobin C. Harding 2017-12-04 8:21 ` [kernel-hardening] " Tobin C. Harding 2017-12-04 10:20 ` kaiwan.billimoria 2017-12-04 10:20 ` [kernel-hardening] " kaiwan.billimoria 2017-12-04 12:37 ` Alexander Kapshuk 2017-12-04 12:37 ` [kernel-hardening] " Alexander Kapshuk 2017-12-04 13:28 ` Kaiwan N Billimoria 2017-12-04 14:08 ` Kaiwan N Billimoria 2017-12-04 14:08 ` [kernel-hardening] " Kaiwan N Billimoria 2017-12-04 20:59 ` Tobin C. Harding 2017-12-04 20:59 ` [kernel-hardening] " Tobin C. Harding 2017-11-29 11:30 ` Alexander Kapshuk 2017-11-29 11:30 ` [kernel-hardening] " Alexander Kapshuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPDLWs-BFQ+NF15ntxFNS4MT2kVs+k9BUYreDZeYEP1sFLQJ+w@mail.gmail.com \ --to=kaiwan.billimoria@gmail.com \ --cc=alexander.kapshuk@gmail.com \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-kernel@vger.kernel.org \ --cc=me@tobin.cc \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.