From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCACC35242 for ; Fri, 24 Jan 2020 13:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7449A2077C for ; Fri, 24 Jan 2020 13:20:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gins8z7J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389492AbgAXNUS (ORCPT ); Fri, 24 Jan 2020 08:20:18 -0500 Received: from mail-vs1-f65.google.com ([209.85.217.65]:41454 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387897AbgAXNUS (ORCPT ); Fri, 24 Jan 2020 08:20:18 -0500 Received: by mail-vs1-f65.google.com with SMTP id k188so1161596vsc.8 for ; Fri, 24 Jan 2020 05:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=gins8z7JzejJQal9gDEbPpdg5XvecgftPkBOzZDn61Udldh3usgTviD1RSeTs/khVg P6QL2wdgjepWpZPu2K07a0Gi2j30WxCH8luSM9XeXKn2a0tOlWNsCiBvesNyFuoRTa2l l+vIULJyGGwlTBlM48w/mQcMBP9WP2/M/8BvfKaietFwyHD4quO4EfSzZuZDebmtJUKO N78p+V3i2PTQYXQaBm9DxrHQdcBOrL5nyx5ZvfkLk7TND7MMNM/kXvpRBQCuqtQn+Mxh S+P6c2mXdalbk8iIrd+uIIUDrn+lJsAfuy8AVqcNxmXZb29qZ7+MytSuK9cABHt20/c6 vbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=O5syL5fhov0OmTX1DCUapUoxlYe7Gaa7DJFoNt7RSApU9DSQi168T943cskmPT3bZ1 /tUl+WvKjdYH5D3h1MmiUSlGNnE830aZRz4RwlC2qx0bEcTtOPCSfF9kqL28McFHq+yF IdhMHUzRUhx+UiIOe4UknsB+ezDZ4RrXH93HJJGf62MHQeMjd2YTXNdcx7n8E+YCD4QD WkYfb+vKPLurxqojNwYQYzX2IWpcv6J4hqX4QDEVt4+z0NKtksO5DhwfY3MqFnus8dwG LaV9OP+b8bOpuS4NUOKE78BUoskajC4rg9y4+ZZ4Cn67D/l4GQAhUqj5VWySACVyfb/x /wOw== X-Gm-Message-State: APjAAAWQoFUFaRk8OJta+uTGG2JKZYjNbJa7V/OKnVKZhnx9eTTT4EMj MOz1nem+urjWU4CEIjppJTu/BrqeMWpYDAVqK+D/sIaM X-Google-Smtp-Source: APXvYqwPiZbZvXR+rHIvNUYilWv/U2EOOXMt8apmM26fWaq/fAZpxuaFlhAeSj98ruAwNOVdB6HsKU61mDEy2b2ThPA= X-Received: by 2002:a67:cc3:: with SMTP id 186mr2203033vsm.200.1579872016966; Fri, 24 Jan 2020 05:20:16 -0800 (PST) MIME-Version: 1.0 References: <20200110134823.14882-1-ludovic.barre@st.com> <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> In-Reply-To: <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> From: Ulf Hansson Date: Fri, 24 Jan 2020 14:19:40 +0100 Message-ID: Subject: Re: [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support To: Ludovic BARRE Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE wrote: > > hi Ulf > > Just a "gentleman ping" on this series > https://lkml.org/lkml/2020/1/10/392 I was just reviewing :-) Thanks for pinging! One overall comment is that I think you can try to work a bit on the changelogs. In some cases you described what the patch does, which is good, but it may lack information about *why* the change is wanted. Overall, the series looks nice. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA05C2D0DB for ; Fri, 24 Jan 2020 13:20:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A605920718 for ; Fri, 24 Jan 2020 13:20:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qq73s8GZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gins8z7J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A605920718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3o8LVvGywNZlFJahw0ccJ4b+YNUCWiSZkQIy6UnNoGE=; b=qq73s8GZsmmMTH 8fcndUJRImWyY3qdRbhcD6kEjm8BSiNFrHKgou3ZNxFncF3VNbaGc8UzZNzQrzKeCQ260NY9xiJx4 r5sm1jp8Bj4NDtZVdPT3eJb4JQiRj7c7T9S9LvqJp3O/X6Pqr3fqE3dxRTjaGzXeHfvZj28Q3WZtB m20tovH+UbBbmGw+W3QNbtEqRHm6RT90mrWktV9Y00yH08/EYiQsT8rnfaU1m0RF/gBxAh12z5FKd LYnvrK13f0IHvZX2u6kRUBbmwyuzw/ZY5vuSvSOOoogMXo2iVHjdoiSP3DUJn3KEd1kSq+HQg/udG hXmH4ynPL5XUuXjvnLSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuysr-00039M-Cg; Fri, 24 Jan 2020 13:20:25 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuysk-00032Q-6A for linux-arm-kernel@lists.infradead.org; Fri, 24 Jan 2020 13:20:19 +0000 Received: by mail-vs1-xe43.google.com with SMTP id g15so1192256vsf.1 for ; Fri, 24 Jan 2020 05:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=gins8z7JzejJQal9gDEbPpdg5XvecgftPkBOzZDn61Udldh3usgTviD1RSeTs/khVg P6QL2wdgjepWpZPu2K07a0Gi2j30WxCH8luSM9XeXKn2a0tOlWNsCiBvesNyFuoRTa2l l+vIULJyGGwlTBlM48w/mQcMBP9WP2/M/8BvfKaietFwyHD4quO4EfSzZuZDebmtJUKO N78p+V3i2PTQYXQaBm9DxrHQdcBOrL5nyx5ZvfkLk7TND7MMNM/kXvpRBQCuqtQn+Mxh S+P6c2mXdalbk8iIrd+uIIUDrn+lJsAfuy8AVqcNxmXZb29qZ7+MytSuK9cABHt20/c6 vbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t65RoraJ97XSNifH3nJWhcpZY1lN6qjNaU0+rNtB6VA=; b=mfpVdzYR1UhymOT2jWSbY74swOw8BxYTGNFNEVlAezx7PcmY7JwD3yG6hU3tFlSq9A ciED276Ppk6NGRfeGiI1rTSsoPVFBWr/mEl38Ht2qNWkOKWFwgBoowFR4QNY30Ge4VPs 77WPslFb4AFmtlnWllv2+3ffCD1LdMO5K9//5O9T/94xhgcEgP3AGsChhuKXohQNpnM5 PYOA2uaJQR38mdKb/yFosKmRvnP1F1k7rdUDAcH1q9+t0BZ1X91kouPRVRjfFOWA0d+n mn//mDaipm9T1IzXHXUU7YvILujK4N4Kp20MPbTlxtdIeX3CYG+braLc4OC5MVMl0K+K TwVg== X-Gm-Message-State: APjAAAUFMnyfcOZ6VGUGVa/cBneyI5BXQBUIcSa5B78VJLXApdc0crVb zi1yuFRlVk78KOTOyNttANmk/ZyYHfQ4o4Rirb9oYA== X-Google-Smtp-Source: APXvYqwPiZbZvXR+rHIvNUYilWv/U2EOOXMt8apmM26fWaq/fAZpxuaFlhAeSj98ruAwNOVdB6HsKU61mDEy2b2ThPA= X-Received: by 2002:a67:cc3:: with SMTP id 186mr2203033vsm.200.1579872016966; Fri, 24 Jan 2020 05:20:16 -0800 (PST) MIME-Version: 1.0 References: <20200110134823.14882-1-ludovic.barre@st.com> <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> In-Reply-To: <6d859def-351e-abd7-0d5f-962ad935dff2@st.com> From: Ulf Hansson Date: Fri, 24 Jan 2020 14:19:40 +0100 Message-ID: Subject: Re: [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support To: Ludovic BARRE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200124_052018_285682_13D37451 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Alexandre Torgue , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Rob Herring , Srinivas Kandagatla , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE wrote: > > hi Ulf > > Just a "gentleman ping" on this series > https://lkml.org/lkml/2020/1/10/392 I was just reviewing :-) Thanks for pinging! One overall comment is that I think you can try to work a bit on the changelogs. In some cases you described what the patch does, which is good, but it may lack information about *why* the change is wanted. Overall, the series looks nice. Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel