From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f53.google.com ([209.85.214.53]:45336 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbdLLOU6 (ORCPT ); Tue, 12 Dec 2017 09:20:58 -0500 Received: by mail-it0-f53.google.com with SMTP id z6so24867465iti.4 for ; Tue, 12 Dec 2017 06:20:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1510588003-16650-1-git-send-email-ulf.hansson@linaro.org> <1510588003-16650-3-git-send-email-ulf.hansson@linaro.org> <1926914.PsNMcYBlGW@aspire.rjw.lan> From: Ulf Hansson Date: Tue, 12 Dec 2017 15:20:56 +0100 Message-ID: Subject: Re: [PATCH v2 2/3] PM / core: Add IN_BAND_WAKEUP driver flag To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Linux PM list , Kevin Hilman , Viresh Kumar , Geert Uytterhoeven , Simon Horman , Niklas Soderlund , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 12 December 2017 at 09:16, Geert Uytterhoeven wrote: > Hi Ulf, > > On Mon, Dec 11, 2017 at 9:59 PM, Ulf Hansson wrote: >> That together with an option of allowing "consumed resource-devices" >> (irqchip) to be included in the wakeup path. I am thinking, perhaps >> another driver PM flag (DPM_FLAG_WAKEUP_PATH), that the PM core looks >> at and sets ->power.wakeup_path flag for the device and its parents. > > This is complicated by the fact that currently the device and irq > subsystems don't really share data. E.g. {en,dis}able_irq_wake() and > irq_set_irq_wake() don't take a device parameter, only an interrupt number, > and conversion from interrupt numbers to devices is non-trivial. > That's why I handled it in the irqchip drivers in the series referenced > below. Yes, that seems like a good way forward for now. We can always look into how to extend the irq subsystem to deal with this internally, but I rather leave that to be done as a separate task. [...] Kind regards Uffe