From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1C7C433DB for ; Wed, 20 Jan 2021 17:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8452E20705 for ; Wed, 20 Jan 2021 17:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbhATRck (ORCPT ); Wed, 20 Jan 2021 12:32:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390167AbhATOJG (ORCPT ); Wed, 20 Jan 2021 09:09:06 -0500 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A671C0613C1 for ; Wed, 20 Jan 2021 06:08:26 -0800 (PST) Received: by mail-vs1-xe33.google.com with SMTP id s2so13107578vsk.2 for ; Wed, 20 Jan 2021 06:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TYF+Zz7wUDX6tFLm0vugTznzEeL36B9hGlq5J1Mejos=; b=bB6s6Snu7BEd0g7q3kNiWIUMDzZs6R2ihemuVSpA9OHoV7py5zzTe4td1pxZvg3iQO wAvWas1umsFvU4xr5zAGltp/VYDIu+HhKxXmeUPQgRAd9SQTXdcu/02hqNzN34jmFdi8 aJCNHGHND1ZhUOqZN/XZguJLR1Le7SQL47N84pRUJ+uUDhITBA30LKod3lyniRsc8ghi y50gZvUmYm/LAgFgJzkaTx0UdX128J0STq8V7C5pIJgJuSmPyvbys9iDtc1Y7QkYSJZu mkZwdTYxZoDWN8KFkTG2RhYmc9M77zCkPYKv+h3EQ4oxPbDffVATGuNF/HiSHxJVelQ6 W7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TYF+Zz7wUDX6tFLm0vugTznzEeL36B9hGlq5J1Mejos=; b=pvhPgVAF9hdmSxcTTkw9TewtcgKG0freahNrBJl/6RtYvb/6XjLN/zV1KwMeQXwQlx /EHHqbpPj87vRLinmQ9oxsvjaK4FHNsmDy9FmjG46lx/uparDNPd5e+PNJZKEGKlxAqM T083FR5lJipicDWEJ+bmsbdG9YOXYfegN4ODbDZfNntu8G02fC0OwMI0CH6t/FxGLwnr SEXoh3CLPVTUtrFZZ/lMEaLrIudKmr6llB2p0Z6MVsfN0Zy7KKYdO5DEvrO7aUDJtXMa UuKR093h2D2zLN9hK3TUIzIgC4Cf1XSKrJhM4zZxhwt3AbtZIRth63TQrPs3UjsYT0go KEWg== X-Gm-Message-State: AOAM532ZYbrFYlv8t/NABZw+jml4i9Jhdo8FfgIaTVjRgL348pVdzcMb WW5T0XqZ53jNmr7qwiCX0z0E4LQTTPuVfMi57EIRLQ== X-Google-Smtp-Source: ABdhPJzPT+5m2Uip2x9vfp7pBlxYZltKseMVwidfWwS9EYIZPJvzKkNBcaq7Pw/ew0QC+G0QrPPNK7NoCik1XvhD4+Y= X-Received: by 2002:a67:facb:: with SMTP id g11mr6768555vsq.19.1611151705806; Wed, 20 Jan 2021 06:08:25 -0800 (PST) MIME-Version: 1.0 References: <20210119051425.305-1-zbestahu@gmail.com> In-Reply-To: <20210119051425.305-1-zbestahu@gmail.com> From: Ulf Hansson Date: Wed, 20 Jan 2021 15:07:48 +0100 Message-ID: Subject: Re: [PATCH] mmc: test: remove the shutdown function To: Yue Hu Cc: "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Yue Hu , zbestahu@163.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan 2021 at 06:14, Yue Hu wrote: > > From: Yue Hu > > Since it's doing nothing for shutdown behavior. And the callback will > be checked firstly in mmc_bus_shutdown(). > > Signed-off-by: Yue Hu Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/core/mmc_test.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 152e752..f999b48 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -3267,17 +3267,12 @@ static void mmc_test_remove(struct mmc_card *card) > mmc_test_free_dbgfs_file(card); > } > > -static void mmc_test_shutdown(struct mmc_card *card) > -{ > -} > - > static struct mmc_driver mmc_driver = { > .drv = { > .name = "mmc_test", > }, > .probe = mmc_test_probe, > .remove = mmc_test_remove, > - .shutdown = mmc_test_shutdown, > }; > > static int __init mmc_test_init(void) > -- > 1.9.1 >