From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1062BC10F27 for ; Wed, 11 Mar 2020 14:21:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9F5224081 for ; Wed, 11 Mar 2020 14:21:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gkc0L1z8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729812AbgCKOVh (ORCPT ); Wed, 11 Mar 2020 10:21:37 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:34024 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729584AbgCKOVh (ORCPT ); Wed, 11 Mar 2020 10:21:37 -0400 Received: by mail-vs1-f68.google.com with SMTP id t10so1434206vsp.1 for ; Wed, 11 Mar 2020 07:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=Gkc0L1z8chPU37ylfxfld8kL1758g6oY0Td7cWlPBhRSaljv0nEP9i+wF1FJLm0Drg 7zQLQnQGtshFfkBxcXQOD8UJjfPEBJlxiQbOQQRDjlQyYcs4GHopCD3WQpPexAJCvhto 8XN93qTBP25DLXymYoqMYfRDFiCDl00Tu7l7HwjPGS2KJhr2hl68CUYN42965CRUP9pQ ZDPNq0D/OlBZjkMIJz112kgpsvq2mG8Y0bHAG6O4T5kI9wyjM5tx9FQxhltw0y0ATKH4 ttb7rdiO3me+gomGLr9dPZ6NNBAkBHLub4H4YSPSffAKhD/PJ/7fQfqhDsJtoj4Mb2vw xi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=Q1eJ4oiRAr7zKxXdybM0zvlmPQc7NMBd/a7waeDQxZXbkqOu1t9HbwooP5RkmHMvts /j/HS6JtGNqyNvDPWpOKNlZMnKniqED4QiWi4jPkpb1jp4cOd9mo+EJ87RyaqXw/jeYN QIfAHGWHy7j6d+PyjuweI/aTg9oOPjkJtuMV5xezt0cqvh8ujW9A1vm1cXh8ElxE1+pn Bo1YIkyQEAhTyWA3YkHIgJPUQ/SjO38hnSmdZK+DwU8+tpRzpr5VxazFGQrNqSsu+Fhh MB5n1LpgOeH/Kh70+p8tnIyvaeytbdjvn9PRF8vhNwiYgYkPB5Hgo68k/yZU/C5XmhwN IVcg== X-Gm-Message-State: ANhLgQ3zGPPIMPJLRPJ5KIv90eG6WlEOe8D8Cpk8Aq/In0qUjRf1eM1Y kYEof7Vb4EfCQyx9tDBLMfnC4nAOsi0d76oLFofN1Q== X-Google-Smtp-Source: ADFU+vvAwSiaVqdqSV80/n9skavFztB4aCTDjE1foC884CVvIqJg8m9aPx1YictIGAray0JPA7so3t3+znzsKWxY1WY= X-Received: by 2002:a05:6102:2051:: with SMTP id q17mr2225224vsr.165.1583936495390; Wed, 11 Mar 2020 07:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20200311084052.3ca3c331@xps13> In-Reply-To: <20200311084052.3ca3c331@xps13> From: Ulf Hansson Date: Wed, 11 Mar 2020 15:20:59 +0100 Message-ID: Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; To: Miquel Raynal , Joe Perches Cc: Paul Cercueil , Harvey Hunt , David Airlie , Daniel Vetter , Richard Weinberger , Vignesh Raghavendra , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , dri-devel , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , linux-mtd@lists.infradead.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2020 at 08:40, Miquel Raynal wrote: > > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > Hope you'll understand! I fully agree (for mmc). One patch please. Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7EEC10F27 for ; Wed, 11 Mar 2020 14:22:35 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FB3A23A45 for ; Wed, 11 Mar 2020 14:22:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ODzzvflA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gkc0L1z8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FB3A23A45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E564983A; Wed, 11 Mar 2020 15:21:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E564983A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583936553; bh=x0rkzHKVCO4/4BCh3NikI3YFRku7HPCiwGonVS7gOis=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ODzzvflADtD5QtcaJRepV45MX3rffJP8Snh//qjrYlxZizxLwLZF5B2J9JKUO2N9E Szsq49f/8rb6DZhtGYvy+lAGO6CGloT2HQDs4lr024s1a8rAV+6qDIvXNSscS4Wr8p 86ofk1/9ejScJ/60kEUldRE8J/fvuxlptqD4W+Ak= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6DF4DF80141; Wed, 11 Mar 2020 15:21:42 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 316D0F801EB; Wed, 11 Mar 2020 15:21:40 +0100 (CET) Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5E3EAF80141 for ; Wed, 11 Mar 2020 15:21:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5E3EAF80141 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gkc0L1z8" Received: by mail-vs1-xe43.google.com with SMTP id u24so1407181vso.11 for ; Wed, 11 Mar 2020 07:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=Gkc0L1z8chPU37ylfxfld8kL1758g6oY0Td7cWlPBhRSaljv0nEP9i+wF1FJLm0Drg 7zQLQnQGtshFfkBxcXQOD8UJjfPEBJlxiQbOQQRDjlQyYcs4GHopCD3WQpPexAJCvhto 8XN93qTBP25DLXymYoqMYfRDFiCDl00Tu7l7HwjPGS2KJhr2hl68CUYN42965CRUP9pQ ZDPNq0D/OlBZjkMIJz112kgpsvq2mG8Y0bHAG6O4T5kI9wyjM5tx9FQxhltw0y0ATKH4 ttb7rdiO3me+gomGLr9dPZ6NNBAkBHLub4H4YSPSffAKhD/PJ/7fQfqhDsJtoj4Mb2vw xi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=k1TVVmaOj9MaaQBLktmKXqOddHAXV6Iz7iEpRsXYj/cuzVuyOqWTtP1dXgH9xBN22T H+DyC8Ep53o/gPpCszmaM0tVwr0LE05o7UFv+8Z5YFS/jTbLe3YQWA818BmsHDIjXO/x aj6CvENosCpmfsniXdXpFFvCeLwg8pL/1VqFV5Ihx0qlzTjdiH9lVZ8eYloj7jCyCQvr cQFcprtyzgKRf27yVJfdOPgT98m50pmTdx0tMwNypDAQmU4JVI20gNeAE/69oOPaDGGM IwJpEXHu9O8eYXCIF4d89ZkQpaR1P87oVRdpVeVM0JCkYTPM5WX1rOf37DiisjChthMN ketw== X-Gm-Message-State: ANhLgQ3srAIOfTDWlOBshTYB/nFcjHdDDt2klIfMsUz9XFpeosjEuzDc lgQU4jHNdqK6lGi5blbOrVc36kKEqBQdaScMsss/lA== X-Google-Smtp-Source: ADFU+vvAwSiaVqdqSV80/n9skavFztB4aCTDjE1foC884CVvIqJg8m9aPx1YictIGAray0JPA7so3t3+znzsKWxY1WY= X-Received: by 2002:a05:6102:2051:: with SMTP id q17mr2225224vsr.165.1583936495390; Wed, 11 Mar 2020 07:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20200311084052.3ca3c331@xps13> In-Reply-To: <20200311084052.3ca3c331@xps13> From: Ulf Hansson Date: Wed, 11 Mar 2020 15:20:59 +0100 Message-ID: Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; To: Miquel Raynal , Joe Perches Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, Vignesh Raghavendra , David Airlie , Richard Weinberger , Mark Brown , Takashi Iwai , "linux-mmc@vger.kernel.org" , Liam Girdwood , dri-devel , Paul Cercueil , Harvey Hunt , linux-mtd@lists.infradead.org, Daniel Vetter , Linux Kernel Mailing List X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 11 Mar 2020 at 08:40, Miquel Raynal wrote: > > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > Hope you'll understand! I fully agree (for mmc). One patch please. Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D38C10F27 for ; Wed, 11 Mar 2020 14:22:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A42321313 for ; Wed, 11 Mar 2020 14:22:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LA8qixKR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gkc0L1z8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A42321313 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3VuYs9cToVzo47dCN9DsbiGdtOmDdQ6UYfhTVk+TVsQ=; b=LA8qixKR/tZA1W 0bG5PWZuoHaGnUw3z5DuAgIAKsISKJGj5dPgaucmRU6TNOcYlXmjFLCiLQYirWmEUR322uHZOzNwx rtTYiBxvL/R+nbrV23TbcaHkOtxPcsjIB3RmzCTj7mrVQzcgW/+f3VIXPCVjzBeHZWbYwlVbLcR17 Ufpj78TTMY5seIpHSGwxjcXkTZ29rz71jrKtyEq08ZHGV6oA6S7OVuu0osCllYWwmtBdx6w8+nBgG KjKQ0fOsEc3nh1HhFeRbDTfLoW1jCDoYvQNa3T2G+bMJ1cQ81PKrsIH53ETjSJN+c5GZ3Oec8qRBm ER9RXhVGbFAncOmmjz9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2Ev-00022G-0D; Wed, 11 Mar 2020 14:21:41 +0000 Received: from mail-vs1-xe43.google.com ([2607:f8b0:4864:20::e43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2Es-00021M-Gd for linux-mtd@lists.infradead.org; Wed, 11 Mar 2020 14:21:40 +0000 Received: by mail-vs1-xe43.google.com with SMTP id i25so1413445vsq.9 for ; Wed, 11 Mar 2020 07:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=Gkc0L1z8chPU37ylfxfld8kL1758g6oY0Td7cWlPBhRSaljv0nEP9i+wF1FJLm0Drg 7zQLQnQGtshFfkBxcXQOD8UJjfPEBJlxiQbOQQRDjlQyYcs4GHopCD3WQpPexAJCvhto 8XN93qTBP25DLXymYoqMYfRDFiCDl00Tu7l7HwjPGS2KJhr2hl68CUYN42965CRUP9pQ ZDPNq0D/OlBZjkMIJz112kgpsvq2mG8Y0bHAG6O4T5kI9wyjM5tx9FQxhltw0y0ATKH4 ttb7rdiO3me+gomGLr9dPZ6NNBAkBHLub4H4YSPSffAKhD/PJ/7fQfqhDsJtoj4Mb2vw xi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=eI1KLB/EwzpClUY7pu/vBClowseeLY9x8Zvt9M8MWlPn0FxeWbOjPz7HKh+Xq1FA6O +PC+4Ct+ExY8NjCO98+8ZTJb9yJaw67U3/XlJnmmCz9yEhpC0WywVydaBMI7XuBZrHW8 GZSkVjY/WW8TwXy15m2W1NxvRT7B0SvuYifTs3Wdo3Fbw7z+sF++XZZrHuS51hhzz7UB iTBugp0hRQxTxPowVF92n2HxeXkC/pNavYXQivNfSHEHvoDRfJfED56DyOfBP8ht69la 9K04yVNgXO2CCmNu7ITpAPELvqS9+4NmjDX1C/RSyRaqZjn7g8ZcRe03Palxk2bm+1x3 qobQ== X-Gm-Message-State: ANhLgQ2vZukm2SiwwUXlkP4vPzgN7w8iIlTBdujKDhZzV/4lZI3DxBtG a9CJ3tcPiPVbznYmZ5I1CsITgiZEG3Pka5FKYUKUAA== X-Google-Smtp-Source: ADFU+vvAwSiaVqdqSV80/n9skavFztB4aCTDjE1foC884CVvIqJg8m9aPx1YictIGAray0JPA7so3t3+znzsKWxY1WY= X-Received: by 2002:a05:6102:2051:: with SMTP id q17mr2225224vsr.165.1583936495390; Wed, 11 Mar 2020 07:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20200311084052.3ca3c331@xps13> In-Reply-To: <20200311084052.3ca3c331@xps13> From: Ulf Hansson Date: Wed, 11 Mar 2020 15:20:59 +0100 Message-ID: Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; To: Miquel Raynal , Joe Perches X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_072138_558358_0CA97175 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Vignesh Raghavendra , David Airlie , Richard Weinberger , Mark Brown , Takashi Iwai , "linux-mmc@vger.kernel.org" , Liam Girdwood , dri-devel , Jaroslav Kysela , Paul Cercueil , Harvey Hunt , linux-mtd@lists.infradead.org, Daniel Vetter , Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 11 Mar 2020 at 08:40, Miquel Raynal wrote: > > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > Hope you'll understand! I fully agree (for mmc). One patch please. Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no? Kind regards Uffe ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F25C1975A for ; Thu, 12 Mar 2020 08:10:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D599020650 for ; Thu, 12 Mar 2020 08:10:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gkc0L1z8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D599020650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02DD76EA98; Thu, 12 Mar 2020 08:08:55 +0000 (UTC) Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) by gabe.freedesktop.org (Postfix) with ESMTPS id D16FC6E990 for ; Wed, 11 Mar 2020 14:21:40 +0000 (UTC) Received: by mail-vs1-xe42.google.com with SMTP id o24so1425115vsp.4 for ; Wed, 11 Mar 2020 07:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=Gkc0L1z8chPU37ylfxfld8kL1758g6oY0Td7cWlPBhRSaljv0nEP9i+wF1FJLm0Drg 7zQLQnQGtshFfkBxcXQOD8UJjfPEBJlxiQbOQQRDjlQyYcs4GHopCD3WQpPexAJCvhto 8XN93qTBP25DLXymYoqMYfRDFiCDl00Tu7l7HwjPGS2KJhr2hl68CUYN42965CRUP9pQ ZDPNq0D/OlBZjkMIJz112kgpsvq2mG8Y0bHAG6O4T5kI9wyjM5tx9FQxhltw0y0ATKH4 ttb7rdiO3me+gomGLr9dPZ6NNBAkBHLub4H4YSPSffAKhD/PJ/7fQfqhDsJtoj4Mb2vw xi5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AA36Z3gXSwJUntGmt4TTG30h5qvPXt0r2XDT/8zcsfI=; b=JDOjpf5DS9O2E4A8UpaenwhLjtNg3KWUSmzPoYJmVEzpt+q7oWSX0XEEff9y4ycads DRkdiOQ9rr/mwvNS3N6bdqzWS7z07hNHF0kIXlmJhDOJ6UOWTQsZil4c9IuploJbewdV IrPsf5CwPZS8GBi5m4CmQl7YGp3mwKkSKNkpnCDFlQ0rxqonEWqPp47vw1b/C3oZV7Sq mb1RSemXDLnDaQdBLiW4rTD7gjfWTcatUX3tpKc8kgae3ooTaRStlUV/ul6rfAWjNQ5Q LOso+3inSfaDGLI+QICXZYM+0LAQR764FiK3OuGqE8Myhyy1VgEsgez9v+YCWIqpQvA4 Og5A== X-Gm-Message-State: ANhLgQ3bTqm3ReTNKawpEWUJkgt2aIByXVfNl0ldfu69hfPLEMoWm562 bwoSqdixF7o4pYvPF1n7Dk0wgppttnTeYyuLNi7zBQ== X-Google-Smtp-Source: ADFU+vvAwSiaVqdqSV80/n9skavFztB4aCTDjE1foC884CVvIqJg8m9aPx1YictIGAray0JPA7so3t3+znzsKWxY1WY= X-Received: by 2002:a05:6102:2051:: with SMTP id q17mr2225224vsr.165.1583936495390; Wed, 11 Mar 2020 07:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20200311084052.3ca3c331@xps13> In-Reply-To: <20200311084052.3ca3c331@xps13> From: Ulf Hansson Date: Wed, 11 Mar 2020 15:20:59 +0100 Message-ID: Subject: Re: [PATCH -next 013/491] INGENIC JZ47xx SoCs: Use fallthrough; To: Miquel Raynal , Joe Perches X-Mailman-Approved-At: Thu, 12 Mar 2020 08:08:13 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Vignesh Raghavendra , David Airlie , Richard Weinberger , Mark Brown , Takashi Iwai , "linux-mmc@vger.kernel.org" , Liam Girdwood , dri-devel , Jaroslav Kysela , Paul Cercueil , Harvey Hunt , linux-mtd@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 11 Mar 2020 at 08:40, Miquel Raynal wrote: > > Hi Joe, > > Joe Perches wrote on Tue, 10 Mar 2020 21:51:27 -0700: > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- > > drivers/mmc/host/jz4740_mmc.c | 6 ++---- > > drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- > > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c | 4 ++-- > > drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++-- > > sound/soc/codecs/jz4770.c | 2 +- > > 6 files changed, 9 insertions(+), 11 deletions(-) > > I like very much the new way to advertise for fallthrough statements, > but I am not willing to take any patch converting a single driver > anymore. I had too many from Gustavo when these comments had to be > inserted. I would really prefer a MTD-wide or a NAND-wide or at least a > raw-NAND-wide single patch (anything inside drivers/mtd/nand/raw/). > > Hope you'll understand! I fully agree (for mmc). One patch please. Another option is to make a big fat tree wide patch and ask Linus if he want to pick up immediately after an rc1. That should cause less disturbance for everyone, no? Kind regards Uffe _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel