From: Ulf Hansson <ulf.hansson@linaro.org>
To: Ben Chuang <benchuanggli@gmail.com>
Cc: adrian.hunter@intel.com, SeanHY.Chen@genesyslogic.com.tw,
ben.chuang@genesyslogic.com.tw, greg.tu@genesyslogic.com.tw,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [RESEND, PATCH] mmc: sdhci-pci-gli: A workaround to allow GL9755 to enter ASPM L1.2
Date: Thu, 21 Apr 2022 15:54:31 +0200 [thread overview]
Message-ID: <CAPDyKFo2YhqgEStGcQb0ZWcuhrUcGeamgHk1Hov6_DzS=TNe3A@mail.gmail.com> (raw)
In-Reply-To: <20220414094945.457500-1-benchuanggli@gmail.com>
On Thu, 14 Apr 2022 at 11:49, Ben Chuang <benchuanggli@gmail.com> wrote:
>
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>
> When GL9755 enters ASPM L1 sub-states, it will stay at L1.1 and will not
> enter L1.2. The workaround is to toggle PM state to allow GL9755 to enter
> ASPM L1.2.
>
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
This didn't apply cleanly, I fixed it up this time. So, applied for
next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 97035d77c18c..52230857388f 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -137,6 +137,9 @@
> #define PCI_GLI_9755_SerDes 0x70
> #define PCI_GLI_9755_SCP_DIS BIT(19)
>
> +#define PCI_GLI_9755_PM_CTRL 0xFC
> +#define PCI_GLI_9755_PM_STATE GENMASK(1, 0)
> +
> #define GLI_MAX_TUNING_LOOP 40
>
> /* Genesys Logic chipset */
> @@ -597,6 +600,13 @@ static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
> GLI_9755_CFG2_L1DLY_VALUE);
> pci_write_config_dword(pdev, PCI_GLI_9755_CFG2, value);
>
> + /* toggle PM state to allow GL9755 to enter ASPM L1.2 */
> + pci_read_config_dword(pdev, PCI_GLI_9755_PM_CTRL, &value);
> + value |= PCI_GLI_9755_PM_STATE;
> + pci_write_config_dword(pdev, PCI_GLI_9755_PM_CTRL, value);
> + value &= ~PCI_GLI_9755_PM_STATE;
> + pci_write_config_dword(pdev, PCI_GLI_9755_PM_CTRL, value);
> +
> gl9755_wt_off(pdev);
> }
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-04-21 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 9:49 [RESEND, PATCH] mmc: sdhci-pci-gli: A workaround to allow GL9755 to enter ASPM L1.2 Ben Chuang
2022-04-19 11:45 ` Adrian Hunter
2022-04-21 13:54 ` Ulf Hansson [this message]
2022-04-25 0:53 ` Ben Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFo2YhqgEStGcQb0ZWcuhrUcGeamgHk1Hov6_DzS=TNe3A@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=SeanHY.Chen@genesyslogic.com.tw \
--cc=adrian.hunter@intel.com \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=greg.tu@genesyslogic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.