From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754703AbdKAOTD (ORCPT ); Wed, 1 Nov 2017 10:19:03 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:57084 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbdKAOTB (ORCPT ); Wed, 1 Nov 2017 10:19:01 -0400 X-Google-Smtp-Source: ABhQp+QBaUpbKAB+hsNQNzDBsDf3awa/lG/+1bHL0PSZmFlkNL8E418/r4vuD4bQJpLJaKPsvLUHbLZxV7TM+850b+k= MIME-Version: 1.0 In-Reply-To: References: <20171012201118.23570-1-dianders@chromium.org> From: Ulf Hansson Date: Wed, 1 Nov 2017 15:18:59 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer To: Doug Anderson Cc: Shawn Lin , Jaehoon Chung , Ziyuan Xu , Alexandru Stan , "open list:ARM/Rockchip SoC..." , Brian Norris , linux-samsung-soc , Emil Renner Berthing , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA1EJDRk003751 On 31 October 2017 at 19:14, Doug Anderson wrote: > Hi, > > On Tue, Oct 31, 2017 at 12:05 AM, Shawn Lin wrote: >> Hi Ulf, >> >> >> On 2017/10/30 19:40, Ulf Hansson wrote: >>> >>> On 12 October 2017 at 22:11, Douglas Anderson >>> wrote: >>>> >>>> Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for >>>> broken command transfer over scheme"). I found a bunch of problems >>>> with that patch, so this series attempts to solve some of them. >>>> >>>> This also fixes the DTO timer in some of the same ways even though I >>>> haven't personally seen problems with the DTO timer. >>>> >>>> NOTE: this series has only been lighly tested so far. I can at least >>>> reproduce the need for the CTO timer on one of my devices and so I can >>>> confirm that part still works. As mentioned in the 3rd patch I also >>>> ran the mmc_test kernel module on this and did manage to see the 3rd >>>> patch doing something useful. >>>> >>>> Changes in v2: >>>> - Removed extra "int i" >>>> - Fix the DTO timeout calculation new for v2 >>>> - Cleanup the DTO timer new for v2 >>>> >>>> Douglas Anderson (5): >>>> mmc: dw_mmc: cancel the CTO timer after a voltage switch >>>> mmc: dw_mmc: Fix the CTO timeout calculation >>>> mmc: dw_mmc: Add locking to the CTO timer >>>> mmc: dw_mmc: Fix the DTO timeout calculation >>>> mmc: dw_mmc: Cleanup the DTO timer like the CTO one >>>> >>>> drivers/mmc/host/dw_mmc.c | 162 >>>> +++++++++++++++++++++++++++++++++++++++++----- >>>> 1 file changed, 146 insertions(+), 16 deletions(-) >>>> >>> >>> Douglas, Jaehoon, >>> >>> I decided to pick patch 1->4 for fixes and the patch 5 for next, that >>> should help us to get them more tested, while Jaehoon is still >>> catching up. >>> >>> I can add ack/drop patches for yet a couple of days this week. >> >> >> Patch 4 introduce a warning: >> >> warning: unused variable ‘irqflags’ [-Wunused-variable] >> >> irqflags should be introduced in patch 5 in the same place. >> As it seems patch 5 will be candidate for 4.15, so could you please >> help fix patch 4 and 5 manually? Or Doug need to resend patch 4 and 5? > > Thanks for catching this and sorry for the dumb screwup. Ulf: I'm > happy to do do whatever makes it easiest for you. If you want me to > re-post it should be very quick. I fixed it myself, by amending the commits, no worries this time! Kind regards Uffe