From: Ulf Hansson <ulf.hansson@linaro.org>
To: Bojan Prtvar <prtvar.b@gmail.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Linus Walleij <linus.walleij@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Gwendal Grignou <gwendal@chromium.org>,
Chaotian Jing <chaotian.jing@mediatek.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: core: Extend sysfs with OCR register
Date: Tue, 12 Jul 2016 11:53:50 +0200 [thread overview]
Message-ID: <CAPDyKFo7wVfRroVLui2b_oUBbMjYGFg8FMMW6vXF3pXtSw1a7Q@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFqTSRupW+qWFWP=5xwQMWU79NFWTxipwButc8D_jFw05g@mail.gmail.com>
On 6 July 2016 at 18:21, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 4 July 2016 at 13:56, Bojan Prtvar <prtvar.b@gmail.com> wrote:
>> Make operation conditions register (OCR) easily accessible from user space.
>>
>> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
>
> Thanks, applied for next! Amended the changelog with the explanation
> why this change is wanted.
I just realized that the OCR register is also available for SD cards.
Could you perhaps cook a patch which adds this to sysfs for SD cards as well!?
Kind regards
Uffe
>
> Kind regards
> Uffe
>
>> ---
>> Documentation/mmc/mmc-dev-attrs.txt | 1 +
>> drivers/mmc/core/mmc.c | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/Documentation/mmc/mmc-dev-attrs.txt b/Documentation/mmc/mmc-dev-attrs.txt
>> index caa5557..8163eca 100644
>> --- a/Documentation/mmc/mmc-dev-attrs.txt
>> +++ b/Documentation/mmc/mmc-dev-attrs.txt
>> @@ -28,6 +28,7 @@ All attributes are read-only.
>> preferred_erase_size Preferred erase size
>> raw_rpmb_size_mult RPMB partition size
>> rel_sectors Reliable write sector count
>> + ocr Operation Conditions Register
>>
>> Note on Erase Size and Preferred Erase Size:
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 5d438ad..1848334 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -727,6 +727,7 @@ MMC_DEV_ATTR(enhanced_area_offset, "%llu\n",
>> MMC_DEV_ATTR(enhanced_area_size, "%u\n", card->ext_csd.enhanced_area_size);
>> MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", card->ext_csd.raw_rpmb_size_mult);
>> MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors);
>> +MMC_DEV_ATTR(ocr, "%08x\n", card->ocr);
>>
>> static ssize_t mmc_fwrev_show(struct device *dev,
>> struct device_attribute *attr,
>> @@ -762,6 +763,7 @@ static struct attribute *mmc_std_attrs[] = {
>> &dev_attr_enhanced_area_size.attr,
>> &dev_attr_raw_rpmb_size_mult.attr,
>> &dev_attr_rel_sectors.attr,
>> + &dev_attr_ocr.attr,
>> NULL,
>> };
>> ATTRIBUTE_GROUPS(mmc_std);
>> --
>> 2.8.0.GIT
>>
next prev parent reply other threads:[~2016-07-12 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 11:56 [PATCH] mmc: core: Extend sysfs with OCR register Bojan Prtvar
2016-07-04 14:13 ` Wolfram Sang
2016-07-04 14:34 ` bojan prtvar
2016-07-04 14:40 ` Wolfram Sang
2016-07-06 16:21 ` Ulf Hansson
2016-07-12 9:53 ` Ulf Hansson [this message]
2016-07-12 12:04 ` bojan prtvar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFo7wVfRroVLui2b_oUBbMjYGFg8FMMW6vXF3pXtSw1a7Q@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=chaotian.jing@mediatek.com \
--cc=corbet@lwn.net \
--cc=gwendal@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prtvar.b@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.