From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h Date: Fri, 20 Jan 2017 09:27:29 +0100 Message-ID: References: <1484313256-25993-1-git-send-email-ulf.hansson@linaro.org> <1484313256-25993-2-git-send-email-ulf.hansson@linaro.org> <87efzydusi.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:38769 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdATI2f (ORCPT ); Fri, 20 Jan 2017 03:28:35 -0500 Received: by mail-wm0-f42.google.com with SMTP id r144so32106020wme.1 for ; Fri, 20 Jan 2017 00:27:31 -0800 (PST) In-Reply-To: <87efzydusi.fsf@belgarion.home> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Robert Jarzmik Cc: "linux-mmc@vger.kernel.org" , Jaehoon Chung , Adrian Hunter , Linus Walleij , Daniel Mack , Haojian Zhuang , "linux-arm-kernel@lists.infradead.org" On 20 January 2017 at 09:01, Robert Jarzmik wrote: > Ulf Hansson writes: > >> Some of the pxa platforms, balloon3, colibri-pxa270-income, corgi, >> trizeps4, vpac270, zeus and zylonite depends on leds.h. Explicitly include >> it instead of relying on the public mmc header host.h. >> >> Cc: Daniel Mack >> Cc: Haojian Zhuang >> Cc: Robert Jarzmik >> Cc: >> Signed-off-by: Ulf Hansson >> --- >> >> I am seeking an ack for this change as following changes for mmc in the >> series, has build-dependencies to it. > Acked-by: Robert Jarzmik > > Actually I already have a patch for arch/arm/mach-pxa/idp.c which adds this > include also in my -next tree, just in case you're tempted to modify this one, > which would conflict with my pxa tree. > > An other point, I checked which files don't have a leds.h : > - grep -ls _led arch/arm/mach-pxa/*.c > /tmp/a > - grep -ls 'linux/leds.h' arch/arm/mach-pxa/*.c > /tmp/b > - sdiff -s /tmp/a /tmp/b > This gives me : > balloon3.c > colibri-pxa270-income.c > corgi.c > corgi_pm.c > em-x270.c > ezx.c > hx4700.c > magician.c > palmld.c > palmtc.c > palmtreo.c > palmz72.c > spitz_pm.c > tosa.c > trizeps4.c > vpac270.c > z2.c > zeus.c > zylonite.c > zylonite_pxa300.c > zylonite_pxa320.c > > So I was wondering how you made the choice of which files you add the include to > and which you don't touch ? By building the pxa_defconfig, see what errors it reports and then fix them. Isn't pxa_defconfig building all the variants? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Fri, 20 Jan 2017 09:27:29 +0100 Subject: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h In-Reply-To: <87efzydusi.fsf@belgarion.home> References: <1484313256-25993-1-git-send-email-ulf.hansson@linaro.org> <1484313256-25993-2-git-send-email-ulf.hansson@linaro.org> <87efzydusi.fsf@belgarion.home> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20 January 2017 at 09:01, Robert Jarzmik wrote: > Ulf Hansson writes: > >> Some of the pxa platforms, balloon3, colibri-pxa270-income, corgi, >> trizeps4, vpac270, zeus and zylonite depends on leds.h. Explicitly include >> it instead of relying on the public mmc header host.h. >> >> Cc: Daniel Mack >> Cc: Haojian Zhuang >> Cc: Robert Jarzmik >> Cc: >> Signed-off-by: Ulf Hansson >> --- >> >> I am seeking an ack for this change as following changes for mmc in the >> series, has build-dependencies to it. > Acked-by: Robert Jarzmik > > Actually I already have a patch for arch/arm/mach-pxa/idp.c which adds this > include also in my -next tree, just in case you're tempted to modify this one, > which would conflict with my pxa tree. > > An other point, I checked which files don't have a leds.h : > - grep -ls _led arch/arm/mach-pxa/*.c > /tmp/a > - grep -ls 'linux/leds.h' arch/arm/mach-pxa/*.c > /tmp/b > - sdiff -s /tmp/a /tmp/b > This gives me : > balloon3.c > colibri-pxa270-income.c > corgi.c > corgi_pm.c > em-x270.c > ezx.c > hx4700.c > magician.c > palmld.c > palmtc.c > palmtreo.c > palmz72.c > spitz_pm.c > tosa.c > trizeps4.c > vpac270.c > z2.c > zeus.c > zylonite.c > zylonite_pxa300.c > zylonite_pxa320.c > > So I was wondering how you made the choice of which files you add the include to > and which you don't touch ? By building the pxa_defconfig, see what errors it reports and then fix them. Isn't pxa_defconfig building all the variants? Kind regards Uffe