From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbaKYH7c (ORCPT ); Tue, 25 Nov 2014 02:59:32 -0500 Received: from mail-qg0-f49.google.com ([209.85.192.49]:47578 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbaKYH73 (ORCPT ); Tue, 25 Nov 2014 02:59:29 -0500 MIME-Version: 1.0 In-Reply-To: <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> References: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> Date: Tue, 25 Nov 2014 08:59:29 +0100 Message-ID: Subject: Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain From: Ulf Hansson To: Amit Daniel Kachhap Cc: "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , Kukjin Kim , "linux-kernel@vger.kernel.org" , Sylwester Nawrocki , pankaj.dubey@samsung.com, Kevin Hilman , "linux-pm@vger.kernel.org" , Geert Uytterhoeven , "Rafael J. Wysocki" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24 November 2014 at 14:04, Amit Daniel Kachhap wrote: > This patch adds supports for parent power domain. This will ensure > invoking of parent/child power domain on/off in a correct sequence. > In exynos7 SOC's, power domain controllers have parent and child > hierarchy. > > Cc: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap > --- > .../bindings/arm/exynos/power_domain.txt | 2 + > drivers/soc/samsung/pm_domains.c | 43 +++++++++++++++++++- > 2 files changed, 44 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > index 00ebda1..0160bdc 100644 > --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > @@ -24,6 +24,7 @@ Optional Properties: > - pclkN, clkN: Pairs of parent of input clock and input clock to the > devices in this power domain. Maximum of 4 pairs (N = 0 to 3) > are supported currently. > +- parents: phandle of parent power domains. > > Node of a device using power domains must have a samsung,power-domain property > defined with a phandle to respective power domain. > @@ -48,6 +49,7 @@ Example: > mfc_pd: power-domain@10044060 { > compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; > reg = <0x10044060 0x20>; > + parents = <&pd_top>; > #power-domain-cells = <0>; > }; This seems like a good and generic approach to describe that a PM domain could have a parent. I would suggest to rename it, such it reflects its a PM domain binding though. So, maybe we can add this as a common DT binding for the generic PM domain instead of having it as Exynos specific? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain Date: Tue, 25 Nov 2014 08:59:29 +0100 Message-ID: References: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> Sender: linux-pm-owner@vger.kernel.org To: Amit Daniel Kachhap Cc: "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , Kukjin Kim , "linux-kernel@vger.kernel.org" , Sylwester Nawrocki , pankaj.dubey@samsung.com, Kevin Hilman , "linux-pm@vger.kernel.org" , Geert Uytterhoeven , "Rafael J. Wysocki" , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 24 November 2014 at 14:04, Amit Daniel Kachhap wrote: > This patch adds supports for parent power domain. This will ensure > invoking of parent/child power domain on/off in a correct sequence. > In exynos7 SOC's, power domain controllers have parent and child > hierarchy. > > Cc: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap > --- > .../bindings/arm/exynos/power_domain.txt | 2 + > drivers/soc/samsung/pm_domains.c | 43 +++++++++++++++++++- > 2 files changed, 44 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > index 00ebda1..0160bdc 100644 > --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > @@ -24,6 +24,7 @@ Optional Properties: > - pclkN, clkN: Pairs of parent of input clock and input clock to the > devices in this power domain. Maximum of 4 pairs (N = 0 to 3) > are supported currently. > +- parents: phandle of parent power domains. > > Node of a device using power domains must have a samsung,power-domain property > defined with a phandle to respective power domain. > @@ -48,6 +49,7 @@ Example: > mfc_pd: power-domain@10044060 { > compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; > reg = <0x10044060 0x20>; > + parents = <&pd_top>; > #power-domain-cells = <0>; > }; This seems like a good and generic approach to describe that a PM domain could have a parent. I would suggest to rename it, such it reflects its a PM domain binding though. So, maybe we can add this as a common DT binding for the generic PM domain instead of having it as Exynos specific? Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Tue, 25 Nov 2014 08:59:29 +0100 Subject: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain In-Reply-To: <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> References: <1416833572-6880-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-1-git-send-email-amit.daniel@samsung.com> <1416834256-11225-8-git-send-email-amit.daniel@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 24 November 2014 at 14:04, Amit Daniel Kachhap wrote: > This patch adds supports for parent power domain. This will ensure > invoking of parent/child power domain on/off in a correct sequence. > In exynos7 SOC's, power domain controllers have parent and child > hierarchy. > > Cc: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap > --- > .../bindings/arm/exynos/power_domain.txt | 2 + > drivers/soc/samsung/pm_domains.c | 43 +++++++++++++++++++- > 2 files changed, 44 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > index 00ebda1..0160bdc 100644 > --- a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > +++ b/Documentation/devicetree/bindings/arm/exynos/power_domain.txt > @@ -24,6 +24,7 @@ Optional Properties: > - pclkN, clkN: Pairs of parent of input clock and input clock to the > devices in this power domain. Maximum of 4 pairs (N = 0 to 3) > are supported currently. > +- parents: phandle of parent power domains. > > Node of a device using power domains must have a samsung,power-domain property > defined with a phandle to respective power domain. > @@ -48,6 +49,7 @@ Example: > mfc_pd: power-domain at 10044060 { > compatible = "samsung,exynos4210-pd", "samsung,exynos7-pd-mfc"; > reg = <0x10044060 0x20>; > + parents = <&pd_top>; > #power-domain-cells = <0>; > }; This seems like a good and generic approach to describe that a PM domain could have a parent. I would suggest to rename it, such it reflects its a PM domain binding though. So, maybe we can add this as a common DT binding for the generic PM domain instead of having it as Exynos specific? Kind regards Uffe