From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbdCMIVJ (ORCPT ); Mon, 13 Mar 2017 04:21:09 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:33390 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbdCMIU4 (ORCPT ); Mon, 13 Mar 2017 04:20:56 -0400 MIME-Version: 1.0 In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> From: Ulf Hansson Date: Mon, 13 Mar 2017 09:20:43 +0100 Message-ID: Subject: Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells To: Dave Gerlach Cc: "Rafael J. Wysocki" , Kevin Hilman , Santosh Shilimkar , Rob Herring , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Nishanth Menon , Keerthy , Russell King , Tero Kristo , Sudeep Holla Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7 March 2017 at 11:22, Dave Gerlach wrote: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Ulf Hansson > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > } > > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells Date: Mon, 13 Mar 2017 09:20:43 +0100 Message-ID: References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Sender: linux-pm-owner@vger.kernel.org To: Dave Gerlach Cc: "Rafael J. Wysocki" , Kevin Hilman , Santosh Shilimkar , Rob Herring , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Nishanth Menon , Keerthy , Russell King , Tero Kristo , Sudeep Holla List-Id: devicetree@vger.kernel.org On 7 March 2017 at 11:22, Dave Gerlach wrote: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Ulf Hansson > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > } > > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulf.hansson@linaro.org (Ulf Hansson) Date: Mon, 13 Mar 2017 09:20:43 +0100 Subject: [PATCH v4 2/5] PM / Domains: Do not check if simple providers have phandle cells In-Reply-To: <1488882154-21485-3-git-send-email-d-gerlach@ti.com> References: <1488882154-21485-1-git-send-email-d-gerlach@ti.com> <1488882154-21485-3-git-send-email-d-gerlach@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7 March 2017 at 11:22, Dave Gerlach wrote: > There is no reason that a platform genpd driver registered using > of_genpd_add_provider_simple needs to be constrained to having no cells > in the "power-domains" phandle. Currently the genpd framework will fail > if any arguments are passed with for a simple provider but the framework > does not actually care, so remove the check for phandle argument count. > > This will allow greater flexibility for genpd providers to use their own > arguments that are passed in the phandle and interpret them however they > see fit. > > Signed-off-by: Dave Gerlach Acked-by: Ulf Hansson > --- > v3->v4: > Drop ti,sci-id device property and instead describe using phandle cell > for id. > > drivers/base/power/domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index e697dec9d25b..8e0550c27394 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1622,8 +1622,6 @@ static struct generic_pm_domain *genpd_xlate_simple( > struct of_phandle_args *genpdspec, > void *data) > { > - if (genpdspec->args_count != 0) > - return ERR_PTR(-EINVAL); > return data; > } > > -- > 2.11.0 >