All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
@ 2022-10-24 18:17 ` Brian Norris
  0 siblings, 0 replies; 8+ messages in thread
From: Brian Norris @ 2022-10-24 18:17 UTC (permalink / raw)
  To: Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, Adrian Hunter, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc, Brian Norris

This driver is pretty simple, and it can be useful to build it (for
validation purposes) without BMIPS or ARCH_BRCMSTB.

It technically depends on CONFIG_OF to do anything useful at runtime,
but it still works out OK for compile-testing using the !OF stubs.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 drivers/mmc/host/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f324daadaf70..453fba8d2d9d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
 
 config MMC_SDHCI_BRCMSTB
 	tristate "Broadcom SDIO/SD/MMC support"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	depends on MMC_SDHCI_PLTFM
 	select MMC_CQHCI
-	default y
+	default ARCH_BRCMSTB || BMIPS_GENERIC
 	help
 	  This selects support for the SDIO/SD/MMC Host Controller on
 	  Broadcom STB SoCs.
-- 
2.38.0.135.g90850a2211-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
@ 2022-10-24 18:17 ` Brian Norris
  0 siblings, 0 replies; 8+ messages in thread
From: Brian Norris @ 2022-10-24 18:17 UTC (permalink / raw)
  To: Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, Adrian Hunter, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc, Brian Norris

This driver is pretty simple, and it can be useful to build it (for
validation purposes) without BMIPS or ARCH_BRCMSTB.

It technically depends on CONFIG_OF to do anything useful at runtime,
but it still works out OK for compile-testing using the !OF stubs.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 drivers/mmc/host/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f324daadaf70..453fba8d2d9d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
 
 config MMC_SDHCI_BRCMSTB
 	tristate "Broadcom SDIO/SD/MMC support"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC
+	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
 	depends on MMC_SDHCI_PLTFM
 	select MMC_CQHCI
-	default y
+	default ARCH_BRCMSTB || BMIPS_GENERIC
 	help
 	  This selects support for the SDIO/SD/MMC Host Controller on
 	  Broadcom STB SoCs.
-- 
2.38.0.135.g90850a2211-goog


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
  2022-10-24 18:17 ` Brian Norris
@ 2022-10-24 18:22   ` Florian Fainelli
  -1 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-10-24 18:22 UTC (permalink / raw)
  To: Brian Norris, Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, Adrian Hunter, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc

On 10/24/22 11:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Yeah, really no reason not to let you build it, thanks Brian!
-- 
Florian


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
@ 2022-10-24 18:22   ` Florian Fainelli
  0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-10-24 18:22 UTC (permalink / raw)
  To: Brian Norris, Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, Adrian Hunter, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc

On 10/24/22 11:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Yeah, really no reason not to let you build it, thanks Brian!
-- 
Florian


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
  2022-10-24 18:17 ` Brian Norris
@ 2022-10-25 11:08   ` Adrian Hunter
  -1 siblings, 0 replies; 8+ messages in thread
From: Adrian Hunter @ 2022-10-25 11:08 UTC (permalink / raw)
  To: Brian Norris, Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc

On 24/10/22 21:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>  
>  config MMC_SDHCI_BRCMSTB
>  	tristate "Broadcom SDIO/SD/MMC support"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>  	depends on MMC_SDHCI_PLTFM
>  	select MMC_CQHCI
> -	default y
> +	default ARCH_BRCMSTB || BMIPS_GENERIC
>  	help
>  	  This selects support for the SDIO/SD/MMC Host Controller on
>  	  Broadcom STB SoCs.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
@ 2022-10-25 11:08   ` Adrian Hunter
  0 siblings, 0 replies; 8+ messages in thread
From: Adrian Hunter @ 2022-10-25 11:08 UTC (permalink / raw)
  To: Brian Norris, Ulf Hansson, Florian Fainelli
  Cc: Al Cooper, linux-kernel, linux-arm-kernel,
	Broadcom internal kernel review list, linux-mmc

On 24/10/22 21:17, Brian Norris wrote:
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
> 
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>  
>  config MMC_SDHCI_BRCMSTB
>  	tristate "Broadcom SDIO/SD/MMC support"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>  	depends on MMC_SDHCI_PLTFM
>  	select MMC_CQHCI
> -	default y
> +	default ARCH_BRCMSTB || BMIPS_GENERIC
>  	help
>  	  This selects support for the SDIO/SD/MMC Host Controller on
>  	  Broadcom STB SoCs.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
  2022-10-24 18:17 ` Brian Norris
@ 2022-10-26 11:25   ` Ulf Hansson
  -1 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-10-26 11:25 UTC (permalink / raw)
  To: Brian Norris
  Cc: Florian Fainelli, Al Cooper, linux-kernel, Adrian Hunter,
	linux-arm-kernel, Broadcom internal kernel review list,
	linux-mmc

On Mon, 24 Oct 2022 at 20:18, Brian Norris <briannorris@chromium.org> wrote:
>
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
>
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>
>  config MMC_SDHCI_BRCMSTB
>         tristate "Broadcom SDIO/SD/MMC support"
> -       depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>         depends on MMC_SDHCI_PLTFM
>         select MMC_CQHCI
> -       default y
> +       default ARCH_BRCMSTB || BMIPS_GENERIC
>         help
>           This selects support for the SDIO/SD/MMC Host Controller on
>           Broadcom STB SoCs.
> --
> 2.38.0.135.g90850a2211-goog
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST
@ 2022-10-26 11:25   ` Ulf Hansson
  0 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-10-26 11:25 UTC (permalink / raw)
  To: Brian Norris
  Cc: Florian Fainelli, Al Cooper, linux-kernel, Adrian Hunter,
	linux-arm-kernel, Broadcom internal kernel review list,
	linux-mmc

On Mon, 24 Oct 2022 at 20:18, Brian Norris <briannorris@chromium.org> wrote:
>
> This driver is pretty simple, and it can be useful to build it (for
> validation purposes) without BMIPS or ARCH_BRCMSTB.
>
> It technically depends on CONFIG_OF to do anything useful at runtime,
> but it still works out OK for compile-testing using the !OF stubs.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f324daadaf70..453fba8d2d9d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1040,10 +1040,10 @@ config MMC_SDHCI_MICROCHIP_PIC32
>
>  config MMC_SDHCI_BRCMSTB
>         tristate "Broadcom SDIO/SD/MMC support"
> -       depends on ARCH_BRCMSTB || BMIPS_GENERIC
> +       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
>         depends on MMC_SDHCI_PLTFM
>         select MMC_CQHCI
> -       default y
> +       default ARCH_BRCMSTB || BMIPS_GENERIC
>         help
>           This selects support for the SDIO/SD/MMC Host Controller on
>           Broadcom STB SoCs.
> --
> 2.38.0.135.g90850a2211-goog
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-10-26 11:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 18:17 [PATCH] mmc: sdhci-brcmstb: Allow building with COMPILE_TEST Brian Norris
2022-10-24 18:17 ` Brian Norris
2022-10-24 18:22 ` Florian Fainelli
2022-10-24 18:22   ` Florian Fainelli
2022-10-25 11:08 ` Adrian Hunter
2022-10-25 11:08   ` Adrian Hunter
2022-10-26 11:25 ` Ulf Hansson
2022-10-26 11:25   ` Ulf Hansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.