From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AE9C433E0 for ; Tue, 23 Mar 2021 14:13:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F188F60295 for ; Tue, 23 Mar 2021 14:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbhCWONF (ORCPT ); Tue, 23 Mar 2021 10:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232206AbhCWOMg (ORCPT ); Tue, 23 Mar 2021 10:12:36 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67EECC0613D8 for ; Tue, 23 Mar 2021 07:12:36 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id i26so10975013lfl.1 for ; Tue, 23 Mar 2021 07:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l19bR+nFxXiu4GIfVq6f/m3LcDLqMDiNOa9Zpl4Ovvc=; b=K2WN6O0RNtylg2y5kj+7tUO3G3Ow+0lo/9Kbfq2doL0HIfUyReVmwWRdhF0uGNJ2OX Sf9sQUS2cU+99jYx7m3iFdK6k47YBGTOsnDBoiJD97coMPMO/lhH3U2sptWPOEIKO4H7 YKr76EcmmC4dtIC8svew3hPv2dkrnaPY/Lq4EyGjEcvwN9FoVLvmOC/7dMwxApzKoebv SNkM+3naV4PXRdlZ/+86gfwzP06/2XLnnBDnSB/PWjL2e1cGIZAgoKHGTGQy8UxmfpbI qszWcnijbnse7HrTyooN+GkyEGYI6hkC3TXrEPzfmKXfvlr8EjllH/lgx+m5Xjj/4kQ9 swaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l19bR+nFxXiu4GIfVq6f/m3LcDLqMDiNOa9Zpl4Ovvc=; b=ZwjC0T5in8w2KgcB3YiJtiy5yCmbuSpQKJg6HEeNID4pIp47ZasKiIz4QJRnckijhV qSXzntaKttyWCMxRapH5DUW32H9/4WY7z0DsG6y75E/yeZxa4u9qkxn8OBVG6xZ2F5UR vFxOo+gGhdc5pOilxwkuEgzoGyXLn5CZgdEA/VpKrpE1CFETZlqaHGsX6831r2GV4IUr g1GD6GKLGreQfW/ld8T3KHQaylHM/SZAUuBI2Q0INz66HsMg/j6W8VTeXoIUWTZ/6fWP nzPf6blZFgeIcj8mGyDidEFkzLPYoB3PQdSh83+gfU5sBDuwZ6sx9LC49J1+NclRQl31 6jhQ== X-Gm-Message-State: AOAM531pCPTMpKFmNp01ayLQoFeQSULoIemTYV4vrBjLLbPslUN4GLk+ phYN8g1k/h/iZsNEaXfFwieIO5A2OUxz99t+b5NpPw== X-Google-Smtp-Source: ABdhPJzly95nqr4yJOsMgNbyvkzewf61fS24O2skNJrtHSN97B0AO6qNDxBBBfq6gMyuY4h8Z8m/nW9MARYn+j3bS1I= X-Received: by 2002:a19:501b:: with SMTP id e27mr2822930lfb.584.1616508753810; Tue, 23 Mar 2021 07:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-9-Jerome.Pouiller@silabs.com> <4503971.bAhddQ8uqO@pc-42> In-Reply-To: <4503971.bAhddQ8uqO@pc-42> From: Ulf Hansson Date: Tue, 23 Mar 2021 15:11:56 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= Cc: linux-wireless , netdev , driverdevel , Linux Kernel Mailing List , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , DTML , Rob Herring , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 22 Mar 2021 at 18:14, J=C3=A9r=C3=B4me Pouiller wrote: > > Hello Ulf, > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > wrote: > > > > > > From: J=C3=A9r=C3=B4me Pouiller > > > > > > Signed-off-by: J=C3=A9r=C3=B4me Pouiller > > > --- > > > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 +++++++++++++++++++= ++ > > > 1 file changed, 259 insertions(+) > > > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c > > > > [...] > > > > > +static const struct sdio_device_id wfx_sdio_ids[] =3D { > > > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF= 200) }, > > > + { }, > > > +}; > > > +MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids); > > > + > > > +struct sdio_driver wfx_sdio_driver =3D { > > > + .name =3D "wfx-sdio", > > > + .id_table =3D wfx_sdio_ids, > > > + .probe =3D wfx_sdio_probe, > > > + .remove =3D wfx_sdio_remove, > > > + .drv =3D { > > > + .owner =3D THIS_MODULE, > > > + .of_match_table =3D wfx_sdio_of_match, > > > > It's not mandatory to support power management, like system > > suspend/resume. However, as this looks like this is a driver for an > > embedded SDIO device, you probably want this. > > > > If that is the case, please assign the dev_pm_ops here and implement > > the ->suspend|resume() callbacks. > > I have no platform to test suspend/resume, so I have only a > theoretical understanding of this subject. I see. > > I understanding is that with the current implementation, the > device will be powered off on suspend and then totally reset > (including reloading of the firmware) on resume. I am wrong? You are correct, for a *removable* SDIO card. In this case, the mmc/sdio core will remove the corresponding SDIO card/device and its corresponding SDIO func devices at system suspend. It will then be redetected at system resume (and the SDIO func driver re-probed). Although, as this is an embedded SDIO device, per definition it's not a removable card (MMC_CAP_NONREMOVABLE should be set for the corresponding mmc host), the SDIO card will stick around and instead the ->suspend|resume() callback needs to be implemented for the SDIO func driver. > > This behavior sounds correct to me. You would expect something > more? Yes, see above. Kind regards Uffe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC76C433DB for ; Tue, 23 Mar 2021 14:12:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C84B619BB for ; Tue, 23 Mar 2021 14:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C84B619BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 40C536082E; Tue, 23 Mar 2021 14:12:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rzI3wmpZjBHg; Tue, 23 Mar 2021 14:12:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 1D75C60833; Tue, 23 Mar 2021 14:12:39 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 7EA531BF947 for ; Tue, 23 Mar 2021 14:12:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7B2AA40386 for ; Tue, 23 Mar 2021 14:12:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M6q744cOdCwN for ; Tue, 23 Mar 2021 14:12:36 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by smtp2.osuosl.org (Postfix) with ESMTPS id 683E8400AC for ; Tue, 23 Mar 2021 14:12:36 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id q29so26690896lfb.4 for ; Tue, 23 Mar 2021 07:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l19bR+nFxXiu4GIfVq6f/m3LcDLqMDiNOa9Zpl4Ovvc=; b=K2WN6O0RNtylg2y5kj+7tUO3G3Ow+0lo/9Kbfq2doL0HIfUyReVmwWRdhF0uGNJ2OX Sf9sQUS2cU+99jYx7m3iFdK6k47YBGTOsnDBoiJD97coMPMO/lhH3U2sptWPOEIKO4H7 YKr76EcmmC4dtIC8svew3hPv2dkrnaPY/Lq4EyGjEcvwN9FoVLvmOC/7dMwxApzKoebv SNkM+3naV4PXRdlZ/+86gfwzP06/2XLnnBDnSB/PWjL2e1cGIZAgoKHGTGQy8UxmfpbI qszWcnijbnse7HrTyooN+GkyEGYI6hkC3TXrEPzfmKXfvlr8EjllH/lgx+m5Xjj/4kQ9 swaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l19bR+nFxXiu4GIfVq6f/m3LcDLqMDiNOa9Zpl4Ovvc=; b=PdRafM4guFSwIRS+a0DWzS7+HfL+xH57WHE/AeBQUfe1lvnJ1eP64AHqH/i/iG6iR1 6aBsGgYYYSoQpKhAcOK7HH1ngKVyqGgzUDkG3ICb4URrNJ/ELq56MwlLb96pwdlHgFK8 ftz6lPq3v4n6l3Dyq288SU8GTxwFyETTHV4S/c9lcy6BIjcegTwLefEce/OaNZPcjtTj 3b/2ZtNWjwVk9HchmHS+x9LKauaODaukLMHV7J5rW1JXzK6gJqAsC3opcGalzcwmHIDK eiR4Z0LjqtVv0de/Dq8IUDdN+9aQWAm1IurDo1m3eRumL1wjIRX7o3TmeNFzq7bY6CMR kLkQ== X-Gm-Message-State: AOAM533dX8RFDf3OL4kuxI7uOfCOmxu0XTWXljmzowdFh0jBZKypSh3Z 1mqc7xUKpVT6rOTpusdL79edJpcv4UQ771VrnG+i7A== X-Google-Smtp-Source: ABdhPJzly95nqr4yJOsMgNbyvkzewf61fS24O2skNJrtHSN97B0AO6qNDxBBBfq6gMyuY4h8Z8m/nW9MARYn+j3bS1I= X-Received: by 2002:a19:501b:: with SMTP id e27mr2822930lfb.584.1616508753810; Tue, 23 Mar 2021 07:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20210315132501.441681-1-Jerome.Pouiller@silabs.com> <20210315132501.441681-9-Jerome.Pouiller@silabs.com> <4503971.bAhddQ8uqO@pc-42> In-Reply-To: <4503971.bAhddQ8uqO@pc-42> From: Ulf Hansson Date: Tue, 23 Mar 2021 15:11:56 +0100 Message-ID: Subject: Re: [PATCH v5 08/24] wfx: add bus_sdio.c To: =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , DTML , netdev , linux-wireless , Linux Kernel Mailing List , Rob Herring , Greg Kroah-Hartman , linux-mmc , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "David S . Miller" , Kalle Valo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gTW9uLCAyMiBNYXIgMjAyMSBhdCAxODoxNCwgSsOpcsO0bWUgUG91aWxsZXIKPGplcm9tZS5w b3VpbGxlckBzaWxhYnMuY29tPiB3cm90ZToKPgo+IEhlbGxvIFVsZiwKPgo+IE9uIE1vbmRheSAy MiBNYXJjaCAyMDIxIDEzOjIwOjM1IENFVCBVbGYgSGFuc3NvbiB3cm90ZToKPiA+IE9uIE1vbiwg MTUgTWFyIDIwMjEgYXQgMTQ6MjUsIEplcm9tZSBQb3VpbGxlcgo+ID4gPEplcm9tZS5Qb3VpbGxl ckBzaWxhYnMuY29tPiB3cm90ZToKPiA+ID4KPiA+ID4gRnJvbTogSsOpcsO0bWUgUG91aWxsZXIg PGplcm9tZS5wb3VpbGxlckBzaWxhYnMuY29tPgo+ID4gPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBK w6lyw7RtZSBQb3VpbGxlciA8amVyb21lLnBvdWlsbGVyQHNpbGFicy5jb20+Cj4gPiA+IC0tLQo+ ID4gPiAgZHJpdmVycy9uZXQvd2lyZWxlc3Mvc2lsYWJzL3dmeC9idXNfc2Rpby5jIHwgMjU5ICsr KysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDI1OSBpbnNlcnRpb25z KCspCj4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9uZXQvd2lyZWxlc3Mvc2lsYWJz L3dmeC9idXNfc2Rpby5jCj4gPgo+ID4gWy4uLl0KPiA+Cj4gPiA+ICtzdGF0aWMgY29uc3Qgc3Ry dWN0IHNkaW9fZGV2aWNlX2lkIHdmeF9zZGlvX2lkc1tdID0gewo+ID4gPiArICAgICAgIHsgU0RJ T19ERVZJQ0UoU0RJT19WRU5ET1JfSURfU0lMQUJTLCBTRElPX0RFVklDRV9JRF9TSUxBQlNfV0Yy MDApIH0sCj4gPiA+ICsgICAgICAgeyB9LAo+ID4gPiArfTsKPiA+ID4gK01PRFVMRV9ERVZJQ0Vf VEFCTEUoc2Rpbywgd2Z4X3NkaW9faWRzKTsKPiA+ID4gKwo+ID4gPiArc3RydWN0IHNkaW9fZHJp dmVyIHdmeF9zZGlvX2RyaXZlciA9IHsKPiA+ID4gKyAgICAgICAubmFtZSA9ICJ3Zngtc2RpbyIs Cj4gPiA+ICsgICAgICAgLmlkX3RhYmxlID0gd2Z4X3NkaW9faWRzLAo+ID4gPiArICAgICAgIC5w cm9iZSA9IHdmeF9zZGlvX3Byb2JlLAo+ID4gPiArICAgICAgIC5yZW1vdmUgPSB3Znhfc2Rpb19y ZW1vdmUsCj4gPiA+ICsgICAgICAgLmRydiA9IHsKPiA+ID4gKyAgICAgICAgICAgICAgIC5vd25l ciA9IFRISVNfTU9EVUxFLAo+ID4gPiArICAgICAgICAgICAgICAgLm9mX21hdGNoX3RhYmxlID0g d2Z4X3NkaW9fb2ZfbWF0Y2gsCj4gPgo+ID4gSXQncyBub3QgbWFuZGF0b3J5IHRvIHN1cHBvcnQg cG93ZXIgbWFuYWdlbWVudCwgbGlrZSBzeXN0ZW0KPiA+IHN1c3BlbmQvcmVzdW1lLiBIb3dldmVy LCBhcyB0aGlzIGxvb2tzIGxpa2UgdGhpcyBpcyBhIGRyaXZlciBmb3IgYW4KPiA+IGVtYmVkZGVk IFNESU8gZGV2aWNlLCB5b3UgcHJvYmFibHkgd2FudCB0aGlzLgo+ID4KPiA+IElmIHRoYXQgaXMg dGhlIGNhc2UsIHBsZWFzZSBhc3NpZ24gdGhlIGRldl9wbV9vcHMgaGVyZSBhbmQgaW1wbGVtZW50 Cj4gPiB0aGUgLT5zdXNwZW5kfHJlc3VtZSgpIGNhbGxiYWNrcy4KPgo+IEkgaGF2ZSBubyBwbGF0 Zm9ybSB0byB0ZXN0IHN1c3BlbmQvcmVzdW1lLCBzbyBJIGhhdmUgb25seSBhCj4gdGhlb3JldGlj YWwgdW5kZXJzdGFuZGluZyBvZiB0aGlzIHN1YmplY3QuCgpJIHNlZS4KCj4KPiBJIHVuZGVyc3Rh bmRpbmcgaXMgdGhhdCB3aXRoIHRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uLCB0aGUKPiBkZXZp Y2Ugd2lsbCBiZSBwb3dlcmVkIG9mZiBvbiBzdXNwZW5kIGFuZCB0aGVuIHRvdGFsbHkgcmVzZXQK PiAoaW5jbHVkaW5nIHJlbG9hZGluZyBvZiB0aGUgZmlybXdhcmUpIG9uIHJlc3VtZS4gSSBhbSB3 cm9uZz8KCllvdSBhcmUgY29ycmVjdCwgZm9yIGEgKnJlbW92YWJsZSogU0RJTyBjYXJkLiBJbiB0 aGlzIGNhc2UsIHRoZQptbWMvc2RpbyBjb3JlIHdpbGwgcmVtb3ZlIHRoZSBjb3JyZXNwb25kaW5n IFNESU8gY2FyZC9kZXZpY2UgYW5kIGl0cwpjb3JyZXNwb25kaW5nIFNESU8gZnVuYyBkZXZpY2Vz IGF0IHN5c3RlbSBzdXNwZW5kLiBJdCB3aWxsIHRoZW4gYmUKcmVkZXRlY3RlZCBhdCBzeXN0ZW0g cmVzdW1lIChhbmQgdGhlIFNESU8gZnVuYyBkcml2ZXIgcmUtcHJvYmVkKS4KCkFsdGhvdWdoLCBh cyB0aGlzIGlzIGFuIGVtYmVkZGVkIFNESU8gZGV2aWNlLCBwZXIgZGVmaW5pdGlvbiBpdCdzIG5v dAphIHJlbW92YWJsZSBjYXJkIChNTUNfQ0FQX05PTlJFTU9WQUJMRSBzaG91bGQgYmUgc2V0IGZv ciB0aGUKY29ycmVzcG9uZGluZyBtbWMgaG9zdCksIHRoZSBTRElPIGNhcmQgd2lsbCBzdGljayBh cm91bmQgYW5kIGluc3RlYWQKdGhlIC0+c3VzcGVuZHxyZXN1bWUoKSBjYWxsYmFjayBuZWVkcyB0 byBiZSBpbXBsZW1lbnRlZCBmb3IgdGhlIFNESU8KZnVuYyBkcml2ZXIuCgo+Cj4gVGhpcyBiZWhh dmlvciBzb3VuZHMgY29ycmVjdCB0byBtZS4gWW91IHdvdWxkIGV4cGVjdCBzb21ldGhpbmcKPiBt b3JlPwoKWWVzLCBzZWUgYWJvdmUuCgpLaW5kIHJlZ2FyZHMKVWZmZQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxA bGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVj dC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK